From: Mark Walters Date: Wed, 11 Jul 2012 18:57:04 +0000 (+0100) Subject: [PATCH 0/3] Notmuch pick: a threaded view X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=1aba059c5f5f939837873c0ce320be0bc436f6bc;p=notmuch-archives.git [PATCH 0/3] Notmuch pick: a threaded view --- diff --git a/a9/da7e430f54872d61ef3d6c86afb4aefe291701 b/a9/da7e430f54872d61ef3d6c86afb4aefe291701 new file mode 100644 index 000000000..7b60786ae --- /dev/null +++ b/a9/da7e430f54872d61ef3d6c86afb4aefe291701 @@ -0,0 +1,120 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1C538429E34 + for ; Wed, 11 Jul 2012 11:57:22 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.201 +X-Spam-Level: +X-Spam-Status: No, score=0.201 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001, + RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 1GAeAOpg3k6t for ; + Wed, 11 Jul 2012 11:57:19 -0700 (PDT) +Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com + [74.125.82.41]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client + certificate requested) by olra.theworths.org (Postfix) with ESMTPS id + A1176431FAE for ; Wed, 11 Jul 2012 11:57:19 -0700 + (PDT) +Received: by wgbds1 with SMTP id ds1so512063wgb.2 + for ; Wed, 11 Jul 2012 11:57:16 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:date:message-id:x-mailer; + bh=z/ayXMJphAjtkwIJU1SD2RtYg13EPqici3MiSUX74Go=; + b=yS0ngeXDM2nHmiyrIw0oM99ve6sNs2GXMMzDY/CnYCYibl1j2xQM9z+EijTGed+cOl + zfRHEtd0I11eyx4ATgaFoTmZtYcm49Qkd9enWElpmjuZh9Avsl4TacsgE7fa8XBwMEyH + iZkV9G9+ZAxyPbAv3jTXCjAkZCNtxn60Rbr0VIef+KxZBiOVEIACT/Ems3pSfT+6xeS5 + PMcs2IRHHGGo1iEEGI9aQFbHDdwN35SCQGpzFh5RQ/qe1LcUwt7Kj00vHsx/+V7QMJUJ + NXOL4E3/sSPtwPEp1e8ZIRog1V9PhTGtP46vzlJp6RwzWYuqPn8eNkLLW1tGbyPrO/Ck + iBdQ== +Received: by 10.216.166.197 with SMTP id g47mr19305637wel.179.1342033036885; + Wed, 11 Jul 2012 11:57:16 -0700 (PDT) +Received: from localhost (94-192-233-223.zone6.bethere.co.uk. + [94.192.233.223]) by mx.google.com with ESMTPS id + t7sm6969540wix.6.2012.07.11.11.57.15 (version=TLSv1/SSLv3 cipher=OTHER); Wed, + 11 Jul 2012 11:57:15 -0700 (PDT) +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: [PATCH 0/3] Notmuch pick: a threaded view +Date: Wed, 11 Jul 2012 19:57:04 +0100 +Message-Id: <1342033027-30286-1-git-send-email-markwalters1009@gmail.com> +X-Mailer: git-send-email 1.7.9.1 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 11 Jul 2012 18:57:22 -0000 + +Hello + +Notmuch pick is an emacs view which displays a threaded view of +messages: each message has its own line and the thread structure is +shown with UTF-8 graphics characters (so it looks vaguely similar to +mutt's threaded view) + +Pick was originally written by David Edmondon and posted on irc and I +have been developing it on and off since. Now that almost all the +backend changes it uses are in I would like to see about getting it +into mainline. + +However, the code is definitely not of the same standard as the main +notmuch code. One suggestion on irc was that we put it in contrib and +ship a stub notmuch-pick.el file in mainline so all a user would need +to do is replace the stub by the full version and compile. + +This patch series implements this approach. I have managed to keep the +impact on the main notmuch code minimal: a stub pick file (which is +almost entirely the copyright boilerplate) and a entry from the main +notmuch.el. The way it works is that notmuch unconditionally calls +notmuch-pick-init when started: in the default case (the stub file) +this does nothing, whereas if the user replaces the stub by the full +file this sets up all the keybinding etc. + +I have code for another approach which is only a little bigger: I add +a variable notmuch-pick-wanted and if the user sets this (which could +be by using setq in their .emacs file, or we could add a defcustom +option) which tells the code whether to load the pick functionality or +not. + +In all the above cases this should give no change for a user who does +not enable the functionality. In the latter two cases notmuch-pick +would show up during compilation, whereas in the former it should be +completely invisible. + +Any comments on the preferred approach? + +Finally there have been suggestion that the name notmuch-pick is not +intuitive: are there any suggestions for a better name? + +Best wishes + +Mark + +Mark Walters (3): + emacs: add a stub notmuch-pick.el file + emacs: add a stub entry to notmuch-pick in notmuch.el + emacs: make notmuch-show return its buffer + + emacs/Makefile.local | 3 ++- + emacs/notmuch-pick.el | 28 ++++++++++++++++++++++++++++ + emacs/notmuch-show.el | 3 ++- + emacs/notmuch.el | 2 ++ + 4 files changed, 34 insertions(+), 2 deletions(-) + create mode 100644 emacs/notmuch-pick.el + +-- +1.7.9.1 +