From: Austin Clements Date: Sat, 14 Jul 2012 21:51:56 +0000 (+2000) Subject: Re: [PATCH v2 4/7] emacs: Use result text properties for search result iteration X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=1a58a3496800982e3c5493f2a16b935ff576945c;p=notmuch-archives.git Re: [PATCH v2 4/7] emacs: Use result text properties for search result iteration --- diff --git a/52/525b22d9818b6b2542dfc1c4c17b9b1bf74598 b/52/525b22d9818b6b2542dfc1c4c17b9b1bf74598 new file mode 100644 index 000000000..9a5387a5f --- /dev/null +++ b/52/525b22d9818b6b2542dfc1c4c17b9b1bf74598 @@ -0,0 +1,133 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id E26DC431FBD + for ; Sat, 14 Jul 2012 14:51:59 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id xFWcgx+RzJ9E for ; + Sat, 14 Jul 2012 14:51:59 -0700 (PDT) +Received: from dmz-mailsec-scanner-3.mit.edu (DMZ-MAILSEC-SCANNER-3.MIT.EDU + [18.9.25.14]) + by olra.theworths.org (Postfix) with ESMTP id 49F4A431FBC + for ; Sat, 14 Jul 2012 14:51:59 -0700 (PDT) +X-AuditID: 1209190e-b7fb56d0000008b2-cf-5001e9fe9459 +Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) + by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP + id 23.66.02226.EF9E1005; Sat, 14 Jul 2012 17:51:58 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q6ELpw1E027764; + Sat, 14 Jul 2012 17:51:58 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q6ELpuFd003423 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Sat, 14 Jul 2012 17:51:57 -0400 (EDT) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1SqAFo-0003px-Ou; Sat, 14 Jul 2012 17:51:56 -0400 +Date: Sat, 14 Jul 2012 17:51:56 -0400 +From: Austin Clements +To: Jameson Graef Rollins +Subject: Re: [PATCH v2 4/7] emacs: Use result text properties for search + result iteration +Message-ID: <20120714215156.GH31670@mit.edu> +References: <1342140319-19859-1-git-send-email-amdragon@mit.edu> + <1342237406-32507-1-git-send-email-amdragon@mit.edu> + <1342237406-32507-5-git-send-email-amdragon@mit.edu> + <87d33yf8bi.fsf@servo.finestructure.net> + <20120714195003.GF31670@mit.edu> + <874npaqc60.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <874npaqc60.fsf@servo.finestructure.net> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmpgleLIzCtJLcpLzFFi42IRYrdT0f33kjHAYPYhE4s9+7wsrt+cyezA + 5HH3NJfHs1W3mAOYorhsUlJzMstSi/TtErgylsxpYS34LVCx5t4apgbGSbxdjBwcEgImErva + wroYOYFMMYkL99azdTFycQgJ7GOU2LBvJjuEs4FR4ue7/8wQzkkmiZVNDSwgLUICSxgllj3Q + BLFZBFQlZr2cwwZiswloSGzbv5wRxBYRMJPo+fIHzGYWkJb49ruZCcQWFoiW6OmdC1bPK6Aj + ceH/ZXaImcuZJFrOp0PEBSVOznzCAtGrJXHj30smkKtB5iz/xwES5hQwlZj4qAVsvKiAisSU + k9vYJjAKzULSPQtJ9yyE7gWMzKsYZVNyq3RzEzNzilOTdYuTE/PyUot0jfVyM0v0UlNKNzGC + AppTkm8H49eDSocYBTgYlXh4M/0ZAoRYE8uKK3MPMUpyMCmJ8l54zhggxJeUn1KZkVicEV9U + mpNafIhRgoNZSYSXvxMox5uSWFmVWpQPk5LmYFES572SctNfSCA9sSQ1OzW1ILUIJivDwaEk + wVsBjFwhwaLU9NSKtMycEoQ0EwcnyHAeoOGyIDW8xQWJucWZ6RD5U4yKUuK8RiAJAZBERmke + XC8s4bxiFAd6RZi3GKSKB5is4LpfAQ1mAho86+c/f6DBJYkIKakGRpZyu3eHuzfNr93aN+fl + U/Hw/Rfqc+QVo58dLnWdUFm3z143n+NPmIajwuLkeVaf5sqdaw7f8e3v5cU8hYdipweKis8M + XaQwnU/0Tw3jNRPud56Fx/eY5NuJlvw2tjFcNit76aqWKx5TfDZmKMtyxBRbvrwbwHj13DzF + Ixc1/339fuJeOveLeUosxRmJhlrMRcWJAAykmtITAwAA +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 14 Jul 2012 21:52:00 -0000 + +Quoth Jameson Graef Rollins on Jul 14 at 2:13 pm: +> On Sat, Jul 14 2012, Austin Clements wrote: +> > That's strange. What was the error? +> > +> > I've been testing with +> > (("date" . "%12s ") +> > ("count" . "%-7s ") +> > ("authors" . "%-20s ") +> > ("subject" . "\n%s ") +> > ("tags" . "(%s)")) +> > But maybe there are other cases it doesn't handle correctly? +> +> Hrm. The error was: +> +> error in process filter: wrong type argument: wholenump, -13 +> +> However, that's in my test emacs setup. It works fine in my normal +> emacs session. Lets assume this is just a problem with my setup that +> I'll look into. + +Interesting. The "error in process filter" suggests that it is +happening somewhere in the notmuch code under the search process +filter, so it's probably some combination of something unusual in your +environment and this patch. If you M-x toggle-debug-on-error, will it +drop you into the debugger when this happens? + +> The other problem I seem to be running into is that the +> customize-variable interface definitely doesn't handle newlines very +> well. If I try to add a '\n' in the interface it gets escaped, so I end +> up with: +> +> ("subject" . "\\n%s ") +> +> If I add the '\n' manually in my config, notmuch-search then interprets +> the string correctly and adds newlines to the search results, but then +> the customize-variable interface interprets the newline and adds a +> newline the string field that kind makes the interface a little weird. +> Is there "proper" way to add a newline to a string value in the +> customize-variable interface that I'm not aware of? + +I think this is just a sharp corner in customize and there's notmuch +we can do about it. I believe the "proper" way to enter the newline +directly in customize is to hit C-q C-j (same way you get a raw +newline in any other buffer). Given that I wouldn't expect anyone to +guess that, though, we could mention this in the defcustom's +docstring. + +> In any event, this is in no way a blocker for this patch series. This +> is all totally tangential. The patch series is great. +> +> jamie.