From: David Bremner <david@tethera.net>
Date: Tue, 19 Feb 2013 01:16:42 +0000 (+2000)
Subject: Re: [PATCH 1/6] lib: Clean up error handling in _notmuch_thread_create
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=19b096e985b8f9d76706acf527a5eb5810733bf0;p=notmuch-archives.git

Re: [PATCH 1/6] lib: Clean up error handling in _notmuch_thread_create
---

diff --git a/c3/f58c169109aa317ca6116a2ce3ebbcad6e032d b/c3/f58c169109aa317ca6116a2ce3ebbcad6e032d
new file mode 100644
index 000000000..ab0009d2e
--- /dev/null
+++ b/c3/f58c169109aa317ca6116a2ce3ebbcad6e032d
@@ -0,0 +1,75 @@
+Return-Path: <bremner@unb.ca>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 80EDC431FB6
+	for <notmuch@notmuchmail.org>; Mon, 18 Feb 2013 17:16:51 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id zutLMeFW5JgR for <notmuch@notmuchmail.org>;
+	Mon, 18 Feb 2013 17:16:51 -0800 (PST)
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id F3FA4431FAF
+	for <notmuch@notmuchmail.org>; Mon, 18 Feb 2013 17:16:50 -0800 (PST)
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net
+	([156.34.82.78] helo=zancas.localnet)
+	by tesseract.cs.unb.ca with esmtpsa
+	(TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)
+	(envelope-from <bremner@unb.ca>)
+	id 1U7bpA-0005pf-RY; Mon, 18 Feb 2013 21:16:49 -0400
+Received: from bremner by zancas.localnet with local (Exim 4.80)
+	(envelope-from <bremner@unb.ca>)
+	id 1U7bp4-0003iQ-LG; Mon, 18 Feb 2013 21:16:42 -0400
+From: David Bremner <david@tethera.net>
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 1/6] lib: Clean up error handling in
+ _notmuch_thread_create
+In-Reply-To: <87fw0tumuy.fsf@zancas.localnet>
+References: <1353819427-13182-1-git-send-email-amdragon@mit.edu>
+	<1353819427-13182-2-git-send-email-amdragon@mit.edu>
+	<87fw0tumuy.fsf@zancas.localnet>
+User-Agent: Notmuch/0.15.2+32~g16aa65b (http://notmuchmail.org) Emacs/24.2.1
+	(x86_64-pc-linux-gnu)
+Date: Mon, 18 Feb 2013 21:16:42 -0400
+Message-ID: <87bobhumpx.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-Spam_bar: -
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Tue, 19 Feb 2013 01:16:51 -0000
+
+David Bremner <david@tethera.net> writes:
+
+> Austin Clements <amdragon@MIT.EDU> writes:
+>
+>> Previously, there were various opportunities for memory leaks in the
+>> error-handling paths of this function.  Use a local talloc context and
+>> some reparenting to make eliminate these leaks, while keeping the
+>> control flow simple.
+>
+> pushed all but the python bindings patch.
+
+any comments on that patch, Justus?
+
+For reference, id:1353819427-13182-6-git-send-email-amdragon@mit.edu
+
+d