From: Jameson Graef Rollins Date: Sun, 5 Aug 2012 21:41:18 +0000 (+1700) Subject: Re: [PATCH 1/2] test: emacs: call accept-process-output in notmuch-test-wait X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=192d59d2b3047dc15753c3f221f41391df4ea04f;p=notmuch-archives.git Re: [PATCH 1/2] test: emacs: call accept-process-output in notmuch-test-wait --- diff --git a/c2/7aae1896bc11f536f0cfe007523a7e384fbbe5 b/c2/7aae1896bc11f536f0cfe007523a7e384fbbe5 new file mode 100644 index 000000000..5069c4627 --- /dev/null +++ b/c2/7aae1896bc11f536f0cfe007523a7e384fbbe5 @@ -0,0 +1,92 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1131C431FB6 + for ; Sun, 5 Aug 2012 14:41:25 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.29 +X-Spam-Level: +X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id eOsmZiQ3p75n for ; + Sun, 5 Aug 2012 14:41:24 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id 235AC431FAE + for ; Sun, 5 Aug 2012 14:41:24 -0700 (PDT) +Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by earth-doxen-postvirus (Postfix) with ESMTP id D03EF66E00D0; + Sun, 5 Aug 2012 14:41:21 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new +Received: from finestructure.net (unknown [76.89.192.57]) + (Authenticated sender: jrollins) + by earth-doxen-submit (Postfix) with ESMTP id E6C8566E00A6; + Sun, 5 Aug 2012 14:41:18 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id 7CB2E47E; Sun, 5 Aug 2012 14:41:18 -0700 (PDT) +From: Jameson Graef Rollins +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/2] test: emacs: call accept-process-output in + notmuch-test-wait +In-Reply-To: <1344165182-29246-1-git-send-email-tomi.ollila@iki.fi> +References: <1344165182-29246-1-git-send-email-tomi.ollila@iki.fi> +User-Agent: Notmuch/0.13.2+121~gfda8989 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sun, 05 Aug 2012 14:41:18 -0700 +Message-ID: <87vcgxuidd.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 05 Aug 2012 21:41:25 -0000 + +--=-=-= + +On Sun, Aug 05 2012, Tomi Ollila wrote: +> notmuch-test-wait called sleep-for in a loop to wait unconditionally 0.1 +> seconds while waiting for process to exit. +> accept-process-output returns as soon as there is any data available +> from process, so using it avoids unnecessary fixed delays. +> Both of these functions run process sentinels. + +If this and the following function fix the emacs test crashes on the +buildds then LGTM+++. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQIcBAEBCAAGBQJQHuh+AAoJEO00zqvie6q8HXQP/16H/kUPLMeKroHzylDksbSl ++7IOJQa9jxKtJFM3BmvFtBMFXOob0JHD7ldd/p/GRd0hVMNk/Ur8cG4PdVybs+nq +NLB3RZkIGN+Yzq2JWgAdilqD38auXp81jKQn/TsJZmSN1I8OtFDdKSLvZK7VXdEJ +Z7lDwqGxd/yQonMzJs+40xaAa87BFyetgYI6usIt1cGWGmLA4hrHaGlVmVVcIynf +q0INApfYlejDW+nuv2K3q7bYXfF92tNvLpAM2ji5KAtugJods4MmFjpgS6H/9SQE +smWJ9944Ir8ohFxYJWoL2jXlTz09XRsLlkfgzzJj9lOL+apnwe/r6fPvlDXeHHmJ +MO4dKkP61WVKJ5Ua7Jf6arArOEncD7uekMoX+Tt+VynVfc/NKRXZslIPVOeIJN9D ++VSonWll9Z9gnNQBr0NgLrtgFImNVEUt3qa2pbxv/RjJLujbopO84tNdjfjxskCZ +YuxgSMxOWPvq91sXbhnqh49QPLNuN3hHBtBBAtjJI62ZmHyWMgNXJqsb3y10NxNK +4dHTQrY+1SON2Q9dDwnP4hM5BboCDxULYj8Dy17+Rzibl8CM+7SD3uym2Y6FG62z +2T45Ree4a+RN7kAhfeAHPtmbtMfere+2T4UxrgK3FfPMBMJ4OAyJY/YHFhIm/WVU +njwT4v3ZWrAmNrqLyt+5 +=9GvR +-----END PGP SIGNATURE----- +--=-=-=--