From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
Date: Wed, 1 Feb 2012 14:21:33 +0000 (+0400)
Subject: Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when... 
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=189c749c28c814315e9445919ed596fe0504e6ac;p=notmuch-archives.git

Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."
---

diff --git a/1f/3a54bda54e68be6642cc72484aa49f9ed641fc b/1f/3a54bda54e68be6642cc72484aa49f9ed641fc
new file mode 100644
index 000000000..dd1a9ac64
--- /dev/null
+++ b/1f/3a54bda54e68be6642cc72484aa49f9ed641fc
@@ -0,0 +1,101 @@
+Return-Path: <dmitry.kurochkin@gmail.com>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 438A9421192
+	for <notmuch@notmuchmail.org>; Wed,  1 Feb 2012 06:22:49 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: -0.799
+X-Spam-Level: 
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
+	tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
+	FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id b24d-r4bZgb7 for <notmuch@notmuchmail.org>;
+	Wed,  1 Feb 2012 06:22:48 -0800 (PST)
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
+	[209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 74B42429E5B
+	for <notmuch@notmuchmail.org>; Wed,  1 Feb 2012 06:22:48 -0800 (PST)
+Received: by bke11 with SMTP id 11so1210308bke.26
+	for <notmuch@notmuchmail.org>; Wed, 01 Feb 2012 06:22:47 -0800 (PST)
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
+	h=from:to:cc:subject:in-reply-to:references:user-agent:date
+	:message-id:mime-version:content-type;
+	bh=p+ua8PV7E+yJZnmN6UGFJ6pObshfJln/6WSNpKCVxO0=;
+	b=vzcmcxzl9hiEIoy7pe6hRtT/Wp87KghnQeq82jc3Sp4PalATgklRkIzQ7qeGUfC29K
+	tloqotLRxelbBs3F6ZJgW0YmPXf73M8l1GOPheWSBzNGBvkQitAzdCCnRpWxJ92ENgwf
+	f+GECcNdK4FIM2bleIpcNTDqsdhvtcqHa6IvU=
+Received: by 10.205.124.15 with SMTP id gm15mr13158948bkc.63.1328106166962;
+	Wed, 01 Feb 2012 06:22:46 -0800 (PST)
+Received: from localhost ([91.144.186.21])
+	by mx.google.com with ESMTPS id o26sm48807015bko.14.2012.02.01.06.22.45
+	(version=TLSv1/SSLv3 cipher=OTHER);
+	Wed, 01 Feb 2012 06:22:46 -0800 (PST)
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
+To: Pieter Praet <pieter@praet.org>, David Edmondson <dme@dme.org>,
+	David Bremner <david@tethera.net>, Jani Nikula <jani@nikula.org>
+Subject: Re: [PATCH] emacs: globally replace non-branching "(if COND (progn
+	..." with "(when ..."
+In-Reply-To: <874nva7jkk.fsf@praet.org>
+References: <87k44uprvy.fsf@praet.org>
+	<1326532638-22068-1-git-send-email-pieter@praet.org>
+	<87y5ssxam7.fsf@zancas.localnet>
+	<CAB+hUn-GmONr24nfxBkt59TzHHyZiD1wioYXoPh9wy-rZR-m2g@mail.gmail.com>
+	<87ty3fycje.fsf@zancas.localnet>
+	<cunliopilwj.fsf@hotblack-desiato.hh.sledj.net>
+	<874nva7jkk.fsf@praet.org>
+User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1
+	(x86_64-pc-linux-gnu)
+Date: Wed, 01 Feb 2012 18:21:33 +0400
+Message-ID: <87bopimy6q.fsf@gmail.com>
+MIME-Version: 1.0
+Content-Type: text/plain; charset=us-ascii
+Cc: Notmuch Mail <notmuch@notmuchmail.org>
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Wed, 01 Feb 2012 14:22:49 -0000
+
+On Wed, 01 Feb 2012 14:46:19 +0100, Pieter Praet <pieter@praet.org> wrote:
+> On Mon, 30 Jan 2012 09:23:40 +0000, David Edmondson <dme@dme.org> wrote:
+> > On Sat, 28 Jan 2012 13:14:45 -0400, David Bremner <david@tethera.net> wrote:
+> > > On Sat, 28 Jan 2012 14:55:22 +0200, Jani Nikula <jani@nikula.org> wrote:
+> > > > On Jan 28, 2012 2:41 PM, "David Bremner" <david@tethera.net> wrote:
+> > > > 
+> > > > Sometimes someone (Dmitry?) sent patches that separated a small functional
+> > > > change, and the big non-functional indentation change it caused,
+> > > > separately. Would you prefer (or tolerate ;) that style?
+> > > 
+> > > Hmm, that might be nicer, I'm not 100% sure.
+> > > 
+> > > I wouldn't say it's mandatory for a patch like this (and I'd say other
+> > > peoples views on what's easy to review are at least as important as mine
+> > > here).
+> > 
+> > Each patch should be valid in the repository without any following
+> > patches (preceding are obviously okay). Incorrect indentation would
+> > disqualify a patch from being 'valid', so it shouldn't be accepted.
+> 
+> +1.
+> 
+> Indentation corrections should always be part of the same patch as
+> the change(s) that invalidated the indentation in the first place.
+> 
+> Spotting the *actual* (non-indentation) changes is a non-issue
+> when using `diff-refine-hunk' (or a wrapper thereof [1]).
+> 
+
+Must... resist... getting... into... this...