From: Jameson Graef Rollins Date: Wed, 23 May 2012 01:43:48 +0000 (+1700) Subject: [PATCH v3 4/6] cli: modify mime_node_context to use the new crypto struct X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=174508af98b6f17bacefa44749213ef16edb4689;p=notmuch-archives.git [PATCH v3 4/6] cli: modify mime_node_context to use the new crypto struct --- diff --git a/0f/f845a829e34c616581c15d2502b8155707dcc2 b/0f/f845a829e34c616581c15d2502b8155707dcc2 new file mode 100644 index 000000000..4285d5553 --- /dev/null +++ b/0f/f845a829e34c616581c15d2502b8155707dcc2 @@ -0,0 +1,141 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 4F34D431FC0 + for ; Tue, 22 May 2012 18:43:57 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id LyGL6m5R479O for ; + Tue, 22 May 2012 18:43:56 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id BF01D431FB6 + for ; Tue, 22 May 2012 18:43:56 -0700 (PDT) +Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by earth-doxen-postvirus (Postfix) with ESMTP id 58F1A66E0159 + for ; Tue, 22 May 2012 18:43:56 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new +Received: from finestructure.net (gwave-125.ligo.caltech.edu + [131.215.114.125]) (Authenticated sender: jrollins) by earth-doxen-submit + (Postfix) with ESMTP id 6A58866E0172 for ; Tue, 22 + May 2012 18:43:54 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id 3BF361E2; Tue, 22 May 2012 18:43:54 -0700 (PDT) +From: Jameson Graef Rollins +To: Notmuch Mail +Subject: [PATCH v3 4/6] cli: modify mime_node_context to use the new crypto + struct +Date: Tue, 22 May 2012 18:43:48 -0700 +Message-Id: <1337737430-21160-5-git-send-email-jrollins@finestructure.net> +X-Mailer: git-send-email 1.7.10 +In-Reply-To: <1337737430-21160-4-git-send-email-jrollins@finestructure.net> +References: <1337737430-21160-1-git-send-email-jrollins@finestructure.net> + <1337737430-21160-2-git-send-email-jrollins@finestructure.net> + <1337737430-21160-3-git-send-email-jrollins@finestructure.net> + <1337737430-21160-4-git-send-email-jrollins@finestructure.net> +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 23 May 2012 01:43:57 -0000 + +This simplifies some more interfaces and gets rid of another #ifdef. +--- + mime-node.c | 22 ++++++++-------------- + 1 file changed, 8 insertions(+), 14 deletions(-) + +diff --git a/mime-node.c b/mime-node.c +index 183ff5d..a838224 100644 +--- a/mime-node.c ++++ b/mime-node.c +@@ -33,12 +33,7 @@ typedef struct mime_node_context { + GMimeMessage *mime_message; + + /* Context provided by the caller. */ +-#ifdef GMIME_ATLEAST_26 +- GMimeCryptoContext *cryptoctx; +-#else +- GMimeCipherContext *cryptoctx; +-#endif +- notmuch_bool_t decrypt; ++ notmuch_crypto_t *crypto; + } mime_node_context_t; + + static int +@@ -113,8 +108,7 @@ mime_node_open (const void *ctx, notmuch_message_t *message, + goto DONE; + } + +- mctx->cryptoctx = crypto->gpgctx; +- mctx->decrypt = crypto->decrypt; ++ mctx->crypto = crypto; + + /* Create the root node */ + root->part = GMIME_OBJECT (mctx->mime_message); +@@ -190,7 +184,7 @@ _mime_node_create (mime_node_t *parent, GMimeObject *part) + + /* Handle PGP/MIME parts */ + if (GMIME_IS_MULTIPART_ENCRYPTED (part) +- && node->ctx->cryptoctx && node->ctx->decrypt) { ++ && node->ctx->crypto->gpgctx && node->ctx->crypto->decrypt) { + if (node->nchildren != 2) { + /* this violates RFC 3156 section 4, so we won't bother with it. */ + fprintf (stderr, "Error: %d part(s) for a multipart/encrypted " +@@ -203,10 +197,10 @@ _mime_node_create (mime_node_t *parent, GMimeObject *part) + #ifdef GMIME_ATLEAST_26 + GMimeDecryptResult *decrypt_result = NULL; + node->decrypted_child = g_mime_multipart_encrypted_decrypt +- (encrypteddata, node->ctx->cryptoctx, &decrypt_result, &err); ++ (encrypteddata, node->ctx->crypto->gpgctx, &decrypt_result, &err); + #else + node->decrypted_child = g_mime_multipart_encrypted_decrypt +- (encrypteddata, node->ctx->cryptoctx, &err); ++ (encrypteddata, node->ctx->crypto->gpgctx, &err); + #endif + if (node->decrypted_child) { + node->decrypt_success = node->verify_attempted = TRUE; +@@ -224,7 +218,7 @@ _mime_node_create (mime_node_t *parent, GMimeObject *part) + (err ? err->message : "no error explanation given")); + } + } +- } else if (GMIME_IS_MULTIPART_SIGNED (part) && node->ctx->cryptoctx) { ++ } else if (GMIME_IS_MULTIPART_SIGNED (part) && node->ctx->crypto->gpgctx) { + if (node->nchildren != 2) { + /* this violates RFC 3156 section 5, so we won't bother with it. */ + fprintf (stderr, "Error: %d part(s) for a multipart/signed message " +@@ -233,7 +227,7 @@ _mime_node_create (mime_node_t *parent, GMimeObject *part) + } else { + #ifdef GMIME_ATLEAST_26 + node->sig_list = g_mime_multipart_signed_verify +- (GMIME_MULTIPART_SIGNED (part), node->ctx->cryptoctx, &err); ++ (GMIME_MULTIPART_SIGNED (part), node->ctx->crypto->gpgctx, &err); + node->verify_attempted = TRUE; + + if (!node->sig_list) +@@ -249,7 +243,7 @@ _mime_node_create (mime_node_t *parent, GMimeObject *part) + * In GMime 2.6, they're both non-const, so we'll be able + * to clean up this asymmetry. */ + GMimeSignatureValidity *sig_validity = g_mime_multipart_signed_verify +- (GMIME_MULTIPART_SIGNED (part), node->ctx->cryptoctx, &err); ++ (GMIME_MULTIPART_SIGNED (part), node->ctx->crypto->gpgctx, &err); + node->verify_attempted = TRUE; + node->sig_validity = sig_validity; + if (sig_validity) { +-- +1.7.10 +