From: Mark Walters Date: Sun, 8 Jul 2012 06:15:38 +0000 (+0100) Subject: Re: [PATCH] emacs: Fix notmuch-message-mark-replied. X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=16f37b53196f216136f803d43bd79420e808ed30;p=notmuch-archives.git Re: [PATCH] emacs: Fix notmuch-message-mark-replied. --- diff --git a/2a/f605be28d4bfa7294bc8b2213e550022ff18b1 b/2a/f605be28d4bfa7294bc8b2213e550022ff18b1 new file mode 100644 index 000000000..3af0677b7 --- /dev/null +++ b/2a/f605be28d4bfa7294bc8b2213e550022ff18b1 @@ -0,0 +1,124 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id ABE9F431FB6 + for ; Sat, 7 Jul 2012 23:15:44 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 5MUlXy5FhiDi for ; + Sat, 7 Jul 2012 23:15:44 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id BB77B431FAE + for ; Sat, 7 Jul 2012 23:15:43 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1SnkmU-0001Uk-8f; Sun, 08 Jul 2012 07:15:42 +0100 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1SnkmT-0004cQ-R4; Sun, 08 Jul 2012 07:15:41 +0100 +From: Mark Walters +To: Ingo Lohmar , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: Fix notmuch-message-mark-replied. +In-Reply-To: <87vcj8ckzm.fsf@acer.localhost.com> +References: <87vcj8ckzm.fsf@acer.localhost.com> +User-Agent: Notmuch/0.13.2+61~gf708609 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sun, 08 Jul 2012 07:15:38 +0100 +Message-ID: <87bojqrd6d.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: d3bd0b0e81ef06fb708c5da77aea86e1 (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 08 Jul 2012 06:15:45 -0000 + +On Sun, 03 Jun 2012, Ingo Lohmar wrote: +> notmuch-message-mark-replied used "apply" to change message tags +> according to notmuch-message-replied-tags after sending a reply. This +> works if the latter is a single-element list. But with the recently +> changed format of tag changes, it breaks for multiple-element lists. +> Use "funcall" to properly pass the list of tag changes as a single +> argument. + +This looks correct to me: the bug is still in current master and this +does fix it. + +As Jamie says, it would be nice to have a test. Unfortunately, that is +beyond my test/emacs skills. + +Note this bug does not occur with default configuration but the option +is a defcustom option, and following the example in that option's +documentation will cause the problem. + +Since this patch has been around for over a month I think it should +probably be applied. + +Best wishes + +Mark + +> --- +> emacs/notmuch-message.el | 2 +- +> 1 file changed, 1 insertion(+), 1 deletion(-) +> +> diff --git a/emacs/notmuch-message.el b/emacs/notmuch-message.el +> index 5964caa..d3738bf 100644 +> --- a/emacs/notmuch-message.el +> +++ b/emacs/notmuch-message.el +> @@ -45,7 +45,7 @@ the \"inbox\" and \"todo\", you would set +> (concat "+" str) +> str)) +> notmuch-message-replied-tags))) +> - (apply 'notmuch-tag (notmuch-id-to-query (car (car rep))) tags))))) +> + (funcall 'notmuch-tag (notmuch-id-to-query (car (car rep))) tags))))) +> +> (add-hook 'message-send-hook 'notmuch-message-mark-replied) +> +> -- +> 1.7.10 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch