From: Austin Clements Date: Thu, 29 Mar 2012 05:59:17 +0000 (+2000) Subject: Re: [PATCH v3 0/4] cli: notmuch tag/restore refactoring X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=133284d972d245afd1491e1be2d2869aee2b3981;p=notmuch-archives.git Re: [PATCH v3 0/4] cli: notmuch tag/restore refactoring --- diff --git a/16/ccc913cde335d1643855ae684a15012fe51e2c b/16/ccc913cde335d1643855ae684a15012fe51e2c new file mode 100644 index 000000000..3fd34d273 --- /dev/null +++ b/16/ccc913cde335d1643855ae684a15012fe51e2c @@ -0,0 +1,92 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 2CCD8431FAF + for ; Wed, 28 Mar 2012 22:59:21 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id poQUzZqZseKm for ; + Wed, 28 Mar 2012 22:59:20 -0700 (PDT) +Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU + [18.9.25.13]) + by olra.theworths.org (Postfix) with ESMTP id 292B3431FAE + for ; Wed, 28 Mar 2012 22:59:20 -0700 (PDT) +X-AuditID: 1209190d-b7fbf6d0000008ba-14-4f73fa372c2b +Received: from mailhub-auth-4.mit.edu ( [18.7.62.39]) + by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP + id 43.C0.02234.73AF37F4; Thu, 29 Mar 2012 01:59:19 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q2T5xJRB010812; + Thu, 29 Mar 2012 01:59:19 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q2T5xHEM013236 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Thu, 29 Mar 2012 01:59:18 -0400 (EDT) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1SD8OD-0006uC-Kh; Thu, 29 Mar 2012 01:59:17 -0400 +Date: Thu, 29 Mar 2012 01:59:17 -0400 +From: Austin Clements +To: Jani Nikula +Subject: Re: [PATCH v3 0/4] cli: notmuch tag/restore refactoring +Message-ID: <20120329055917.GC2670@mit.edu> +References: +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFuphleLIzCtJLcpLzFFi42IRYrdT1zX/Vexv0HNOx6JpurPF9ZszmS3e + rJzH6sDscfjrQhaPW/dfs3s8W3WLOYA5issmJTUnsyy1SN8ugSvjz/HPTAVHWCo65/9gaWA8 + ytzFyMEhIWAi0bWCp4uRE8gUk7hwbz1bFyMXh5DAPkaJCafmM0M4Gxglnq2/ApU5ySSx4PAD + KGcJo8Tpn0/YQPpZBFQl1jfeZAKx2QQ0JLbtX84IYosIKEpsPrkfzGYW0JdYeXImM4gtLOAg + 8aVzPwuIzSugLfHu5yWwXiEBI4lJ+74wQ8QFJU7OfMIC0aslcePfSyaQs5kFpCWW/+MACXMK + GEs0TP4ENl5UQEViysltbBMYhWYh6Z6FpHsWQvcCRuZVjLIpuVW6uYmZOcWpybrFyYl5ealF + ukZ6uZkleqkppZsYQYHOKcm7g/HdQaVDjAIcjEo8vKc0i/2FWBPLiitzDzFKcjApifKe+w4U + 4kvKT6nMSCzOiC8qzUktPsQowcGsJMLrfg4ox5uSWFmVWpQPk5LmYFES51XVeucnJJCeWJKa + nZpakFoEk5Xh4FCS4K36CdQoWJSanlqRlplTgpBm4uAEGc4DNLwOpIa3uCAxtzgzHSJ/ilFR + Spw3GCQhAJLIKM2D64UloleM4kCvCPPGglTxAJMYXPcroMFMQIOXHMkHGVySiJCSamBM/NzK + Fxa4IPSL0rGWzwVCT74yeUisqso6enPBlSPPMyYdWNF35mferDPPXWy0a7zjs2JmbD5343Bh + wGqhHPnzIlZ9y8vedTBdPvBsz+uK474v3/0OC7af+r9l/cTdG3jtfkop22S6ROy+MN9gxW4x + 3T8te2VrZaSMWt+xhej/9JPb8uNpvJeJEktxRqKhFnNRcSIAVVfJbh8DAAA= +Cc: tomi.ollila@iki.fi, notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 29 Mar 2012 05:59:21 -0000 + +Quoth Jani Nikula on Mar 27 at 12:04 am: +> v3 of id:"cover.1332702915.git.jani@nikula.org" with the following +> mostly non-functional changes: +> +> - add test for the current tagging behaviour in patch 1, and change the +> test in patch 2 when the behaviour is changed +> - handle the no tag changes case in _optimize_tag_query() in patch 2 +> - add braces around the "tag_ops[tag_ops_count].remove = (argv[i][0] == '-');" +> assignment +> - document the tag_query() function a bit in patch 3 +> - make tag_message() static in patch 4 +> +> BR, +> Jani. + +LGTM.