From: ccx Date: Tue, 17 Jul 2012 10:18:08 +0000 (+0200) Subject: Re: Notmuch scripts (again), now with more usenet X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=12312961245ea51ddcb66010078312d8e9a2d76b;p=notmuch-archives.git Re: Notmuch scripts (again), now with more usenet --- diff --git a/20/37df366cf034b9a8fbe30fd39dbb91671e54b9 b/20/37df366cf034b9a8fbe30fd39dbb91671e54b9 new file mode 100644 index 000000000..50782f719 --- /dev/null +++ b/20/37df366cf034b9a8fbe30fd39dbb91671e54b9 @@ -0,0 +1,116 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id D372B431FAF + for ; Tue, 17 Jul 2012 03:18:15 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 1.274 +X-Spam-Level: * +X-Spam-Status: No, score=1.274 tagged_above=-999 required=5 + tests=[RDNS_NONE=1.274] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id KtrnN6SfUTiB for ; + Tue, 17 Jul 2012 03:18:12 -0700 (PDT) +Received: from new.webprojekty.cz (unknown [178.238.36.176]) + by olra.theworths.org (Postfix) with ESMTP id 477A3431FAE + for ; Tue, 17 Jul 2012 03:18:12 -0700 (PDT) +Received: from shell.webprojekty.cz (shell.vs [192.168.100.30]) + by new.webprojekty.cz (Postfix) with SMTP id B73AEB8C5E2; + Tue, 17 Jul 2012 12:18:08 +0200 (CEST) +Received: by shell.webprojekty.cz (sSMTP sendmail emulation); + Tue, 17 Jul 2012 12:18:08 +0200 +Date: Tue, 17 Jul 2012 12:18:08 +0200 +From: ccx@webprojekty.cz +To: notmuch@notmuchmail.org +Subject: Re: Notmuch scripts (again), now with more usenet +Message-ID: <20120717101808.GA30479@dorje.inet.te2000> +References: <20120714050156.GA11178@dorje.inet.te2000> + <87ipdp9e1l.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: multipart/signed; micalg=pgp-sha1; + protocol="application/pgp-signature"; boundary="wRRV7LY7NUeQGEoC" +Content-Disposition: inline +In-Reply-To: <87ipdp9e1l.fsf@maritornes.cs.unb.ca> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 17 Jul 2012 10:18:16 -0000 + + +--wRRV7LY7NUeQGEoC +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +Content-Transfer-Encoding: quoted-printable + +On Sun, Jul 15, 2012 at 10:36:54AM -0600, David Bremner wrote: +> ccx@webprojekty.cz writes: +>=20 +> > I hope it's now in the form acceptable for inclusion to contrib. +>=20 +> Dear Jan; +>=20 +> Without looking too much at the details I think this is reasonable to +> include in contrib, as a set of examples if nothing else. Still, I'm +> curious about a few things. Are there actual users (other than the +> author)? What would we do about bug reports? Will you follow the list, +> or would we explicitely tell people to contact you directly? + +I might not always have time to read the entirety of the ML, so it would +be great if people CC me when posting there. + +> I guess some of the python experts might want to discuss the coding +> style of notmuch-new.py. pylint goes ballistic, for whatever that is +> worth. + +That's mainly because of tabs used for indentation, which used to be +considered a viable alternative, but is now considered obsolete. I +reformatted the code to conform to pep8 guidelines. + +> For the shell stuff, I noticed lots of unquoted parameter expansion; +> also at some point you make a temporary directory using $$ +> directly rather than using e.g. mktemp. + +Zsh does not word-split parameter expansion by default, this is +intentional. The temporary directories are created in xdg cache dir, +which should not be susceptible to symlink attacks etc. and the pid +actually helps to correlate the directories to processes, eg. when you +want to autoclean after searches that got killed for some reason. + +> What did you have in mind for a license? since there is no linking here, +> it does not have to be GPL3+, but some standard Free license is needed I +> think; since I'm also maintaining the Debian package, I don't want to +> have to remove your stuff before uploading to Debian. + +You can consider it public domain. I guess I should add wtfpl text to my +repo. :-) + +> d + +Thanks very much for your rewiev. + +--wRRV7LY7NUeQGEoC +Content-Type: application/pgp-signature; name="signature.asc" +Content-Description: Digital signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v2.0.19 (GNU/Linux) + +iEYEARECAAYFAlAFO+AACgkQq2Q0xnrW+pnsKACfcM66QoShwYevk+JmkRkmaDNH +UmgAnAhtwyxr2mA7DcYtqdB32NtyWxDd +=ke0R +-----END PGP SIGNATURE----- + +--wRRV7LY7NUeQGEoC--