From: Adam Wolfe Gordon Date: Tue, 10 Apr 2012 17:19:07 +0000 (+1800) Subject: Re: [PATCH 1/2] cli: make --entire-thread=false work for format=json. X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=12039e87c04f21d30b69224fd2bd2e0d929a67d1;p=notmuch-archives.git Re: [PATCH 1/2] cli: make --entire-thread=false work for format=json. --- diff --git a/d6/ce39fdb05ce2f6f2b4b9e39fb72f4b77cba2eb b/d6/ce39fdb05ce2f6f2b4b9e39fb72f4b77cba2eb new file mode 100644 index 000000000..0bddb8780 --- /dev/null +++ b/d6/ce39fdb05ce2f6f2b4b9e39fb72f4b77cba2eb @@ -0,0 +1,97 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 110EC431FAF + for ; Tue, 10 Apr 2012 10:19:11 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 37Op8aS+FQvV for ; + Tue, 10 Apr 2012 10:19:10 -0700 (PDT) +Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com + [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 6025C431FAE + for ; Tue, 10 Apr 2012 10:19:10 -0700 (PDT) +Received: by lban1 with SMTP id n1so29267lba.26 + for ; Tue, 10 Apr 2012 10:19:07 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=mime-version:sender:x-originating-ip:in-reply-to:references:date + :x-google-sender-auth:message-id:subject:from:to:cc:content-type + :content-transfer-encoding:x-gm-message-state; + bh=RmK15CgDOaxHQUxV0R6lktB+/EI9jc3Pht79iQChkBQ=; + b=ChyU1bnPkccHX2Ut14W7oezqKx1Q+eVkJu21mLMTWkLlrpqUrPKCbXzylxFYTbQPey + tBL3L0EyUdsginHjHBWDXgR6T0jwSiQUjMmwf+nlEq2+QpSJB7mp7FpAOuY9pjN71C0/ + 9rD6k56+QSO19H24N9CalRJqH3HVeD8gfOKk4rG2YIDV7g1DsX7wZAGRPCsyfcMNP5Zy + B+LjOBl+XBEzLIbT0E0U92sXjsyOZrI0PK5WvIcGKonB0PN9UUocHPsTeUz2PE5YZjOT + /a99EtTSflXHaS/WL8zV2VnW88nzdPL3F56jiP6O2GoFiNxcPNh0R4Viwyh9GhBJx1fp + nc1Q== +MIME-Version: 1.0 +Received: by 10.152.129.137 with SMTP id nw9mr15497086lab.48.1334078347148; + Tue, 10 Apr 2012 10:19:07 -0700 (PDT) +Sender: awg@xvx.ca +Received: by 10.112.97.14 with HTTP; Tue, 10 Apr 2012 10:19:07 -0700 (PDT) +X-Originating-IP: [128.221.197.57] +In-Reply-To: <1334077496-9172-2-git-send-email-markwalters1009@gmail.com> +References: <1334077496-9172-1-git-send-email-markwalters1009@gmail.com> + <1334077496-9172-2-git-send-email-markwalters1009@gmail.com> +Date: Tue, 10 Apr 2012 11:19:07 -0600 +X-Google-Sender-Auth: miHml0up6etN5Qa3Wty8sH66Ur8 +Message-ID: + +Subject: Re: [PATCH 1/2] cli: make --entire-thread=false work for format=json. +From: Adam Wolfe Gordon +To: Mark Walters +Content-Type: text/plain; charset=ISO-8859-1 +Content-Transfer-Encoding: quoted-printable +X-Gm-Message-State: + ALoCoQmgf5OsmTko++xAXGX/AgSYPyMdsIMmBG3Sg0uXqX/tCqW47k0OQBO9Zy/0MOZXtV7qpWpi +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 10 Apr 2012 17:19:11 -0000 + +Hi Mark, + +This looks good to me, but I haven't tested it. It's probably worth +adding a test for the new functionality. + +One style issue below, which is a matter of taste and I'll defer to +others if they disagree: + +On Tue, Apr 10, 2012 at 11:04, Mark Walters wro= +te: +> @@ -895,10 +905,11 @@ show_messages (void *ctx, +> =A0 =A0 =A0 =A0 =A0 =A0if (status && !res) +> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0res =3D status; +> =A0 =A0 =A0 =A0 =A0 =A0next_indent =3D indent + 1; +> + =A0 =A0 =A0 } else +> + =A0 =A0 =A0 =A0 =A0 status =3D show_null_message (format); + +I accept, but don't particularly like, the notmuch style of omitting +braces where they aren't required. However, an else with a brace on +only one side just looks weird. If they're like this everywhere else +then I guess it's best to be consistent, but to me it's a lot more +readable as } else {. + +As I said above, I'll defer to others' judgement here, just thought it +was worth pointing out. + +-- Adam