From: Adam Wolfe Gordon Date: Wed, 22 Feb 2012 06:46:29 +0000 (+1700) Subject: [PATCH v6 00/10] Reply improvements X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=1017490e94592718e61ccaa90a7f5ffb9c76157f;p=notmuch-archives.git [PATCH v6 00/10] Reply improvements --- diff --git a/d6/0919f105df5980fbf69b42ffb114d257cb6e9f b/d6/0919f105df5980fbf69b42ffb114d257cb6e9f new file mode 100644 index 000000000..fbf679143 --- /dev/null +++ b/d6/0919f105df5980fbf69b42ffb114d257cb6e9f @@ -0,0 +1,103 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 07D30431FC0 + for ; Tue, 21 Feb 2012 22:46:51 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Zd-CZp6Km+JL for ; + Tue, 21 Feb 2012 22:46:50 -0800 (PST) +Received: from idcmail-mo2no.shaw.ca (idcmail-mo2no.shaw.ca [64.59.134.9]) + by olra.theworths.org (Postfix) with ESMTP id D813F431FCF + for ; Tue, 21 Feb 2012 22:46:46 -0800 (PST) +Received: from lb7f8hsrpno-svcs.dcs.int.inet (HELO pd5ml3no-ssvc.prod.shaw.ca) + ([10.0.144.222]) + by pd6mo1no-svcs.prod.shaw.ca with ESMTP; 21 Feb 2012 23:46:45 -0700 +X-Cloudmark-SP-Filtered: true +X-Cloudmark-SP-Result: v=1.1 cv=TH029eDfZHqIRue7hhxWRjZ7JL4S9vo/jJY5vkv2d5E= + c=1 sm=1 a=BLceEmwcHowA:10 a=yQp6g8lIsgqumF79BAsFDg==:17 + a=PskpEHOysnx7lAWaVvAA:9 + a=6KwGOC7SS7YnxZViWkwA:7 a=odvB31Xb1hMA:10 + a=HpAAvcLHHh0Zw7uRqdWCyQ==:117 +Received: from unknown (HELO lagos.xvx.ca) ([96.52.216.56]) + by pd5ml3no-dmz.prod.shaw.ca with ESMTP; 21 Feb 2012 23:46:45 -0700 +Received: by lagos.xvx.ca (Postfix, from userid 1000) + id 5DF5F8004C42; Tue, 21 Feb 2012 23:46:44 -0700 (MST) +From: Adam Wolfe Gordon +To: notmuch@notmuchmail.org +Subject: [PATCH v6 00/10] Reply improvements +Date: Tue, 21 Feb 2012 23:46:29 -0700 +Message-Id: <1329893199-21630-1-git-send-email-awg+notmuch@xvx.ca> +X-Mailer: git-send-email 1.7.5.4 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 22 Feb 2012 06:46:51 -0000 + +Hi all, + +This is an updated version of my previous series [1], primarily addressing +the concerns from Austin's review. The big changes are: + +* Documentation: add a TODO regarding reply to multiple messages and the + JSON reply format to schemata. + +* Emacs: using plists instead of alists in JSON parsing, and the resulting + adjustments to the code that consumes the parsed data. + +* Emacs: slightly nicer handling of multipart/alternative parts. In + particular, quote only the last part of desirable type instead of all the + parts of desirable type. + +* Split up the reply patch to make things a bit more clear. + +I noticed that the factoring out reply creation patch has been promoted to +"maybe ready" in nmbug. I think this version is unchanged, but since the +old one hasn't been pushed this one can probably replace it there. + +[1] id:"1329361957-28493-1-git-send-email-awg+notmuch@xvx.ca" + +Adam Wolfe Gordon (10): + test: Add broken test for the new JSON reply format. + reply: Factor out reply creation + reply: Require that only one message is returned + TODO: Add replying to multiple messages + reply: Add a JSON reply format. + schemata: Add documentation for JSON reply format. + man: Update notmuch-reply man page for JSON format. + emacs: Factor out useful functions into notmuch-lib + test: Add broken tests for new emacs reply functionality + emacs: Use the new JSON reply format and message-cite-original + + devel/TODO | 5 ++ + devel/schemata | 27 +++++++- + emacs/notmuch-lib.el | 44 ++++++++++++ + emacs/notmuch-mua.el | 132 +++++++++++++++++++++++++----------- + emacs/notmuch-show.el | 24 +------ + man/man1/notmuch-reply.1 | 5 ++ + notmuch-client.h | 10 ++- + notmuch-reply.c | 166 ++++++++++++++++++++++++++++++++-------------- + notmuch-show.c | 30 ++++++-- + test/emacs | 101 +++++++++++++++++++++++++++- + test/multipart | 51 ++++++++++++++ + 11 files changed, 468 insertions(+), 127 deletions(-) + +-- +1.7.5.4 +