From: Mark Walters Date: Fri, 10 Aug 2012 16:58:30 +0000 (+0100) Subject: Re: [PATCH v2] emacs: add function to toggle display of all multipart/alternative... X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=0e88214d2028eb3f5d2742c4d3c76aa5846a693f;p=notmuch-archives.git Re: [PATCH v2] emacs: add function to toggle display of all multipart/alternative parts --- diff --git a/f0/97d46012cbc15878c44b704fd40416972d2ffc b/f0/97d46012cbc15878c44b704fd40416972d2ffc new file mode 100644 index 000000000..0b6b8a98c --- /dev/null +++ b/f0/97d46012cbc15878c44b704fd40416972d2ffc @@ -0,0 +1,132 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1CD49431FBC + for ; Fri, 10 Aug 2012 09:58:53 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id WwqTcGoQosjv for ; + Fri, 10 Aug 2012 09:58:51 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 25BC2431FAE + for ; Fri, 10 Aug 2012 09:58:51 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1SzsXu-0003RN-0J; Fri, 10 Aug 2012 17:58:46 +0100 +Received: from 94.196.1.178.threembb.co.uk ([94.196.1.178] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1SzsXs-0003t1-36; Fri, 10 Aug 2012 17:58:45 +0100 +From: Mark Walters +To: Jani Nikula , + Jameson Graef Rollins +Subject: Re: [PATCH v2] emacs: add function to toggle display of all + multipart/alternative parts +In-Reply-To: + +References: <1339775751-18002-1-git-send-email-jani@nikula.org> + <87zk80gvmb.fsf@servo.finestructure.net> + <87pq8vokmp.fsf@qmul.ac.uk> + <87ipcrvlcw.fsf@servo.finestructure.net> + <87r4rf9q8x.fsf@qmul.ac.uk> <877gt67q93.fsf@nikula.org> + <87wr16u3dj.fsf@servo.finestructure.net> + +User-Agent: Notmuch/0.13.2+96~g634443c (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Fri, 10 Aug 2012 17:58:30 +0100 +Message-ID: <87d32yadl5.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.196.1.178 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: b447e5bbf7b2d707957f1b71744452d1 (of first 20000 bytes) +X-SpamAssassin-Score: -1.6 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.6 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.7 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +Cc: Notmuch Mail +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 10 Aug 2012 16:58:53 -0000 + + +On Fri, 10 Aug 2012, Jani Nikula wrote: +> On Aug 10, 2012 7:18 PM, "Jameson Graef Rollins" +> wrote: +>> +>> On Fri, Aug 10 2012, Jani Nikula wrote: +>> > How would this work together with something like [1] (rationale in [2])? +>> > +>> > [1] id:" +> ab777cf0fa83778d3399ac52094df9230738819d.1328798471.git.jani@nikula.org" +>> > [2] id:"cover.1328719309.git.jani@nikula.org" +>> > +>> > If you introduce a mechanism to store the state, could it be extended to +>> > store the state of each individual part? That, in turn, could be used to +>> > add support for expanding/collapsing each alternative part through the +>> > buttons (e.g. [ text/html (not shown) ]). Each button could toggle the +>> > state of the part, and refresh buffer. +>> +>> Hey, Jani. Are these patches needed if we have Mark's patch? I would +>> prefer to see Mark's solution. Since alternative parts are supposed to +>> be just that, alternative, it seems to me that a solution that would +>> cycle through display of these parts is really what we want. Is there a +>> strong need to show multiple alternative parts at the exact same time? +> +> Thanks to broken Microsoft mail clients, I get plenty of invitations that +> have text/plain and text/calendar alternative parts with information +> complimenting each other. I usually need to see both (luckily the included +> html part I can ignore) and it's helpful if I can see them at the same +> time. In a perfect world neither you or me would need any of this +> functionality... +> +> I suppose cycling through the alternative parts is, in a sense, correct for +> the reasons you state, we have the code here to do just that, and I can +> always cook up something for myself. Let's go with this, then, to move +> forward. + +Hi + +I am not sure I agree: I think maybe toggling parts is better. Either +the parts contain the same information and then the current behaviour is +probably fine, or they are not in which case we might want to see both +at once + +Best wishes + +Mark + +