From: Mark Walters Date: Mon, 5 Mar 2012 00:41:22 +0000 (+0000) Subject: Re: [PATCH] emacs: fix MML quoting in replies X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=0ca06fe3acf99bc71700dae8d8f5b61cfa0bb836;p=notmuch-archives.git Re: [PATCH] emacs: fix MML quoting in replies --- diff --git a/b0/1e97e1ac2179cf0fa0f04aced0e573c2139dc5 b/b0/1e97e1ac2179cf0fa0f04aced0e573c2139dc5 new file mode 100644 index 000000000..7e09d472c --- /dev/null +++ b/b0/1e97e1ac2179cf0fa0f04aced0e573c2139dc5 @@ -0,0 +1,101 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 7D31E431FAF + for ; Sun, 4 Mar 2012 16:39:33 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 6CQr2wuHl3pm for ; + Sun, 4 Mar 2012 16:39:33 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id E1843431FAE + for ; Sun, 4 Mar 2012 16:39:32 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1S4Lxb-00021l-2Q; Mon, 05 Mar 2012 00:39:31 +0000 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1S4Lxa-0002NZ-QE; Mon, 05 Mar 2012 00:39:30 +0000 +From: Mark Walters +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: fix MML quoting in replies +In-Reply-To: <1330849538-24558-1-git-send-email-jani@nikula.org> +References: <87fwdptbir.fsf@dehydrator.spatula.rdu.redhat.com> + <1330849538-24558-1-git-send-email-jani@nikula.org> +User-Agent: Notmuch/0.11.1+295~gfd64f6e (http://notmuchmail.org) Emacs/23.2.1 + (i486-pc-linux-gnu) +Date: Mon, 05 Mar 2012 00:41:22 +0000 +Message-ID: <877gyz6frh.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: ecd84b6a092eebfba0a91029473f3807 (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 05 Mar 2012 00:39:33 -0000 + +On Sun, 4 Mar 2012 10:25:38 +0200, Jani Nikula wrote: +> The reply MML quoting added in commit ae438cc unintentionally MML +> quotes also the signature/encryption MML tags added via +> message-setup-hook, causing the reply not to be signed/encrypted. +> +> MML quote just the original message in the temp buffer before +> inserting it to the message buffer, to not interfere with message mode +> hooks or message construction in general. +> +> See [1] and [2] for bug reports. +> +> Thanks to Tim Bielawa for testing. +> +> [1] id:"87hay78x6l.fsf@wyzanski.jamesvasile.com" +> [2] id:"1330812262-28272-1-git-send-email-tbielawa@redhat.com". + + +LGTM (but I am not really a lisper). I don't sign messages so haven't +tested it but it seems "correct" to only mml-quote the actual body +(i.e. the bit that comes from someone else). + +Best wishes + +Mark +