From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Wed, 1 Feb 2012 10:18:08 +0000 (+0200)
Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=08c4ea4cbd99b78e16b75448579602a8229f0136;p=notmuch-archives.git

Re: [PATCH] test: make test_expect_equal_file() arguments flexible
---

diff --git a/62/fe35f159290239f0f0a2b37b35261857ceb6c5 b/62/fe35f159290239f0f0a2b37b35261857ceb6c5
new file mode 100644
index 000000000..2d26fb628
--- /dev/null
+++ b/62/fe35f159290239f0f0a2b37b35261857ceb6c5
@@ -0,0 +1,71 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 8FC0C431E64
+	for <notmuch@notmuchmail.org>; Wed,  1 Feb 2012 02:18:07 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id 2mxWAW4CcL41 for <notmuch@notmuchmail.org>;
+	Wed,  1 Feb 2012 02:18:07 -0800 (PST)
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])
+	by olra.theworths.org (Postfix) with ESMTP id 06C03431FAF
+	for <notmuch@notmuchmail.org>; Wed,  1 Feb 2012 02:18:07 -0800 (PST)
+Received: by guru.guru-group.fi (Postfix, from userid 501)
+	id 6285F68055; Wed,  1 Feb 2012 12:18:08 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,
+	Jameson Graef Rollins <jrollins@finestructure.net>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible
+In-Reply-To: <87pqdync64.fsf@gmail.com>
+References: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com>
+	<87r4yfszx9.fsf@servo.finestructure.net> <87pqdync64.fsf@gmail.com>
+User-Agent: Notmuch/0.11+146~geb6dc33 (http://notmuchmail.org) Emacs/23.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Wed, 01 Feb 2012 12:18:08 +0200
+Message-ID: <m262fqc0wv.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain; charset=us-ascii
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Wed, 01 Feb 2012 10:18:07 -0000
+
+
+There are at least these options here
+
+1) go through all ~100 places where test_expect_equal_file is used
+   and fix the call order: quick look tells that the offending uses
+   are in dump-restore, hooks, search-limiting and symbol-hiding.
+
+2) enforce "expected" filename has some format *and* fix all current
+   uses of it. Add testbed_error () function which yells loudly ane exits...
+
+3) guess which is output and which is expected from args so that 
+   machine helps tester here (for both diff output & copied files)a
+
+4) just copy compared files to some directory, those are named as
+   basename of the original -- diff order still inconsistent.
+
+
+I'd just go with option 1 and fix new *violations* when stumble upon one.
+
+Tomi