From: David Bremner <david@tethera.net>
Date: Mon, 30 Apr 2012 11:39:32 +0000 (+2100)
Subject: Re: [PATCH 1/6] lib/cli: Make notmuch_database_open return a status code
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=08ac819720547bce8a76f8f08367a4010d5e68d8;p=notmuch-archives.git

Re: [PATCH 1/6] lib/cli: Make notmuch_database_open return a status code
---

diff --git a/f6/df97e1ab697f2f69ea8e313affa13c0f71e70f b/f6/df97e1ab697f2f69ea8e313affa13c0f71e70f
new file mode 100644
index 000000000..a0e49dc2c
--- /dev/null
+++ b/f6/df97e1ab697f2f69ea8e313affa13c0f71e70f
@@ -0,0 +1,79 @@
+Return-Path: <bremner@unb.ca>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 8AD15431FAF
+	for <notmuch@notmuchmail.org>; Mon, 30 Apr 2012 04:39:42 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id pu18RhfCQpkk for <notmuch@notmuchmail.org>;
+	Mon, 30 Apr 2012 04:39:41 -0700 (PDT)
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
+	(using TLSv1 with cipher AES256-SHA (256/256 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id D351B431FAE
+	for <notmuch@notmuchmail.org>; Mon, 30 Apr 2012 04:39:41 -0700 (PDT)
+Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net
+	([156.34.89.108] helo=zancas.localnet)
+	by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32)
+	(Exim 4.72) (envelope-from <bremner@unb.ca>)
+	id 1SOox8-0004bH-1b; Mon, 30 Apr 2012 08:39:38 -0300
+Received: from bremner by zancas.localnet with local (Exim 4.77)
+	(envelope-from <bremner@unb.ca>)
+	id 1SOox2-0004VF-Jy; Mon, 30 Apr 2012 08:39:32 -0300
+From: David Bremner <david@tethera.net>
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 1/6] lib/cli: Make notmuch_database_open return a status
+	code
+In-Reply-To: <1335651473-19652-2-git-send-email-amdragon@mit.edu>
+References: <1335651473-19652-1-git-send-email-amdragon@mit.edu>
+	<1335651473-19652-2-git-send-email-amdragon@mit.edu>
+User-Agent: Notmuch/0.12+152~g904a807 (http://notmuchmail.org) Emacs/23.4.1
+	(x86_64-pc-linux-gnu)
+Date: Mon, 30 Apr 2012 08:39:32 -0300
+Message-ID: <87pqapphxn.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain; charset=us-ascii
+X-Spam_bar: -
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Mon, 30 Apr 2012 11:39:42 -0000
+
+
+I have two questions, both of which might have been settled previously.
+
+>  
+> -    return notmuch;
+> +    *database = notmuch;
+> +    return status;
+>  }
+
+Should we check database is non-NULL here?
+
+> diff --git a/notmuch-count.c b/notmuch-count.c
+> index 9c2ad7b..2f98128 100644
+> --- a/notmuch-count.c
+> +++ b/notmuch-count.c
+
+> +    if (notmuch_database_open (notmuch_config_get_database_path (config),
+> +			       NOTMUCH_DATABASE_MODE_READ_ONLY, &notmuch))
+
+Is it OK to rely on NOTMUCH_STATUS_SUCCESS==0 ?
+
+d