From: Adam Wolfe Gordon Date: Sat, 4 Feb 2012 06:01:23 +0000 (+1700) Subject: Re: [PATCH 0/2] Bug and potential fix: forwarded messages X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=0853a88139f96141ac86ce59e052d5530fbac898;p=notmuch-archives.git Re: [PATCH 0/2] Bug and potential fix: forwarded messages --- diff --git a/7d/08ec87544209a8bcf0d61c3010629c7371227d b/7d/08ec87544209a8bcf0d61c3010629c7371227d new file mode 100644 index 000000000..514c09d1f --- /dev/null +++ b/7d/08ec87544209a8bcf0d61c3010629c7371227d @@ -0,0 +1,121 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 39040431FAF + for ; Fri, 3 Feb 2012 22:01:26 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id umdDb1bX5NVx for ; + Fri, 3 Feb 2012 22:01:25 -0800 (PST) +Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com + [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 5AEA1431FAE + for ; Fri, 3 Feb 2012 22:01:25 -0800 (PST) +Received: by bke11 with SMTP id 11so4092952bke.26 + for ; Fri, 03 Feb 2012 22:01:24 -0800 (PST) +MIME-Version: 1.0 +Received: by 10.204.145.82 with SMTP id c18mr4612994bkv.121.1328335283831; + Fri, 03 Feb 2012 22:01:23 -0800 (PST) +Sender: awg@xvx.ca +Received: by 10.204.104.13 with HTTP; Fri, 3 Feb 2012 22:01:23 -0800 (PST) +X-Originating-IP: [96.52.216.56] +In-Reply-To: <1328315554-16085-1-git-send-email-awg+notmuch@xvx.ca> +References: <1328315554-16085-1-git-send-email-awg+notmuch@xvx.ca> +Date: Fri, 3 Feb 2012 23:01:23 -0700 +X-Google-Sender-Auth: -g25LXHdD1HAOOLNHurAMVf0BhM +Message-ID: + +Subject: Re: [PATCH 0/2] Bug and potential fix: forwarded messages +From: Adam Wolfe Gordon +To: notmuch@notmuchmail.org +Content-Type: text/plain; charset=ISO-8859-1 +Content-Transfer-Encoding: quoted-printable +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 04 Feb 2012 06:01:26 -0000 + +Oh, and I just noticed that Dmitry has already fixed this, probably in +a better way [1] (though I maintain that there still may be a problem +with the approach in general). I clearly haven't been following the +list closely enough this week. + +[1] id:"1327926286-16680-1-git-send-email-dmitry.kurochkin@gmail.com" + +On Fri, Feb 3, 2012 at 17:32, Adam Wolfe Gordon wrote: +> Hi everyone, +> +> I encountered today a bug that I remember being mentioned on IRC where +> some messages are shown in emacs as completely empty, even though their +> content is present and simple. For me, the bug shows up with messages tha= +t +> have been forwarded by an Outlook user who didn't add any content to the = +top +> of the message. The first line of the message is "-----Original Message--= +---", +> and the rest is the forwarded text. Notmuch tries to collapse the forward= +ed +> content into a button, but fails mysteriously. +> +> The first patch in this series adds a test (marked as broken) that demons= +trates +> the bug. I think this should be pushed regardless of whether my solution = +is +> the right one. My solution is to check whether we're collapsing the entir= +e +> message before doing so, and avoid turning it into a button if that's the= + case. +> I think this is a desirable behavior, since if someone has forwarded a me= +ssage +> without adding anything the user probably wants to read that message. But= +, +> I'll admit that I didn't figure out the real cause of the problem, and I +> would be happy to hear other suggestions. +> +> It also occurs to me that this might indicate a bigger problem with how +> notmuch-wash.el handles messages starting with "-----Original Message----= +-". +> Notmuch seems to assume that this indicates the rest of the message is qu= +oted +> stuff that's been top-posted on. In my office this isn't necessarily the = +case, +> since Outlook produces that line at the top of every reply, and it's up t= +o +> the user whether to top-post or not (and not everyone does). +> +> I'll have to experiment a bit more to verify whether a problem (i.e. whet= +her +> Notmuch hides inappropriate things when someone replies inline with Outlo= +ok). +> Someone please correct me if I'm missing something in how the code operat= +es. +> +> Adam Wolfe Gordon (2): +> =A0test: Add broken test for showing forwarded messages +> =A0emacs: Fix broken showing of forwarded messages. +> +> =A0emacs/notmuch-wash.el | =A0 =A05 +++-- +> =A0test/emacs =A0 =A0 =A0 =A0 =A0 =A0| =A0 32 +++++++++++++++++++++++++++= ++++++ +> =A02 files changed, 35 insertions(+), 2 deletions(-) +> +> -- +> 1.7.5.4 +>