From: Dmitry Kurochkin Date: Wed, 1 Feb 2012 14:18:55 +0000 (+0400) Subject: Re: emacs: quote MML tags in replies X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=065d1958dd844da2891444dd63e86f0d41ddc4de;p=notmuch-archives.git Re: emacs: quote MML tags in replies --- diff --git a/d1/f2fd3cdb264f379434b22d4a649ee0f9d96003 b/d1/f2fd3cdb264f379434b22d4a649ee0f9d96003 new file mode 100644 index 000000000..fdf94a655 --- /dev/null +++ b/d1/f2fd3cdb264f379434b22d4a649ee0f9d96003 @@ -0,0 +1,136 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id F132D429E5B + for ; Wed, 1 Feb 2012 06:20:11 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id eBue4EPYi6hg for ; + Wed, 1 Feb 2012 06:20:11 -0800 (PST) +Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com + [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 30EC4431E64 + for ; Wed, 1 Feb 2012 06:20:11 -0800 (PST) +Received: by bke11 with SMTP id 11so1207256bke.26 + for ; Wed, 01 Feb 2012 06:20:09 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type; + bh=o4sCw8BMqETJfFey8loJk4XilN3ARIxOx1kpv6KKwG4=; + b=rhT/OFJzUTdSe10iXXPFo3Q8fPs7DGoLYzaLgjLazef07eYJT5+7/FIZnMum7INjvZ + RXZN5qOVRdSNbAYzfWmKhfg3wEOKfEF+RYARcZe+wcqBRToG8T9vQ+2zolcKm7lBPo++ + q+evIN2O4hNvr5gsNa7iPJREtIUNvB2PbTJrY= +Received: by 10.204.128.79 with SMTP id j15mr12567790bks.75.1328106009594; + Wed, 01 Feb 2012 06:20:09 -0800 (PST) +Received: from localhost ([91.144.186.21]) + by mx.google.com with ESMTPS id z15sm52122876bkd.7.2012.02.01.06.20.08 + (version=TLSv1/SSLv3 cipher=OTHER); + Wed, 01 Feb 2012 06:20:08 -0800 (PST) +From: Dmitry Kurochkin +To: Pieter Praet , notmuch@notmuchmail.org +Subject: Re: emacs: quote MML tags in replies +In-Reply-To: <87vcnq64ra.fsf@praet.org> +References: <1326998589-37187-1-git-send-email-aaronecay@gmail.com> + <1328064581-13949-1-git-send-email-dmitry.kurochkin@gmail.com> + <87vcnq64ra.fsf@praet.org> +User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Wed, 01 Feb 2012 18:18:55 +0400 +Message-ID: <87d39ymyb4.fsf@gmail.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 01 Feb 2012 14:20:12 -0000 + +On Wed, 01 Feb 2012 14:51:37 +0100, Pieter Praet wrote: +> On Wed, 1 Feb 2012 06:49:39 +0400, Dmitry Kurochkin wrote: +> > Hi Aaron. +> > +> > Thanks for your work! I took the liberty to do some cleanups for your +> > patch. Below is a detailed list of changes. +> > +> +> Thanks to the both of you! +> +> +> > Hope this helps. +> > +> > Changes since v2: +> > +> > * change patch names to be consistent with others: +> > +> > - s/emacs:/test:/ for the test patch +> > +> > - lower case the first word after colon in the patch title +> > +> > * polish NEWS wording, move it to 0.12 section +> > +> > * add comment to `mml-quote-region' call, as suggested by Tomi [1] +> > +> > * fix and clean up the test: +> > +> > - set `notmuch-fcc-dirs' to nil to avoid adding the Fcc header, +> > otherwise it breaks the test on other systems as pointed by +> > David [2] +> > +> +> Could also have been avoided by adding the expected result inline, +> and using "Fcc: $(pwd)/mail/sent". I'll send an updated patch to +> that effect. +> + +I do not understand how this is better. But please do not use $(pwd) +here. I know that other tests do that in the same case, but it is +wrong. There is $MAIL_DIR variable for this. See "notmuch-fcc-dirs set +to a string" test for an example. + +Regards, + Dmitry + +> +> > - use default values for add_message parameters where possible +> > +> > - use a sane subject value in add_message +> > +> > - use shorter MML tag as produced by (mml-insert-part) +> > +> > - indenting and other minor cleanups +> > +> > Regards, +> > Dmitry +> > +> > [1] id:"m2wr89ioos.fsf@guru.guru-group.fi" +> > [2] id:"87ehugzycb.fsf@zancas.localnet" +> > +> > _______________________________________________ +> > notmuch mailing list +> > notmuch@notmuchmail.org +> > http://notmuchmail.org/mailman/listinfo/notmuch +> +> Despite my comment re Fcc, both LGTM. +> +> +> Peace +> +> -- +> Pieter