From: Blake Jones <blakej@foo.net>
Date: Mon, 5 Nov 2012 04:52:59 +0000 (+1600)
Subject: Re: [PATCH 08/10] notmuch-config: header for index() prototype (Solaris support)
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=02071043e03b204ac1f62fe2ffebef465909f947;p=notmuch-archives.git

Re: [PATCH 08/10] notmuch-config: header for index() prototype (Solaris support)
---

diff --git a/67/cf4850bec36b5a5deba864d61b6c865acecfc3 b/67/cf4850bec36b5a5deba864d61b6c865acecfc3
new file mode 100644
index 000000000..520d8dcbe
--- /dev/null
+++ b/67/cf4850bec36b5a5deba864d61b6c865acecfc3
@@ -0,0 +1,65 @@
+Return-Path: <blakej@foo.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id B911C431FAF
+	for <notmuch@notmuchmail.org>; Sun,  4 Nov 2012 20:53:07 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id rpZvVxgz907H for <notmuch@notmuchmail.org>;
+	Sun,  4 Nov 2012 20:53:07 -0800 (PST)
+Received: from foo.net (70-36-235-136.dsl.static.sonic.net [70.36.235.136])
+	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 31100431FAE
+	for <notmuch@notmuchmail.org>; Sun,  4 Nov 2012 20:53:07 -0800 (PST)
+Received: from foo.net (localhost [127.0.0.1])
+	by foo.net (8.14.5+Sun/8.14.5) with ESMTP id qA54qxmv004983;
+	Sun, 4 Nov 2012 20:52:59 -0800 (PST)
+To: Tomi Ollila <tomi.ollila@iki.fi>
+Subject: Re: [PATCH 08/10] notmuch-config: header for index() prototype
+	(Solaris support) 
+In-Reply-To: Your message of "Sun, 04 Nov 2012 23:47:15 +0200."
+	<m2pq3tniqk.fsf@guru.guru-group.fi> 
+Date: Sun, 04 Nov 2012 20:52:59 -0800
+Message-ID: <4982.1352091179@foo.net>
+From: Blake Jones <blakej@foo.net>
+X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.2
+	(foo.net [127.0.0.1]); Sun, 04 Nov 2012 20:52:59 -0800 (PST)
+Cc: notmuch@notmuchmail.org
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Mon, 05 Nov 2012 04:53:07 -0000
+
+>> On Sun, 04 Nov 2012, Blake Jones <blakej@foo.net> wrote:
+>>> Linux, FreeBSD, and Solaris all expect to find the prototype for
+>>> "index()" in <strings.h>.  On some operating systems, including
+>>> <string.h> is sufficient to get the prototype, but that's not the case
+>>> on Solaris.  This patch just modifies notmuch-config.c to include
+>>> <strings.h> to get the prototype.
+>>
+>> We should probably just nuke index() and use strchr() instead.
+> 
+> indeed!
+
+That was my initial preference, but I didn't know if there was anyone
+who was committed to the BSD name.  Given that two more people think
+it's a good idea, I'll do that instead.
+
+Blake