From: Ian Abbott <abbotti@mev.co.uk>
Date: Thu, 19 Nov 2009 11:21:51 +0000 (+0000)
Subject: pcl816: In pcl816_ai_cmdtest(), correct step 1 test for valid convert_src
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=01a81c7ae8e7f6a28b329c6680c0b6a25650d81e;p=comedi.git

pcl816: In pcl816_ai_cmdtest(), correct step 1 test for valid convert_src
(operator precedence error).
---

diff --git a/comedi/drivers/pcl816.c b/comedi/drivers/pcl816.c
index 3d1b1bd0..bd62f653 100644
--- a/comedi/drivers/pcl816.c
+++ b/comedi/drivers/pcl816.c
@@ -478,7 +478,9 @@ static int pcl816_ai_cmdtest(comedi_device * dev, comedi_subdevice * s,
 	if (!cmd->scan_begin_src || tmp != cmd->scan_begin_src)
 		err++;
 
-	if (!cmd->convert_src & (TRIG_EXT | TRIG_TIMER))
+	tmp = cmd->convert_src;
+	cmd->convert_src &= TRIG_EXT | TRIG_TIMER;
+	if (!cmd->convert_src || tmp != cmd->convert_src)
 		err++;
 
 	tmp = cmd->scan_end_src;