From: Mark Walters Date: Sun, 29 Jan 2012 10:37:01 +0000 (+0000) Subject: Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=017fca4352a504d8db36ccccea794140758cc6f6;p=notmuch-archives.git Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag --- diff --git a/26/ebbf972ed96073674b281ba1fbea554dc5aefe b/26/ebbf972ed96073674b281ba1fbea554dc5aefe new file mode 100644 index 000000000..2d18ca57f --- /dev/null +++ b/26/ebbf972ed96073674b281ba1fbea554dc5aefe @@ -0,0 +1,121 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1C70C431FBC + for ; Sun, 29 Jan 2012 02:36:08 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id A0ENz-UQiNTp for ; + Sun, 29 Jan 2012 02:36:07 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 7DCFC431FB6 + for ; Sun, 29 Jan 2012 02:36:07 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1RrS78-0007W4-Hy; Sun, 29 Jan 2012 10:36:02 +0000 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1RrS78-000695-9f; Sun, 29 Jan 2012 10:36:02 +0000 +From: Mark Walters +To: Austin Clements +Subject: Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag +In-Reply-To: <8739azqt2j.fsf@qmul.ac.uk> +References: <20120124011609.GX16740@mit.edu> + <1327367923-18228-2-git-send-email-markwalters1009@gmail.com> + <20120124024521.GY16740@mit.edu> <874nvg6qxn.fsf@qmul.ac.uk> + <20120128183340.GD17991@mit.edu> <8739azqt2j.fsf@qmul.ac.uk> +User-Agent: Notmuch/0.11+136~g22c824b (http://notmuchmail.org) Emacs/23.2.1 + (i486-pc-linux-gnu) +Date: Sun, 29 Jan 2012 10:37:01 +0000 +Message-ID: <87zkd6pzg2.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 153a6598f56c2545faa9372c32cd8a58 (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 29 Jan 2012 10:36:08 -0000 + + +> The cli stuff needs thought (about what it should do rather than +> how to do it). + +Ok I have thought about the cli interface. My thoughts are as follows: + +count/search/show should all have a --do-not-exclude option. + +notmuch count: + + messages: just output count of matching not-excluded + + threads: count threads matching in a non-excluded message + +notmuch search: + + default/summary should output line as in the current patch with + number matching being number non-excluded matching (so some will + be zero) + + messages/files/tags should be matching not-excluded + + threads: show thread ids of messages matching in a non-excluded message + +notmuch show: + + raw and part both deal with a single message so should output it + regardless of exclude flags. + + text/json can give out the results including the exclude flag + + mbox only include matching not-excluded + +The rationale is that all formats which can return an exclude flag do; +those that cannot omit the excluded results since the caller can just +call without setting the excludes if they want the full results. + +Does that seem reasonable? + +Best wishes + +Mark