From: Austin Clements Date: Sun, 13 May 2012 23:15:12 +0000 (+2000) Subject: Re: [PATCH 2/5] go: Update for changes to notmuch_database_get_directory X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=012e3efc2920ddffa76b6bba97c5962108ae0d97;p=notmuch-archives.git Re: [PATCH 2/5] go: Update for changes to notmuch_database_get_directory --- diff --git a/e9/65c83734dc711e3dd7ea6bf4ea0e559837e961 b/e9/65c83734dc711e3dd7ea6bf4ea0e559837e961 new file mode 100644 index 000000000..ff1d8cef0 --- /dev/null +++ b/e9/65c83734dc711e3dd7ea6bf4ea0e559837e961 @@ -0,0 +1,108 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 03E2C431FB6 + for ; Sun, 13 May 2012 16:15:18 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id aldJS7O-BgTW for ; + Sun, 13 May 2012 16:15:17 -0700 (PDT) +Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU + [18.7.68.35]) + by olra.theworths.org (Postfix) with ESMTP id 74FF2431FAE + for ; Sun, 13 May 2012 16:15:17 -0700 (PDT) +X-AuditID: 12074423-b7fcc6d0000008a8-ba-4fb04084be8f +Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) + by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP + id 11.A8.02216.48040BF4; Sun, 13 May 2012 19:15:16 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q4DNFFd9024220; + Sun, 13 May 2012 19:15:15 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q4DNFDdr028317 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Sun, 13 May 2012 19:15:13 -0400 (EDT) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1STi0O-0005Va-UH; Sun, 13 May 2012 19:15:12 -0400 +Date: Sun, 13 May 2012 19:15:12 -0400 +From: Austin Clements +To: Justus Winter <4winter@informatik.uni-hamburg.de> +Subject: Re: [PATCH 2/5] go: Update for changes to + notmuch_database_get_directory +Message-ID: <20120513231512.GN11804@mit.edu> +References: <1336939029-13969-1-git-send-email-amdragon@mit.edu> + <1336939029-13969-3-git-send-email-amdragon@mit.edu> + <20120513215135.15106.40581@thinkbox.jade-hamburg.de> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <20120513215135.15106.40581@thinkbox.jade-hamburg.de> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFprHKsWRmVeSWpSXmKPExsUixCmqrNvisMHf4PFmG4vZrT+YLG60djNa + NE13trh+cyazxZuV81gdWD0Of13I4jHx/Gk2j1v3X7N7PFt1i9ljy6H3zAGsUVw2Kak5mWWp + Rfp2CVwZM+ZtYC44yF7xbhlrA2MDWxcjJ4eEgInEnyVHmSBsMYkL99YDxbk4hAT2MUrsaZ3A + BOFsYJRo7F3IDOGcZJL4PXEmlLOEUaJ5wWNWkH4WAVWJ90c2gs1lE9CQ2LZ/OSOILSJgKrHh + wQN2EJtZIEZizdqbQGM5OIQFgiW2XnYDMXkFdCQWrpUFqRASWM8osWyzLojNKyAocXLmExaI + Ti2JG/9egnUyC0hLLP/HARLmFHCSOP5iHtgBogIqElNObmObwCg0C0n3LCTdsxC6FzAyr2KU + Tcmt0s1NzMwpTk3WLU5OzMtLLdI108vNLNFLTSndxAiKBnYX5R2Mfw4qHWIU4GBU4uF9abrB + X4g1say4MvcQoyQHk5Io7047oBBfUn5KZUZicUZ8UWlOavEhRgkOZiUR3vUP1/sL8aYkVlal + FuXDpKQ5WJTEeTW03vkJCaQnlqRmp6YWpBbBZGU4OJQkeLfaAw0VLEpNT61Iy8wpQUgzcXCC + DOcBGq4DUsNbXJCYW5yZDpE/xagoJc67GiQhAJLIKM2D64Ulq1eM4kCvCPP2gVTxABMdXPcr + oMFMQIP5BdaBDC5JREhJNTDGhJ/3LG0Rt9GVXpvyy3rn6wsSG96buxqGffBf4Dtvm4e64fUP + uZ6sQlv1d6+O2JN5TpztfPSqFm6Z9E2/apidTDhm7vdsiwnYv0NOruCm0VnGaJc0mbX7Fq1e + EOT34sj7vmhL8TWGzxeu6LWdIF6UcPC0+OmFkdLVB9zTZasaC4RvLxXymanEUpyRaKjFXFSc + CADVecN0MQMAAA== +Cc: tomi.ollila@iki.fi, notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 13 May 2012 23:15:18 -0000 + +Quoth Justus Winter on May 13 at 11:51 pm: +> Hi Austin, +> +> thanks for taking care of this. +> +> Quoting Austin Clements (2012-05-13 21:57:06) +> > --- +> > bindings/go/src/notmuch/notmuch.go | 13 +++++++------ +> > bindings/python/notmuch/database.py | 4 ++-- +> +> A change to the python bindings slipped into this one. + +Sure enough. I'll send a v2 that moves that hunk to the python patch. + +> Other than that this looks good. +> +> I just saw that I marked another function as problematic, +> notmuch_database_find_message_by_filename ends up calling +> _notmuch_directory_create that aborts if the database is not +> writable. But this might have to wait and might not even requira an +> api change. + +Right. notmuch_database_find_message_by_filename already has a status +return, so its API is fine. (Actually, I was starting to fix its +implementation when I realized notmuch_database_get_directory was +problematic.) + +> Justus