Re: [PATCH 2/5] util: Function to parse boolean term queries

diff --git a/a9/1cfdede9b8d338df2459891508385405d24cbf b/a9/1cfdede9b8d338df2459891508385405d24cbf
new file mode 100644 (file)
index 0000000..2e1c31d
--- /dev/null
+++ b/a9/1cfdede9b8d338df2459891508385405d24cbf
@@ -0,0 +1,91 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 147FC431FB6\r
+       for <notmuch@notmuchmail.org>; Tue, 25 Dec 2012 06:18:55 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 09aiYtFh9S1e for <notmuch@notmuchmail.org>;\r
+       Tue, 25 Dec 2012 06:18:54 -0800 (PST)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 9299D431FAE\r
+       for <notmuch@notmuchmail.org>; Tue, 25 Dec 2012 06:18:54 -0800 (PST)\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1TnVLG-0001UQ-Hv; Tue, 25 Dec 2012 10:18:50 -0400\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1TnVL8-00067A-NO; Tue, 25 Dec 2012 10:18:42 -0400\r
+From: David Bremner <david@tethera.net>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/5] util: Function to parse boolean term queries\r
+In-Reply-To: <1356415076-5692-3-git-send-email-amdragon@mit.edu>\r
+References: <1356415076-5692-1-git-send-email-amdragon@mit.edu>\r
+       <1356415076-5692-3-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.14+213~g4af1ac6 (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 25 Dec 2012 10:18:42 -0400\r
+Message-ID: <87obhidxkt.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 25 Dec 2012 14:18:55 -0000\r
+\r
+Austin Clements <amdragon@MIT.EDU> writes:\r
+\r
+> +    if (consume_double_quote (&pos)) {\r
+> +    char *out = talloc_strdup (ctx, pos);\r
+> +    pos = *term_out = out;\r
+> +    while (1) {\r
+\r
+Overall the control flow here is a bit tricky to follow. I'm not sure if\r
+a real loop condition would help or make it worse.\r
+\r
+> +        if (! *pos) {\r
+> +            /* Premature end of string */\r
+> +            goto FAIL;\r
+> +        } else if (*pos == '"') {\r
+> +            if (*++pos != '"')\r
+> +                break;\r
+> +        } else if (consume_double_quote (&pos)) {\r
+> +            break;\r
+> +        }\r
+\r
+I'm confused by the asymmetry here. Quoted strings can start with\r
+unicode quotes, but internally can only have ascii '"'? Is this\r
+documented somewhere?\r
+\r
+> +    } else {\r
+> +    while (*pos > ' ' && *pos != ')')\r
+> +        ++pos;\r
+> +    if (*pos)\r
+> +        goto FAIL;\r
+> +    }\r
+\r
+So if there is no quote, we skip the part after the ':'? I guess I\r
+probably missed something because that doesn't sound like the intended\r
+behaviour.\r