Re: [PATCH] mime_node_open: check if the file is in mbox format, and inform gmime.

diff --git a/83/1b4b972c662fe0c50eb1b8166dc09edbb09dc9 b/83/1b4b972c662fe0c50eb1b8166dc09edbb09dc9
new file mode 100644 (file)
index 0000000..ce01009
--- /dev/null
+++ b/83/1b4b972c662fe0c50eb1b8166dc09edbb09dc9
@@ -0,0 +1,109 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5F338431FB6\r
+       for <notmuch@notmuchmail.org>; Thu,  8 Mar 2012 14:05:47 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 28Ly3CMmM71D for <notmuch@notmuchmail.org>;\r
+       Thu,  8 Mar 2012 14:05:46 -0800 (PST)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id C90CC431FAE\r
+       for <notmuch@notmuchmail.org>; Thu,  8 Mar 2012 14:05:46 -0800 (PST)\r
+Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by fire-doxen-postvirus (Postfix) with ESMTP id 564413280B3;\r
+       Thu,  8 Mar 2012 14:05:46 -0800 (PST)\r
+X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new\r
+Received: from finestructure.net (DHCP-123-180.caltech.edu [131.215.123.180])\r
+       (Authenticated sender: jrollins)\r
+       by fire-doxen-submit (Postfix) with ESMTP id 9540B2E50D70;\r
+       Thu,  8 Mar 2012 14:05:42 -0800 (PST)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id 7634E9DE; Thu,  8 Mar 2012 14:05:42 -0800 (PST)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] mime_node_open: check if the file is in mbox format,\r
+       and inform gmime.\r
+In-Reply-To: <1331243295-27324-1-git-send-email-david@tethera.net>\r
+References: <87vcme3kf6.fsf@pip.fifthhorseman.net>\r
+       <1331243295-27324-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.11.1+266~gadb05cc (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 08 Mar 2012 14:05:40 -0800\r
+Message-ID: <87sjhiaguj.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+Cc: David Bremner <bremner@debian.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 08 Mar 2012 22:05:47 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Thu,  8 Mar 2012 17:48:15 -0400, David Bremner <david@tethera.net> wrote:\r
+> From: David Bremner <bremner@debian.org>\r
+>=20\r
+> It seems that it has always been an error to try to parse an mbox\r
+> format file with gmime without calling g_mime_parser_set_scan_from.\r
+>=20\r
+> This change reads the first 5 bytes of the file, and if they are "From ",\r
+> declares the file to be an mbox.\r
+> ---\r
+>=20\r
+> This patch seems to fix the problem for me. I don't think the\r
+> performance impact should be too bad, but I didn't really test it.\r
+\r
+As I've stated previously in this thread, I think this behavior is a\r
+mistake.  This will not result in a proper parsing of an mbox file, and\r
+improper or incomplete parsing of mbox files will lead to bad/confusing\r
+behavior.\r
+\r
+We should either completely support mbox files or not support them.\r
+Partial support is, imho, a recipe for disaster.  We don't currently\r
+support them, and it would take a lot of extra work to do so completely.\r
+I don't see any harm in just telling users to convert their mbox files\r
+into proper message files.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJPWS00AAoJEO00zqvie6q8RXQQALFfsAfosiC6gJkJ1ttN9dPw\r
+jGFi7pMPx8iKKBv2L4qvMnsKUc7hyODG7aVvRSKtYkmHN6hvpVqZQkKeaJrg6QL2\r
+Nv+2MPhcD8UF4wTmU9gK3NEppmELgJJk4Uu0CkFkpSWUu9c3pfZFoJpOBncIp7Ka\r
+skBQd3qr+FayH+cXHfAYekO+nqtFkd6RhOyU4cQSX6FH74a+4/DbV3A5WS5F5Zq/\r
+USdS8L5TKs+TD9zp4w8reHmRDLxiEjNe91lOrPyxQ+3E4KIqEZP6Tr2VMP5coKW0\r
+ZJUIAgRgAr+LAtBC/d4LRh5IkIM/dpLGWPDmyWI8NEOpuBcjIhHDZLcOgjwnQfVY\r
+uV/wq+T4XsyHhNJYEbVF6DSsaKK1m07NFpSPkUu15sB3zwgQ4pYmVIQ7pG9gVL1f\r
+2urmepAn6q+hNwK+/qUExCwcwowVuxRvWUoghzzOhfmyBOTnmruNqnSgkAu7cTtT\r
+3ruq+XkP0UyorA6rrQFbT107eWF/B1hHT0IYQti+3/cWuN9IvSOMdrl2/SiUXtDM\r
+FQcKuNJiUC8PNHIVRDZrA/9e2AJ25u9I6ixr+FO/K/oN/l82A/zrUk8MuUIe72hQ\r
+1stVgmLiTsc7Xd9uS5eGKzgiljrTmCx1QVos47kK/u6oWJDgBgWLZOcy+Z7BP3lA\r
+p6gSjFECXiw0Vo5d+cmm\r
+=Nu1y\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r