Re: [PATCH 4/6] cli: intialize crypto structure in show and reply

diff --git a/2d/ea15ce5771f765cc6f41ce590826c921608c8d b/2d/ea15ce5771f765cc6f41ce590826c921608c8d
new file mode 100644 (file)
index 0000000..c289055
--- /dev/null
+++ b/2d/ea15ce5771f765cc6f41ce590826c921608c8d
@@ -0,0 +1,114 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A080A431FAF\r
+       for <notmuch@notmuchmail.org>; Thu, 17 May 2012 09:45:17 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id GchX7x2KvnRx for <notmuch@notmuchmail.org>;\r
+       Thu, 17 May 2012 09:45:15 -0700 (PDT)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id C0B73431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 17 May 2012 09:45:15 -0700 (PDT)\r
+Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by earth-doxen-postvirus (Postfix) with ESMTP id A411B66E01D3;\r
+       Thu, 17 May 2012 09:45:08 -0700 (PDT)\r
+X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new\r
+Received: from finestructure.net (rrcs-24-103-26-131.nyc.biz.rr.com\r
+       [24.103.26.131]) (Authenticated sender: jrollins)\r
+       by earth-doxen-submit (Postfix) with ESMTP id 927D866E018C;\r
+       Thu, 17 May 2012 09:45:05 -0700 (PDT)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id B1120340; Thu, 17 May 2012 09:45:03 -0700 (PDT)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Jani Nikula <jani@nikula.org>\r
+Subject: Re: [PATCH 4/6] cli: intialize crypto structure in show and reply\r
+In-Reply-To:\r
+ <CAB+hUn9DdeaFj-hUNb_c1V3QLsbWjsE7_hpuOpDqWseayASdKQ@mail.gmail.com>\r
+References: <1337205359-2444-1-git-send-email-jrollins@finestructure.net>\r
+       <1337205359-2444-2-git-send-email-jrollins@finestructure.net>\r
+       <1337205359-2444-3-git-send-email-jrollins@finestructure.net>\r
+       <1337205359-2444-4-git-send-email-jrollins@finestructure.net>\r
+       <1337205359-2444-5-git-send-email-jrollins@finestructure.net>\r
+       <8762bvi70k.fsf@nikula.org>\r
+       <877gwaeve1.fsf@servo.finestructure.net>\r
+       <CAB+hUn9DdeaFj-hUNb_c1V3QLsbWjsE7_hpuOpDqWseayASdKQ@mail.gmail.com>\r
+User-Agent: Notmuch/0.12+183~g9d5ff3c (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 17 May 2012 09:45:01 -0700\r
+Message-ID: <87aa16daeq.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 17 May 2012 16:45:17 -0000\r
+\r
+--=-=-=\r
+\r
+On Thu, May 17 2012, Jani Nikula <jani@nikula.org> wrote:\r
+> The values are not undefined, they are properly initialized, and we can\r
+> count on it. For sure, not maybe. If you want to explicitly set them for\r
+> clarity, it's a matter of taste. Personally I find it too verbose, but then\r
+> again notmuch code is generally fairly verbose.\r
+\r
+I want them explicitly set for clarity, as well as safety.  Code is\r
+meant to be read by humans, not computers.  Brevity is not always a\r
+virtue if it sacrifices clarity.  It's much nicer to have the defaults\r
+clearly stated in the initialization, than to force the reader to\r
+understand how the initialization works and to interpret what that means\r
+for the current case.  I also don't think it's safe to assume that the\r
+variables will be always be "properly" initialized in your favor in\r
+perpetuity.  It's much safer to explicitly set them to what you want\r
+them to be rather than just assume they'll be set correctly.\r
+\r
+> If you insist on it, please at least drop the extra temp crypto\r
+> variable, and initialize the struct in one initializer.\r
+\r
+I don't see why this matters either.  Again, I think this is just a\r
+matter of taste.  I would rather the code be verbose where clarity\r
+requires it, rather than always trying to make the code as terse as\r
+possible.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.12 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJPtSsNAAoJEO00zqvie6q8EUAQAJnXcl3gyfVqUNY0c6BCOn1f\r
+EIk+M5rz0gXAhJLo/k2yUuk4SuGiF0K20ZeUyy9Vf59y5LnazJsgsirzM4LqdZ0B\r
+UxlBmlNz7K7MbIB3X3qOAc/PA2V2zRbSNMuO7yhr8l2Q7/E82tEL+2cIBNpplWVM\r
+zAXPp2UI+j7fgHuYjwYt4Rr5qaqb5VR4Ix6qQP5ErjEQFDDm/Q3RAU9no+mP6XHQ\r
+8yWHvYBaOaMdPOCAuPIl5UmFfuDsQ1wxBB5sLH9omkzzIQn1VynTqq7Is2PLYwm8\r
+0RR/NbblYKJmHpnny3Seabzv+6J3DD7ZmeW7K3fHEBHs582VwaojS+GRvZJrzDJ+\r
+UbDDxRDyMvKxr4Q1QH13doqcJ8p4en3HpFanY2mGIR4je/b295b9nUZnuFh2e5Un\r
+FoPim91THuUhFabIw6nNWZN7j2qCdcMwalTYql++Xi4Pb3fAWZNSgrXnN+nojxWy\r
+9dTsKLFD3Xv/Ae7/CinebSQUV7oBngvfRvmtTR8E3F39zLl9ZN0XD576Y3GwMFT7\r
+w6wj1hLP1dTjIvlhaLynwsUcYDK4Veq9nGGe4RKYhEXQAHaNOeAHdBVPIR2JX3+Z\r
+Y/rU817v3mU7dR7ddB4b7/K5j8J/65DDQK4FX3XEqacdJpgsbRM806mtjx/CvAG5\r
+mRST4o7lxkZoe0UbWUk9\r
+=mD9j\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r