--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id C474B431FBD\r
+ for <notmuch@notmuchmail.org>; Wed, 4 Jul 2012 09:22:49 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id rkcFGi0jdmjj for <notmuch@notmuchmail.org>;\r
+ Wed, 4 Jul 2012 09:22:48 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-1.mit.edu (DMZ-MAILSEC-SCANNER-1.MIT.EDU\r
+ [18.9.25.12])\r
+ by olra.theworths.org (Postfix) with ESMTP id B5B7D431FAE\r
+ for <notmuch@notmuchmail.org>; Wed, 4 Jul 2012 09:22:46 -0700 (PDT)\r
+X-AuditID: 1209190c-b7f806d000006b87-bf-4ff46dd6eea7\r
+Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
+ by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id 35.A6.27527.6DD64FF4; Wed, 4 Jul 2012 12:22:46 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+ by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q64GMjcp002277; \r
+ Wed, 4 Jul 2012 12:22:45 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q64GMiBA006235\r
+ (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+ Wed, 4 Jul 2012 12:22:44 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+ (envelope-from <amdragon@MIT.EDU>)\r
+ id 1SmSLj-0000Db-Vu; Wed, 04 Jul 2012 12:22:44 -0400\r
+Date: Wed, 4 Jul 2012 12:22:43 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [PATCH 1/8] emacs: Clean up notmuch-search-show-result\r
+Message-ID: <20120704162243.GC21653@mit.edu>\r
+References: <1341354059-29396-1-git-send-email-amdragon@mit.edu>\r
+ <1341354059-29396-2-git-send-email-amdragon@mit.edu>\r
+ <87lij0gdwt.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <87lij0gdwt.fsf@qmul.ac.uk>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFuphleLIzCtJLcpLzFFi42IRYrdT172W+8XfYOJKEYvVc3ksrt+cyWzx\r
+ ZuU8Vgdmj52z7rJ7HP66kMXj2apbzAHMUVw2Kak5mWWpRfp2CVwZ3/dfYim4K1Hx8v4G1gbG\r
+ U8JdjJwcEgImEsfOf2SFsMUkLtxbz9bFyMUhJLCPUeLg97OMEM56Rokl2++ygVQJCZxgkjje\r
+ 7ASRWMIo8W9KLwtIgkVARWLZlFvMIDabgIbEtv3LGUFsEQEdiduHFrCD2MwC+hIrT84EqxEW\r
+ cJa43LEKqJeDgxeoZudvX4iZUxklmvYsBavhFRCUODnzCQtEr5bEjX8vmUDqmQWkJZb/4wAJ\r
+ cwKt2n/sOBOILQp0wpST29gmMArNQtI9C0n3LITuBYzMqxhlU3KrdHMTM3OKU5N1i5MT8/JS\r
+ i3QN9XIzS/RSU0o3MYICnVOSZwfjm4NKhxgFOBiVeHiTFT77C7EmlhVX5h5ilORgUhLl3ZT1\r
+ xV+ILyk/pTIjsTgjvqg0J7X4EKMEB7OSCK99OFCONyWxsiq1KB8mJc3BoiTOeznlpr+QQHpi\r
+ SWp2ampBahFMVoaDQ0mCVxYY0UKCRanpqRVpmTklCGkmDk6Q4TxAw5fkgAwvLkjMLc5Mh8if\r
+ YlSUEuflA2kWAElklObB9cIS0StGcaBXhHn/gLTzAJMYXPcroMFMQIPzFn8CGVySiJCSamDU\r
+ rWvd0mjCJP/6ziOPEKkdEXOvZsh/PNDHNp/vOKPKvKlf3jZ4fzt86P6MbVtOLPl7Z+vs6Qf/\r
+ ay0+uCQ+YdYFq5Ac4YyTzyqOG4vbi26aE2trPf9I3objoZryj0svfI28Kia6JU7+YMk2NYOo\r
+ Xyzf80yTrr/2VdtkGbP9jmvckeKlvSz3vnS8U2Ipzkg01GIuKk4EAFtVQMofAwAA\r
+Cc: tomi.ollila@iki.fi, notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 04 Jul 2012 16:22:50 -0000\r
+\r
+Quoth Mark Walters on Jul 04 at 8:53 am:\r
+> On Tue, 03 Jul 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> > This simplifies the code and makes it no longer cubic in the number of\r
+> > result fields.\r
+> \r
+> This looks good to me and all tests pass, and I agree that this patch\r
+> can be pushed independently of the later patches in the series.\r
+> \r
+> My one comment is that I, as a lisp beginner, found the use of "format"\r
+> as a function and a variable confusing (particularly as I had not come\r
+> across the dolist macro and that use really makes format look like a\r
+> function).\r
+\r
+I can see how that would be confusing. Unless this version of the\r
+series is somehow perfect, I'll rename it in the second version.\r
+Perhaps result-format for the loop variable and spec for the format\r
+string argument?\r
+\r
+> Best wishes\r
+> \r
+> Mark\r
+> \r
+> > ---\r
+> > emacs/notmuch.el | 20 ++++++++++----------\r
+> > 1 file changed, 10 insertions(+), 10 deletions(-)\r
+> >\r
+> > diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+> > index c6236db..be217a2 100644\r
+> > --- a/emacs/notmuch.el\r
+> > +++ b/emacs/notmuch.el\r
+> > @@ -707,29 +707,29 @@ non-authors is found, assume that all of the authors match."\r
+> > (overlay-put overlay 'isearch-open-invisible #'delete-overlay)))\r
+> > (insert padding))))\r
+> > \r
+> > -(defun notmuch-search-insert-field (field date count authors subject tags)\r
+> > +(defun notmuch-search-insert-field (field format date count authors subject tags)\r
+> > (cond\r
+> > ((string-equal field "date")\r
+> > - (insert (propertize (format (cdr (assoc field notmuch-search-result-format)) date)\r
+> > + (insert (propertize (format format date)\r
+> > 'face 'notmuch-search-date)))\r
+> > ((string-equal field "count")\r
+> > - (insert (propertize (format (cdr (assoc field notmuch-search-result-format)) count)\r
+> > + (insert (propertize (format format count)\r
+> > 'face 'notmuch-search-count)))\r
+> > ((string-equal field "subject")\r
+> > - (insert (propertize (format (cdr (assoc field notmuch-search-result-format)) subject)\r
+> > + (insert (propertize (format format subject)\r
+> > 'face 'notmuch-search-subject)))\r
+> > \r
+> > ((string-equal field "authors")\r
+> > - (notmuch-search-insert-authors (cdr (assoc field notmuch-search-result-format)) authors))\r
+> > + (notmuch-search-insert-authors format authors))\r
+> > \r
+> > ((string-equal field "tags")\r
+> > - (insert (concat "(" (propertize tags 'font-lock-face 'notmuch-tag-face) ")")))))\r
+> > + (insert\r
+> > + (format format (propertize tags 'font-lock-face 'notmuch-tag-face))))))\r
+> > \r
+> > (defun notmuch-search-show-result (date count authors subject tags)\r
+> > - (let ((fields) (field))\r
+> > - (setq fields (mapcar 'car notmuch-search-result-format))\r
+> > - (loop for field in fields\r
+> > - do (notmuch-search-insert-field field date count authors subject tags)))\r
+> > + (dolist (format notmuch-search-result-format)\r
+> > + (notmuch-search-insert-field (car format) (cdr format)\r
+> > + date count authors subject tags))\r
+> > (insert "\n"))\r
+> > \r
+> > (defun notmuch-search-process-filter (proc string)\r
projects / notmuch-archives.git / commitdiff