Re: [PATCH] notmuch-tag: initialize with enum instead of 0.

diff --git a/a4/29ca087c65f1bb1a858d74332d9a9cc6ea607a b/a4/29ca087c65f1bb1a858d74332d9a9cc6ea607a
new file mode 100644 (file)
index 0000000..7d42577
--- /dev/null
+++ b/a4/29ca087c65f1bb1a858d74332d9a9cc6ea607a
@@ -0,0 +1,75 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2D2C4431FB6\r
+       for <notmuch@notmuchmail.org>; Sat, 19 Jan 2013 09:29:30 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Wcc3o4j4JejV for <notmuch@notmuchmail.org>;\r
+       Sat, 19 Jan 2013 09:29:29 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 785A2431FAF\r
+       for <notmuch@notmuchmail.org>; Sat, 19 Jan 2013 09:29:29 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 8209E100044;\r
+       Sat, 19 Jan 2013 19:29:18 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: david@tethera.net, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] notmuch-tag: initialize with enum instead of 0.\r
+In-Reply-To: <1358601464-13606-1-git-send-email-david@tethera.net>\r
+References: <m2txqphddd.fsf@guru.guru-group.fi>\r
+       <1358601464-13606-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.14+260~gd7a61d6 (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sat, 19 Jan 2013 19:29:18 +0200\r
+Message-ID: <m2fw1x84k1.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: David Bremner <bremner@debian.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 19 Jan 2013 17:29:30 -0000\r
+\r
+On Sat, Jan 19 2013, david@tethera.net wrote:\r
+\r
+> From: David Bremner <bremner@debian.org>\r
+>\r
+> This is just a cosmetic fix to make the "type" of ret more clear.\r
+> ---\r
+>  notmuch-tag.c |    2 +-\r
+>  1 file changed, 1 insertion(+), 1 deletion(-)\r
+>\r
+> diff --git a/notmuch-tag.c b/notmuch-tag.c\r
+> index b54c55d..d9daf8f 100644\r
+> --- a/notmuch-tag.c\r
+> +++ b/notmuch-tag.c\r
+> @@ -97,7 +97,7 @@ tag_query (void *ctx, notmuch_database_t *notmuch, const char *query_string,\r
+>      notmuch_query_t *query;\r
+>      notmuch_messages_t *messages;\r
+>      notmuch_message_t *message;\r
+> -    int ret = 0;\r
+> +    int ret = NOTMUCH_STATUS_SUCCESS;\r
+\r
+LGTM.\r
+\r
+Tomi\r