--- /dev/null
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 721E0431FD2\r
+ for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 17:51:26 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 5GcWvdz40L7d for <notmuch@notmuchmail.org>;\r
+ Sun, 29 Jan 2012 17:51:25 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+ [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id A697F431FBC\r
+ for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 17:51:25 -0800 (PST)\r
+Received: by bke11 with SMTP id 11so942363bke.26\r
+ for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 17:51:24 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+ h=from:to:cc:subject:in-reply-to:references:user-agent:date\r
+ :message-id:mime-version:content-type;\r
+ bh=IiAG+8nJprtMalIS+7Op9BqP6k34iSdKEcn8kuENXYw=;\r
+ b=jO2afrIf4obKm6O6RSKQKxeTvJoYG2+m4EFn+FCSyiPhlxQw1EwXc+qBwN1LCEf8Ry\r
+ AjMuN8uvTnYkPKYKdavrmFdiI3TekgXYXcfWv2BMgwAC/3ewUvFYuBrQbcVh/TdGqPtP\r
+ H3k58o4xX0IKGD6rTLLRe5C8PJIaji0PU1QEM=\r
+Received: by 10.204.129.198 with SMTP id p6mr7459468bks.96.1327888284175;\r
+ Sun, 29 Jan 2012 17:51:24 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+ by mx.google.com with ESMTPS id 20sm23351692bkr.0.2012.01.29.17.51.23\r
+ (version=TLSv1/SSLv3 cipher=OTHER);\r
+ Sun, 29 Jan 2012 17:51:23 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [PATCH 8/6] emacs: use message ids instead of thread id in\r
+ `notmuch-show-operate-all'\r
+In-Reply-To: <20120129231120.GJ17991@mit.edu>\r
+References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+ <1327730348-6466-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+ <20120129231120.GJ17991@mit.edu>\r
+User-Agent: Notmuch/0.11+134~g7ddba9d (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Mon, 30 Jan 2012 05:50:14 +0400\r
+Message-ID: <87y5sq6js9.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 30 Jan 2012 01:51:26 -0000\r
+\r
+EOn Sun, 29 Jan 2012 18:11:20 -0500, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> Eighth in the increasingly inaccurately named six patch series...\r
+> \r
+> Quoth Dmitry Kurochkin on Jan 28 at 9:59 am:\r
+> > Before the change, `notmuch-show-operate-all' used thread id for\r
+> > "notmuch tag" search. This could result in tagging unexpected\r
+> > messages that were added to the thread after the notmuch-show buffer\r
+> > was created. The patch changes `notmuch-show-operate-all' to use ids\r
+> > of shown messages to fix this.\r
+> \r
+> Are you planning to roll this into your earlier patch?\r
+> \r
+\r
+I would prefer to leave it separate.\r
+\r
+> > ---\r
+> > emacs/notmuch-show.el | 23 ++++++++++++++++++++++-\r
+> > 1 files changed, 22 insertions(+), 1 deletions(-)\r
+> > \r
+> > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> > index 2ca4d92..e606224 100644\r
+> > --- a/emacs/notmuch-show.el\r
+> > +++ b/emacs/notmuch-show.el\r
+> > @@ -1170,6 +1170,15 @@ All currently available key bindings:\r
+> > (notmuch-show-move-to-message-top)\r
+> > t))\r
+> > \r
+> > +(defun notmuch-show-mapc (function)\r
+> > + "Iterate through all messages with\r
+> > +`notmuch-show-goto-message-next' and call `function' for side\r
+> > +effects."\r
+> \r
+> `function' should be FUNCTION.\r
+> \r
+\r
+done\r
+\r
+> > + (save-excursion\r
+> > + (goto-char (point-min))\r
+> > + (loop do (funcall function)\r
+> > + while (notmuch-show-goto-message-next))))\r
+> > +\r
+> > ;; Functions relating to the visibility of messages and their\r
+> > ;; components.\r
+> > \r
+> > @@ -1222,6 +1231,18 @@ Some useful entries are:\r
+> > "Return the message id of the current message."\r
+> > (concat "id:\"" (notmuch-show-get-prop :id) "\""))\r
+> > \r
+> > +(defun notmuch-show-get-messages-ids ()\r
+> > + "Return all message ids of currently shown messages."\r
+> \r
+> "currently shown" could mean visible on the screen, which is not what\r
+> you mean. You also don't mean "open messages". Maybe "Return all\r
+> message ids of messages in this show buffer"?\r
+> \r
+\r
+Changed to "messages in the current thread". That is consistent with\r
+other docstrings in notmuch-show.el.\r
+\r
+> > + (let ((message-ids))\r
+> > + (notmuch-show-mapc\r
+> > + (lambda () (push (notmuch-show-get-message-id) message-ids)))\r
+> > + message-ids))\r
+> > +\r
+> > +(defun notmuch-show-get-messages-ids-search ()\r
+> > + "Return a search string for all message ids of currently shown\r
+> > +messages."\r
+> \r
+> Same.\r
+> \r
+\r
+fixed\r
+\r
+Regards,\r
+ Dmitry\r
+\r
+> > + (mapconcat 'identity (notmuch-show-get-messages-ids) " or "))\r
+> > +\r
+> > ;; dme: Would it make sense to use a macro for many of these?\r
+> > \r
+> > (defun notmuch-show-get-filename ()\r
+> > @@ -1496,7 +1517,7 @@ i.e. a list of tags to change with '+' and '-' prefixes."\r
+> > `Changed-tags' is a list of tag operations for \"notmuch tag\",\r
+> > i.e. a list of tags to change with '+' and '-' prefixes."\r
+> > (interactive (notmuch-select-tags-with-completion nil notmuch-show-thread-id))\r
+> > - (apply 'notmuch-tag notmuch-show-thread-id changed-tags)\r
+> > + (apply 'notmuch-tag (notmuch-show-get-messages-ids-search) changed-tags)\r
+> > (save-excursion\r
+> > (goto-char (point-min))\r
+> > (loop do (let* ((current-tags (notmuch-show-get-tags))\r
projects / notmuch-archives.git / commitdiff