--- /dev/null
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id D9DC5429E31\r
+ for <notmuch@notmuchmail.org>; Fri, 24 Feb 2012 02:41:07 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id Gie4own1SiLi for <notmuch@notmuchmail.org>;\r
+ Fri, 24 Feb 2012 02:41:07 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+ [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 0C9C4431FAE\r
+ for <notmuch@notmuchmail.org>; Fri, 24 Feb 2012 02:41:06 -0800 (PST)\r
+Received: by bkcit16 with SMTP id it16so2020859bkc.26\r
+ for <notmuch@notmuchmail.org>; Fri, 24 Feb 2012 02:41:05 -0800 (PST)\r
+Received-SPF: pass (google.com: domain of dmitry.kurochkin@gmail.com\r
+ designates 10.204.10.91 as permitted sender)\r
+ client-ip=10.204.10.91; \r
+Authentication-Results: mr.google.com; spf=pass (google.com: domain of\r
+ dmitry.kurochkin@gmail.com designates 10.204.10.91 as permitted\r
+ sender) smtp.mail=dmitry.kurochkin@gmail.com;\r
+ dkim=pass header.i=dmitry.kurochkin@gmail.com\r
+Received: from mr.google.com ([10.204.10.91])\r
+ by 10.204.10.91 with SMTP id o27mr818767bko.17.1330080065749 (num_hops\r
+ = 1); Fri, 24 Feb 2012 02:41:05 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+ h=from:to:cc:subject:in-reply-to:references:user-agent:date\r
+ :message-id:mime-version:content-type;\r
+ bh=BQIiErY7N98r2FbpN1yiO3UsjlHldJkZFxpGYmr3OpU=;\r
+ b=iDGX56JBqKU8GiSZdPd4ihz5QwfwCfjPoFSjW3i9bw4+J3UPxLb1bW5nEHxTVHo2Hu\r
+ lhopfjqIMM5/oz99xGGnS1c5Lg/g1+Cj2JH/mGlBusxtNw+N66RNxe650aKC+WDNR9wL\r
+ BxyGpadfseuvRM2k294jFa9GPMHfct6RlyTGg=\r
+Received: by 10.204.10.91 with SMTP id o27mr681097bko.17.1330080065681;\r
+ Fri, 24 Feb 2012 02:41:05 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+ by mx.google.com with ESMTPS id w15sm7893400bku.0.2012.02.24.02.41.04\r
+ (version=TLSv1/SSLv3 cipher=OTHER);\r
+ Fri, 24 Feb 2012 02:41:04 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Pieter Praet <pieter@praet.org>, David Bremner <david@tethera.net>\r
+Subject: Re: [PATCH 4/6] emacs: add predicate arg to `notmuch-show-mapc'\r
+In-Reply-To: <1330038554-10347-4-git-send-email-pieter@praet.org>\r
+References: <878vjtqhcg.fsf@praet.org>\r
+ <1330038554-10347-4-git-send-email-pieter@praet.org>\r
+User-Agent: Notmuch/0.11.1+188~ga5674c2 (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Fri, 24 Feb 2012 14:39:41 +0400\r
+Message-ID: <87fwe0jz0y.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 24 Feb 2012 10:41:08 -0000\r
+\r
+On Fri, 24 Feb 2012 00:09:12 +0100, Pieter Praet <pieter@praet.org> wrote:\r
+> * emacs/notmuch-show.el\r
+> \r
+> (notmuch-show-mapc):\r
+> Only call FUNCTION if new argument PREDICATE is satisfied.\r
+> Also correct original docstring: 's/thread/buffer/'.\r
+> \r
+> (notmuch-show-get-messages-ids):\r
+> Update wrt changes to `notmuch-show-mapc'.\r
+> \r
+> (notmuch-show-tag-all):\r
+> Update wrt changes to `notmuch-show-mapc'.\r
+> ---\r
+> emacs/notmuch-show.el | 15 ++++++++-------\r
+> 1 files changed, 8 insertions(+), 7 deletions(-)\r
+> \r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index aa9ccee..5fc0e43 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -1272,13 +1272,14 @@ (defun notmuch-show-goto-message-previous ()\r
+> (notmuch-show-move-to-message-top)\r
+> t))\r
+> \r
+> -(defun notmuch-show-mapc (function)\r
+> - "Iterate through all messages in the current thread with\r
+> -`notmuch-show-goto-message-next' and call FUNCTION for side\r
+> -effects."\r
+> +(defun notmuch-show-mapc (predicate function)\r
+\r
+Please make PREDICATE optional to avoid giving t when it is not needed.\r
+\r
+I would expect PREDICATE to be a function, but perhaps the way you\r
+implemented it is common in Emacs.\r
+\r
+Regards,\r
+ Dmitry\r
+\r
+> + "Iterate through all messages in the current buffer with\r
+> +`notmuch-show-goto-message-next'. If PREDICATE is satisfied,\r
+> +call FUNCTION for side effects."\r
+> (save-excursion\r
+> (goto-char (point-min))\r
+> - (loop do (funcall function)\r
+> + (loop do (if (eval predicate)\r
+> + (funcall function))\r
+> while (notmuch-show-goto-message-next))))\r
+> \r
+> ;; Functions relating to the visibility of messages and their\r
+> @@ -1336,7 +1337,7 @@ (defun notmuch-show-get-message-id ()\r
+> (defun notmuch-show-get-messages-ids ()\r
+> "Return all message ids of messages in the current thread."\r
+> (let ((message-ids))\r
+> - (notmuch-show-mapc\r
+> + (notmuch-show-mapc t\r
+> (lambda () (push (notmuch-show-get-message-id) message-ids)))\r
+> message-ids))\r
+> \r
+> @@ -1633,7 +1634,7 @@ (defun notmuch-show-tag-all (&rest tag-changes)\r
+> TAG-CHANGES is a list of tag operations for `notmuch-tag'."\r
+> (interactive (notmuch-read-tag-changes nil notmuch-show-thread-id))\r
+> (apply 'notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes)\r
+> - (notmuch-show-mapc\r
+> + (notmuch-show-mapc t\r
+> (lambda ()\r
+> (let* ((current-tags (notmuch-show-get-tags))\r
+> (new-tags (notmuch-update-tags current-tags tag-changes)))\r
+> -- \r
+> 1.7.8.1\r
+> \r
projects / notmuch-archives.git / commitdiff