[PATCH v3 10/12] emacs: accept empty tag list in `notmuch-tag'

diff --git a/db/bf56e113ea3042e0d2843f1f1f6c57178022fc b/db/bf56e113ea3042e0d2843f1f1f6c57178022fc
new file mode 100644 (file)
index 0000000..5c55de4
--- /dev/null
+++ b/db/bf56e113ea3042e0d2843f1f1f6c57178022fc
@@ -0,0 +1,95 @@
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 826D4421166\r
+       for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 21:36:09 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 0UWuFoCM+j-l for <notmuch@notmuchmail.org>;\r
+       Sun, 29 Jan 2012 21:36:07 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+       [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id AF7EA42119E\r
+       for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 21:35:35 -0800 (PST)\r
+Received: by mail-bk0-f53.google.com with SMTP id 11so1052482bke.26\r
+       for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 21:35:35 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=from:to:subject:date:message-id:x-mailer:in-reply-to:references;\r
+       bh=mILkKF1tAooB48ry02tQnQfXPSoYzQo3tnTNoh2I3OU=;\r
+       b=obCDJWug72RxsBXMYxoGmGpNzdUe/xoEW6lce00pdMlnIBCIGmYQTYodroiAk06zG3\r
+       3x/3s4ZoW5iZbPoay3cefD4q3dKKCEdh5SYGz2GoK3g3Oe4fYIQbXXdQI0bEqvBpMjB5\r
+       Uv2aHFm2qzjOlYTYZJERNuu7BAoLJZtkByNms=\r
+Received: by 10.204.152.15 with SMTP id e15mr7969088bkw.108.1327901735462;\r
+       Sun, 29 Jan 2012 21:35:35 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+       by mx.google.com with ESMTPS id ek9sm35151326bkb.10.2012.01.29.21.35.34\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Sun, 29 Jan 2012 21:35:34 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH v3 10/12] emacs: accept empty tag list in `notmuch-tag'\r
+Date: Mon, 30 Jan 2012 09:34:02 +0400\r
+Message-Id: <1327901644-15799-11-git-send-email-dmitry.kurochkin@gmail.com>\r
+X-Mailer: git-send-email 1.7.8.3\r
+In-Reply-To: <1327901644-15799-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <1327901644-15799-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 30 Jan 2012 05:36:10 -0000\r
+\r
+Since `notmuch-tag' is a non-interactive function and hence is meant\r
+to be invoked programmatically, it should accept zero tags.  Also, the\r
+tagging operations (bound to "*", "+", "-") would accept empty input\r
+without an error.\r
+---\r
+ emacs/notmuch.el |   10 +++++-----\r
+ 1 files changed, 5 insertions(+), 5 deletions(-)\r
+\r
+diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+index 2332c42..c464c3c 100644\r
+--- a/emacs/notmuch.el\r
++++ b/emacs/notmuch.el\r
+@@ -554,15 +554,15 @@ messages instead of running (notmuch-call-notmuch-process \"tag\" ..)\r
+ directly, so that hooks specified in notmuch-before-tag-hook and\r
+ notmuch-after-tag-hook will be run."\r
+   ;; Perform some validation\r
+-  (when (null tags) (error "No tags given"))\r
+   (mapc (lambda (tag)\r
+         (unless (string-match-p "^[-+]\\S-+$" tag)\r
+           (error "Tag must be of the form `+this_tag' or `-that_tag'")))\r
+       tags)\r
+-  (run-hooks 'notmuch-before-tag-hook)\r
+-  (apply 'notmuch-call-notmuch-process\r
+-       (append (list "tag") tags (list "--" query)))\r
+-  (run-hooks 'notmuch-after-tag-hook))\r
++  (unless (null tags)\r
++    (run-hooks 'notmuch-before-tag-hook)\r
++    (apply 'notmuch-call-notmuch-process "tag"\r
++         (append tags (list "--" query)))\r
++    (run-hooks 'notmuch-after-tag-hook)))\r
+ \r
+ (defcustom notmuch-before-tag-hook nil\r
+   "Hooks that are run before tags of a message are modified.\r
+-- \r
+1.7.8.3\r
+\r