Re: [PATCH 3/3] lib: Reject multi-message mboxes and deprecate single-message mbox

diff --git a/bd/735188bca4f9650642fdeabf07bb5f2c9ca8a2 b/bd/735188bca4f9650642fdeabf07bb5f2c9ca8a2
new file mode 100644 (file)
index 0000000..cd84d26
--- /dev/null
+++ b/bd/735188bca4f9650642fdeabf07bb5f2c9ca8a2
@@ -0,0 +1,89 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id CE164431FAF\r
+       for <notmuch@notmuchmail.org>; Sun, 25 Nov 2012 05:27:02 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 8-abMAbAVlim for <notmuch@notmuchmail.org>;\r
+       Sun, 25 Nov 2012 05:27:02 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id DD48A431FAE\r
+       for <notmuch@notmuchmail.org>; Sun, 25 Nov 2012 05:27:01 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 975801000E5;\r
+       Sun, 25 Nov 2012 15:26:58 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 3/3] lib: Reject multi-message mboxes and deprecate\r
+       single-message mbox\r
+In-Reply-To: <1353824161-31717-3-git-send-email-amdragon@mit.edu>\r
+References: <1353824161-31717-1-git-send-email-amdragon@mit.edu>\r
+       <1353824161-31717-3-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 25 Nov 2012 15:26:58 +0200\r
+Message-ID: <m2y5hpu82l.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 25 Nov 2012 13:27:03 -0000\r
+\r
+On Sun, Nov 25 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+\r
+> Previously, we would treat multi-message mboxes as one giant email,\r
+> which, besides the obvious incorrect indexing, often led to\r
+> out-of-memory errors for archival mboxes.  Now we explicitly reject\r
+> multi-message mboxes.  For historical reasons, we retain support for\r
+> single-message mboxes, but official deprecate this behavior.\r
+\r
+\r
+The series looks good to me -- but I don't know about deprecating\r
+single-message mboxes:\r
+\r
+* If we someday support (read-only?) mbox format, then single-message\r
+  mboxes are "normal" again.\r
+\r
+* Some na=C3=AFve mb2md scripts could leave the 'From ' -line intact: for\r
+  example `formail -bz -s head -3 < $MAIL`(*) can be used to demonstrate th=\r
+is\r
+\r
+* Some people may have large collection of single-file messages starting\r
+  with 'From ' currently indexed. If those are to be re-indexed later\r
+  without "single-message mbox" support that is somewhat of a burden to\r
+  the users (**)\r
+\r
+(*) my "mb2md" wannabe does gnus-like "$formail" -bz -R 'From ' X-From-Line=\r
+: ...\r
+\r
+(**) Something like the following could be used to mangle "single-file mbox=\r
+es"...\r
+     find . -type f | xargs perl -e 'foreach (@ARGV) { open IO, "+<", $_ or\r
+     next; sysread IO, $buf, 5; if ($buf eq "From ") { sysseek IO, 0, 0;\r
+     syswrite IO, "Fro:"; }}'=20\r
+     This breaks the multi-message mbox nicely... >;)\r
+\r
+\r
+Tomi\r