Re: [PATCH v2 4/6] emacs: add optional predicate arg to `notmuch-show-mapc'

diff --git a/72/e6e67dc8f757f748bc3bdeb42fb7ec21826edd b/72/e6e67dc8f757f748bc3bdeb42fb7ec21826edd
new file mode 100644 (file)
index 0000000..1357819
--- /dev/null
+++ b/72/e6e67dc8f757f748bc3bdeb42fb7ec21826edd
@@ -0,0 +1,106 @@
+Return-Path: <ethan.glasser.camp@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D9DB1431FB6\r
+       for <notmuch@notmuchmail.org>; Mon, 15 Oct 2012 19:18:20 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id FM7Hhw4-13d2 for <notmuch@notmuchmail.org>;\r
+       Mon, 15 Oct 2012 19:18:17 -0700 (PDT)\r
+Received: from mail-qa0-f46.google.com (mail-qa0-f46.google.com\r
+       [209.85.216.46]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id DFE5B431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 15 Oct 2012 19:18:16 -0700 (PDT)\r
+Received: by mail-qa0-f46.google.com with SMTP id c26so2300548qad.5\r
+       for <notmuch@notmuchmail.org>; Mon, 15 Oct 2012 19:18:15 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:cc:subject:in-reply-to:references:user-agent:date\r
+       :message-id:mime-version:content-type;\r
+       bh=SWR65n0tLZFcxPVAQ0AXrHnCvOkg1foQtkMcCBlZ2Ps=;\r
+       b=z9a8kiJusZqkGVOh4fJog3ZCers/Mlybf7G+IoRVKLsJtt845msOMUJszAllJ8Um0L\r
+       IB9BUMG3ZnLFaDPEwCpZdPTk1jiENhF9u1XVnO3MUET+33l7xCM3KEeYEmfemjjtLmQL\r
+       nWcfwPu440BCPzLgcYvIyw+g1MmI4Np+NQRLkdjaFvqqpNqL2yx7nQ6IIwnPabX5SPns\r
+       VACrYSbX9dF3hBGvUNF6kj/GhfR5Rw97in83wIA7Nj9fYp4J/duCMtGEsf0GE483sDiE\r
+       jF20ToQLS4K4l6FE/umt2BkebSGBrjMjZ81nRP2cyr5/mNk+ypE133zO+0/8XHl5kiJb\r
+       gtgQ==\r
+Received: by 10.49.130.234 with SMTP id oh10mr32205530qeb.42.1350353895215;\r
+       Mon, 15 Oct 2012 19:18:15 -0700 (PDT)\r
+Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80])\r
+       by mx.google.com with ESMTPS id ck18sm17218493qab.7.2012.10.15.19.18.13\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Mon, 15 Oct 2012 19:18:14 -0700 (PDT)\r
+From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>\r
+To: Pieter Praet <pieter@praet.org>, David Bremner <david@tethera.net>,\r
+       Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+Subject: Re: [PATCH v2 4/6] emacs: add optional predicate arg to\r
+       `notmuch-show-mapc'\r
+In-Reply-To: <1330122640-18895-5-git-send-email-pieter@praet.org>\r
+References: <87wr7xqpuf.fsf@rocinante.cs.unb.ca>\r
+       <1330122640-18895-1-git-send-email-pieter@praet.org>\r
+       <1330122640-18895-5-git-send-email-pieter@praet.org>\r
+User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 15 Oct 2012 22:18:12 -0400\r
+Message-ID: <87r4oz88ij.fsf@betacantrips.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 16 Oct 2012 02:18:21 -0000\r
+\r
+Pieter Praet <pieter@praet.org> writes:\r
+\r
+> * emacs/notmuch-show.el (notmuch-show-mapc):\r
+>\r
+>   If provided with optional argument PREDICATE, only call\r
+>   FUNCTION if calling PREDICATE returns non-nil.\r
+>\r
+>   Also correct original docstring: 's/thread/buffer/'.\r
+> ---\r
+\r
+This patch was marked stale, but isn't.\r
+\r
+> -(defun notmuch-show-mapc (function)\r
+> -  "Iterate through all messages in the current thread with\r
+> +(defun notmuch-show-mapc (function &optional predicate)\r
+> +  "Iterate through all messages in the current buffer with\r
+>  `notmuch-show-goto-message-next' and call FUNCTION for side\r
+> -effects."\r
+> +effects.\r
+> +\r
+> +If provided with optional argument PREDICATE, only call\r
+> +FUNCTION if calling PREDICATE returns non-nil."\r
+>    (save-excursion\r
+>      (goto-char (point-min))\r
+> -    (loop do (funcall function)\r
+> +    (loop do (if predicate\r
+> +             (if (funcall predicate)\r
+> +                 (funcall function))\r
+> +           (funcall function))\r
+\r
+I don't like the way this if-structure looks, since I have to squint to\r
+see whether the "else" clause matches the inner or the outer "if". Maybe\r
+change the inner "if" to a "when" or an "and"?\r
+\r
+Ethan\r
+\r