--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 21CE4431FC0\r
+ for <notmuch@notmuchmail.org>; Tue, 20 Mar 2012 18:06:26 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id ZQv6Wr+CF5dZ for <notmuch@notmuchmail.org>;\r
+ Tue, 20 Mar 2012 18:06:25 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 6437B431FAF\r
+ for <notmuch@notmuchmail.org>; Tue, 20 Mar 2012 18:06:25 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1SAA0K-0001X9-CK; Wed, 21 Mar 2012 01:06:20 +0000\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+ helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1SAA0K-0001NZ-0c; Wed, 21 Mar 2012 01:06:20 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Pieter Praet <pieter@praet.org>, David Bremner <david@tethera.net>,\r
+ Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+Subject: Re: [PATCH v2 1/6] test: emacs: new tests "notmuch-show: {add,\r
+ remove} multiple tags {to, from} single message"\r
+In-Reply-To: <1330122640-18895-2-git-send-email-pieter@praet.org>\r
+References: <87wr7xqpuf.fsf@rocinante.cs.unb.ca>\r
+ <1330122640-18895-1-git-send-email-pieter@praet.org>\r
+ <1330122640-18895-2-git-send-email-pieter@praet.org>\r
+User-Agent: Notmuch/0.12+67~g3bd579a (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Wed, 21 Mar 2012 01:06:32 +0000\r
+Message-ID: <874ntiyd7r.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 2c8534889bcd95136a5f16bee42a9dad (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -1.8 points.\r
+ Summary of the scoring: \r
+ * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+ * medium trust\r
+ * [138.37.6.40 listed in list.dnswl.org]\r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+ * domain\r
+ * 0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 21 Mar 2012 01:06:26 -0000\r
+\r
+\r
+Hi\r
+\r
+> * test/emacs:\r
+> \r
+> - Rename subtests "{Add,Remove} tag from notmuch-show view" to\r
+> "notmuch-show: {add,remove} single tag {to,from} single message"\r
+> to be consistent with the following tests.\r
+> \r
+> - New subtest "notmuch-show: add multiple tags to single message":\r
+> `notmuch-show-add-tag' ("+") can add multiple tags to a message.\r
+> \r
+> - New subtest "notmuch-show: remove multiple tags from single message":\r
+> `notmuch-show-remove-tag' ("-") can remove multiple tags from a message.\r
+> ---\r
+> test/emacs | 16 ++++++++++++++--\r
+> 1 files changed, 14 insertions(+), 2 deletions(-)\r
+> \r
+> diff --git a/test/emacs b/test/emacs\r
+> index b74cfa9..ec1dbb0 100755\r
+> --- a/test/emacs\r
+> +++ b/test/emacs\r
+> @@ -112,18 +112,30 @@ test_emacs "(notmuch-search \"$os_x_darwin_thread\")\r
+> output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)\r
+> test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox unread)"\r
+> \r
+> -test_begin_subtest "Add tag from notmuch-show view"\r
+> +test_begin_subtest "notmuch-show: add single tag to single message"\r
+> test_emacs "(notmuch-show \"$os_x_darwin_thread\")\r
+> (execute-kbd-macro \"+tag-from-show-view\")"\r
+> output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)\r
+> test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox tag-from-show-view unread)"\r
+> \r
+> -test_begin_subtest "Remove tag from notmuch-show view"\r
+> +test_begin_subtest "notmuch-show: remove single tag from single message"\r
+> test_emacs "(notmuch-show \"$os_x_darwin_thread\")\r
+> (execute-kbd-macro \"-tag-from-show-view\")"\r
+> output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)\r
+> test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox unread)"\r
+> \r
+> +test_begin_subtest "notmuch-show: add multiple tags to single message"\r
+> +test_emacs "(notmuch-show \"$os_x_darwin_thread\")\r
+> + (execute-kbd-macro \"+tag1-from-show-view +tag2-from-show-view\")"\r
+> +output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)\r
+> +test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox tag1-from-show-view tag2-from-show-view unread)"\r
+> +\r
+> +test_begin_subtest "notmuch-show: remove multiple tags from single message"\r
+> +test_emacs "(notmuch-show \"$os_x_darwin_thread\")\r
+> + (execute-kbd-macro \"-tag1-from-show-view -tag2-from-show-view\")"\r
+> +output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)\r
+> +test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox unread)"\r
+> +\r
+> test_begin_subtest "Message with .. in Message-Id:"\r
+> add_message [id]=123..456@example '[subject]="Message with .. in Message-Id"'\r
+> test_emacs '(notmuch-search "id:\"123..456@example\"")\r
+\r
+\r
+This looks good to me but I think it would be nice to have an extra test\r
+for adding a tag and removing a tag simultaneously.\r
+\r
+Best wishes \r
+\r
+Mark\r
projects / notmuch-archives.git / commitdiff