Re: [PATCH 1/3] contrib: add notmuch-pick.el file itself

diff --git a/cf/457adc45b1095330295c6405f50c8f990c5662 b/cf/457adc45b1095330295c6405f50c8f990c5662
new file mode 100644 (file)
index 0000000..f4fbbb4
--- /dev/null
+++ b/cf/457adc45b1095330295c6405f50c8f990c5662
@@ -0,0 +1,117 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C40BE431FBC\r
+       for <notmuch@notmuchmail.org>; Sat, 27 Oct 2012 10:49:23 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id MYISSDjxn1DD for <notmuch@notmuchmail.org>;\r
+       Sat, 27 Oct 2012 10:49:20 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id C26DD431FAF\r
+       for <notmuch@notmuchmail.org>; Sat, 27 Oct 2012 10:49:19 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1TSAVU-0001Zt-DO; Sat, 27 Oct 2012 18:49:12 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1TSAVU-0003qh-2z; Sat, 27 Oct 2012 18:49:12 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/3] contrib: add notmuch-pick.el file itself\r
+In-Reply-To: <87txtfhl1j.fsf@betacantrips.com>\r
+References: <1351337200-18050-1-git-send-email-markwalters1009@gmail.com>\r
+       <1351337200-18050-2-git-send-email-markwalters1009@gmail.com>\r
+       <87txtfhl1j.fsf@betacantrips.com>\r
+User-Agent: Notmuch/0.14+69~g024ea36 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 27 Oct 2012 18:49:12 +0100\r
+Message-ID: <87d3034xgn.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: a57c5499b88c5782e17e5ad2d7938f13 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -1.8 points.\r
+       Summary of the scoring: \r
+       * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+       *      medium trust\r
+       *      [138.37.6.40 listed in list.dnswl.org]\r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       *  0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 27 Oct 2012 17:49:23 -0000\r
+\r
+On Sat, 27 Oct 2012, Ethan Glasser-Camp <ethan.glasser.camp@gmail.com> wrote:\r
+> Mark Walters <markwalters1009@gmail.com> writes:\r
+>\r
+>> +(defvar notmuch-pick-json-parser nil\r
+>> +  "Incremental JSON parser for the search process filter.")\r
+>> +\r
+>> +(defun notmuch-pick-process-filter (proc string)\r
+>> +  "Process and filter the output of \"notmuch show\" (for pick)"\r
+>> +  (let ((results-buf (process-buffer proc))\r
+>> +        (parse-buf (process-get proc 'parse-buf))\r
+>> +        (inhibit-read-only t)\r
+>> +        done)\r
+>> +    (if (not (buffer-live-p results-buf))\r
+>> +        (delete-process proc)\r
+>> +      (with-current-buffer parse-buf\r
+>> +        ;; Insert new data\r
+>> +        (save-excursion\r
+>> +          (goto-char (point-max))\r
+>> +          (insert string)))\r
+>> +      (with-current-buffer results-buf\r
+>> +   (save-excursion\r
+>> +     (goto-char (point-max))\r
+>> +     (while (not done)\r
+>> +       (condition-case nil\r
+>> +           (case notmuch-pick-process-state\r
+>\r
+> This looks awfully familiar. Not looking too close, but why can't this\r
+> re-use the JSON parser from your other patch? Just not to rely on the\r
+> other patch series?\r
+\r
+I was not sure how long it would take to get the other series pushed,\r
+and I realised that in its latest incarnation notmuch-pick could be\r
+entirely in contrib so I thought that might be relatively easy to get\r
+in.\r
+\r
+If they both go in then I will submit a patch to make pick use the split\r
+out parser. Similarly, if id:"87ehnw84e5.fsf@qmul.ac.uk" or something\r
+similar goes in I can delete some code from pick.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r