Re: [PATCH 7/6] emacs: relax tag syntax check in `notmuch-tag' function

diff --git a/30/321af7bf16eae227fd239818acf4054834833d b/30/321af7bf16eae227fd239818acf4054834833d
new file mode 100644 (file)
index 0000000..d30cdb8
--- /dev/null
+++ b/30/321af7bf16eae227fd239818acf4054834833d
@@ -0,0 +1,115 @@
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 15906431FB6\r
+       for <notmuch@notmuchmail.org>; Sat, 28 Jan 2012 01:50:42 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id bg++2gGWqGFi for <notmuch@notmuchmail.org>;\r
+       Sat, 28 Jan 2012 01:50:38 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+       [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id EAAF5431FAE\r
+       for <notmuch@notmuchmail.org>; Sat, 28 Jan 2012 01:50:37 -0800 (PST)\r
+Received: by bkbzt19 with SMTP id zt19so2384438bkb.26\r
+       for <notmuch@notmuchmail.org>; Sat, 28 Jan 2012 01:50:36 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=from:to:cc:subject:in-reply-to:references:user-agent:date\r
+       :message-id:mime-version:content-type;\r
+       bh=tp69KnoQYVYlTdiwQp8i76mXUPK33h48+NEFE8hSlJA=;\r
+       b=hPzgB7dESbplhIp1Nyj4U7r+36ZMZyA7Q2cfsnb6s1DVgRVu14eMoChFqYtI76BHxd\r
+       FaRmYRDxIo64ZISocaluPVq0y8eHg3yELmshvQurcnd27kqA5yZbppID9cwr8R/Zsof5\r
+       EAeCwAY0wT+gq5ciTJd4kDNzGeC6ey9SwHHZI=\r
+Received: by 10.204.129.220 with SMTP id p28mr4884693bks.8.1327744236644;\r
+       Sat, 28 Jan 2012 01:50:36 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+       by mx.google.com with ESMTPS id cg2sm22178901bkb.12.2012.01.28.01.50.35\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Sat, 28 Jan 2012 01:50:35 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Jani Nikula <jani@nikula.org>\r
+Subject: Re: [PATCH 7/6] emacs: relax tag syntax check in `notmuch-tag'\r
+       function\r
+In-Reply-To:\r
+ <CAB+hUn834oJ+XGx-YyYSGxSnzrBYCMvcu4Vd73ws28qTS2riuA@mail.gmail.com>\r
+References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <1327727143-24455-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <CAB+hUn834oJ+XGx-YyYSGxSnzrBYCMvcu4Vd73ws28qTS2riuA@mail.gmail.com>\r
+User-Agent: Notmuch/0.11+134~g7ddba9d (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 28 Jan 2012 13:49:27 +0400\r
+Message-ID: <87ty3g88d4.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 28 Jan 2012 09:50:42 -0000\r
+\r
+On Sat, 28 Jan 2012 10:56:21 +0200, Jani Nikula <jani@nikula.org> wrote:\r
+> On Jan 28, 2012 7:06 AM, "Dmitry Kurochkin" <dmitry.kurochkin@gmail.com>\r
+> wrote:\r
+> >\r
+> > The tag syntax check in `notmuch-tag' function was too strict and did\r
+> > not allow nmbug tags with "::".  Since the check is done for all\r
+> > tagging operations in Emacs UI, this basically means that no nmbug\r
+> > tags can be changed.  The patch relaxes the tag syntax check to allow\r
+> > any tag names that do not include whitespace characters.\r
+> \r
+> Imho the syntax check should be in cli, or lib even. I posted a patch to\r
+> cli some time ago when I realized it's possible to add tag "-" but you\r
+> can't remove it with the current cli. (On the road, can't find the message\r
+> id now.)\r
+> \r
+\r
+I agree that this is an issue (a general issue for notmuch, not just\r
+Emacs UI).  But it is outside of scope of this patch.  This patch\r
+purpose is just to solve an immediate issue with a broken regexp.\r
+\r
+Regards,\r
+  Dmitry\r
+\r
+> > ---\r
+> >  emacs/notmuch.el |    2 +-\r
+> >  1 files changed, 1 insertions(+), 1 deletions(-)\r
+> >\r
+> > diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+> > index 9813e0a..0de6123 100644\r
+> > --- a/emacs/notmuch.el\r
+> > +++ b/emacs/notmuch.el\r
+> > @@ -555,7 +555,7 @@ notmuch-after-tag-hook will be run."\r
+> >   ;; Perform some validation\r
+> >   (when (null tags) (error "No tags given"))\r
+> >   (mapc (lambda (tag)\r
+> > -         (unless (string-match-p "^[-+][-+_.[:word:]]+$" tag)\r
+> > +         (unless (string-match-p "^[-+]\\S-+$" tag)\r
+> >            (error "Tag must be of the form `+this_tag' or `-that_tag'")))\r
+> >        tags)\r
+> >   (run-hooks 'notmuch-before-tag-hook)\r
+> > --\r
+> > 1.7.8.3\r
+> >\r
+> > _______________________________________________\r
+> > notmuch mailing list\r
+> > notmuch@notmuchmail.org\r
+> > http://notmuchmail.org/mailman/listinfo/notmuch\r
+Non-text part: text/html\r