Re: [PATCH 0/3] Make notmuch-show-refresh-view retain state by default

diff --git a/41/a2c57df37ccef2691cc1eb5302ec9fdf9f6050 b/41/a2c57df37ccef2691cc1eb5302ec9fdf9f6050
new file mode 100644 (file)
index 0000000..20c27dc
--- /dev/null
+++ b/41/a2c57df37ccef2691cc1eb5302ec9fdf9f6050
@@ -0,0 +1,102 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 66A08431FB6\r
+       for <notmuch@notmuchmail.org>; Sun, 19 Feb 2012 09:27:36 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id fwktTYtHw1id for <notmuch@notmuchmail.org>;\r
+       Sun, 19 Feb 2012 09:27:35 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU\r
+       [18.7.68.35])\r
+       by olra.theworths.org (Postfix) with ESMTP id B3F7B431FAE\r
+       for <notmuch@notmuchmail.org>; Sun, 19 Feb 2012 09:27:35 -0800 (PST)\r
+X-AuditID: 12074423-b7f9c6d0000008c3-0c-4f4131072d6c\r
+Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
+       by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id FD.06.02243.701314F4; Sun, 19 Feb 2012 12:27:35 -0500 (EST)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q1JHRYL3025989; \r
+       Sun, 19 Feb 2012 12:27:34 -0500\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q1JHRWFC009074\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Sun, 19 Feb 2012 12:27:33 -0500 (EST)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1RzAW5-0007W5-Qu; Sun, 19 Feb 2012 12:25:41 -0500\r
+Date: Sun, 19 Feb 2012 12:25:41 -0500\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>\r
+Subject: Re: [PATCH 0/3] Make notmuch-show-refresh-view retain state by\r
+ default\r
+Message-ID: <20120219172541.GQ5991@mit.edu>\r
+References: <1329632533-16152-1-git-send-email-amdragon@mit.edu>\r
+       <m2k43jw43j.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <m2k43jw43j.fsf@guru.guru-group.fi>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42IR4hTV1mU3dPQ32N7OZnH95kxmizcr57E6\r
+       MHkc/rqQxePZqlvMAUxRXDYpqTmZZalF+nYJXBm35zxgLDjCUXHxhHkD4xu2LkZODgkBE4mH\r
+       v49A2WISF+6tB7K5OIQE9jFKnO34xgLhbGCUePjmAyOEc5JJonH+UiYIZwmjxMlnTYwg/SwC\r
+       qhJnNs5gBrHZBDQktu1fDhYXEVCReNC2nhXEZhaQlvj2u5kJxBYWCJSY934KO4jNK6Atcf7i\r
+       HxYQW0ggTaKjeQkzRFxQ4uTMJywQvVoSN/69BOrlAJuz/B8HiMkpYCDxd0IJSIUo0KYpJ7ex\r
+       TWAUmoWkeRaS5lkIzQsYmVcxyqbkVunmJmbmFKcm6xYnJ+blpRbpmunlZpbopaaUbmIEBTW7\r
+       i/IOxj8HlQ4xCnAwKvHwSpU5+AuxJpYVV+YeYpTkYFIS5bUxcPQX4kvKT6nMSCzOiC8qzUkt\r
+       PsQowcGsJMJbetPeX4g3JbGyKrUoHyYlzcGiJM6rofXOT0ggPbEkNTs1tSC1CCYrw8GhJMHr\r
+       AzJUsCg1PbUiLTOnBCHNxMEJMpwHaLgeSA1vcUFibnFmOkT+FKMux8cDTy4wCrHk5eelSonz\r
+       qoMUCYAUZZTmwc2BJaNXjOJAbwnzmoNU8QATGdykV0BLmICW8ArZgSwpSURISTUwCqclWrn7\r
+       X3ZzM3S8n/KG31A5qXPD/ENrTt7L6d5gb3kocOefN3OObmh3besqXCzP//24V3V2wrqfbk7q\r
+       aRK+vadqv08tVhCvnPNzt/I1ie3M0qcXCZYvmbl9dbKGdmqE7T62ZXu/X7WacCrWdvP5vtaL\r
+       4c8EXNn3f/55NGLL1NVb5DfYXn6eqsRSnJFoqMVcVJwIAFzbWl0hAwAA\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 19 Feb 2012 17:27:36 -0000\r
+\r
+Quoth Tomi Ollila on Feb 19 at 11:43 am:\r
+> On Sun, 19 Feb 2012 01:22:10 -0500, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> > Based on the thread at id:"20120213152858.GO27039@mit.edu" it seems\r
+> > like people want show refresh to retain message state by default (I\r
+> > certainly do), rather than reset it by default.  As a nice bonus, this\r
+> > fixes a broken test.\r
+> \r
+> Hmm\r
+> \r
+> Every '=' keypress in a thread removes 'unread' tag from next unread \r
+> message :o\r
+\r
+Oh dear.  It's slightly subtler than that, though.  Refreshing will\r
+remove the unread tag from the first message matching the query.  (I\r
+suspect you had tag:unread in your query?)  This is particularly\r
+confusing for state-retaining refresh because that message might not\r
+even be open.\r
+\r
+> That is probably desirable feature when refreshing view without\r
+> retaining state. Also, probably notmuch-show-refresh-view should\r
+> be fixed not to mark next message unread when retaining state ?\r
+\r
+I would argue that refresh should never have side-effects, so neither\r
+case should mark anything read.  I'll send a v2.\r