Re: [PATCH 1/8] emacs: Clean up notmuch-search-show-result

diff --git a/73/874e858f3ebefb1a657b830259e08bf04bd3a5 b/73/874e858f3ebefb1a657b830259e08bf04bd3a5
new file mode 100644 (file)
index 0000000..f34b183
--- /dev/null
+++ b/73/874e858f3ebefb1a657b830259e08bf04bd3a5
@@ -0,0 +1,85 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1B6A8431FB6\r
+       for <notmuch@notmuchmail.org>; Wed,  4 Jul 2012 09:31:48 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id xlJIMFzm9tye for <notmuch@notmuchmail.org>;\r
+       Wed,  4 Jul 2012 09:31:47 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 68AF7431FAE\r
+       for <notmuch@notmuchmail.org>; Wed,  4 Jul 2012 09:31:47 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 6BBEF100637; Wed,  4 Jul 2012 19:31:57 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <amdragon@MIT.EDU>,\r
+       Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [PATCH 1/8] emacs: Clean up notmuch-search-show-result\r
+In-Reply-To: <20120704162243.GC21653@mit.edu>\r
+References: <1341354059-29396-1-git-send-email-amdragon@mit.edu>\r
+       <1341354059-29396-2-git-send-email-amdragon@mit.edu>\r
+       <87lij0gdwt.fsf@qmul.ac.uk> <20120704162243.GC21653@mit.edu>\r
+User-Agent: Notmuch/0.13.2+73~g94db390 (http://notmuchmail.org) Emacs/23.1.1\r
+       (x86_64-redhat-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 04 Jul 2012 19:31:57 +0300\r
+Message-ID: <m2zk7febcy.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 04 Jul 2012 16:31:48 -0000\r
+\r
+On Wed, Jul 04 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+\r
+> Quoth Mark Walters on Jul 04 at  8:53 am:\r
+>> On Tue, 03 Jul 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+>> > This simplifies the code and makes it no longer cubic in the number of\r
+>> > result fields.\r
+>> \r
+>> This looks good to me and all tests pass, and I agree that this patch\r
+>> can be pushed independently of the later patches in the series.\r
+>> \r
+>> My one comment is that I, as a lisp beginner, found the use of "format"\r
+>> as a function and a variable confusing (particularly as I had not come\r
+>> across the dolist macro and that use really makes format look like a\r
+>> function).\r
+>\r
+> I can see how that would be confusing.  Unless this version of the\r
+> series is somehow perfect, I'll rename it in the second version.\r
+> Perhaps result-format for the loop variable and spec for the format\r
+> string argument?\r
+\r
+There are 'format' variables elsewhere too -- on those places it could\r
+be renamed as 'format-string' (as used else-elsewhere and the format\r
+documentation refers to STRING). As an analogy to that the 'format' in\r
+this particular dolist usage could be 'format-pair' ? (but anything goes,\r
+even the current 'format').\r
+\r
+Tomi\r
+\r
+>\r
+>> Best wishes\r
+>> \r
+>> Mark\r