--- /dev/null
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 4A2DC431FB6\r
+ for <notmuch@notmuchmail.org>; Wed, 5 Dec 2012 09:25:03 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id mPKxbhc7EVxw for <notmuch@notmuchmail.org>;\r
+ Wed, 5 Dec 2012 09:25:02 -0800 (PST)\r
+Received: from mail-la0-f53.google.com (mail-la0-f53.google.com\r
+ [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 87F90431FAE\r
+ for <notmuch@notmuchmail.org>; Wed, 5 Dec 2012 09:25:02 -0800 (PST)\r
+Received: by mail-la0-f53.google.com with SMTP id w12so4624544lag.26\r
+ for <notmuch@notmuchmail.org>; Wed, 05 Dec 2012 09:25:00 -0800 (PST)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=google.com; s=20120113;\r
+ h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+ :mime-version:content-type:x-gm-message-state;\r
+ bh=kkiB34AgzegAGGiGXUCc6NjefwVQ0RGokNXIbCzB9Uk=;\r
+ b=b/9IOXRipqcUYAwrwpApqXHqEb2808kbpXgWFV/hNvuai76Gvv0OSi7e8LS3x279n+\r
+ h1zCcwncCg04xzTBfrIQ/E65AYoD1D5TOyYiWLKrcm+2Lw9EEQ54Yg5FJnY0z+B6nwsr\r
+ xvBckdywjDS5tsFT8jOglzfQ7VUe4WTdbC0TVXIoYdzf0bY8WEz+03TmaBYN6MKC4iXc\r
+ 1bSWKfCF+XxFBm3xKZJLNZnkRP7hTtnkIVDGenyCmVszRZvBUhf+7Q1RaFOTCiNeN1Gp\r
+ T9QO6N4wcUjSWUVWWwgyWmR5ubzhyRfz9wlCAGFl2/zYhcvCrn5rZ6nrc3+M/3RV87Mo\r
+ 3rmg==\r
+Received: by 10.152.148.197 with SMTP id tu5mr2456004lab.35.1354728298067;\r
+ Wed, 05 Dec 2012 09:24:58 -0800 (PST)\r
+Received: from localhost (dsl-hkibrasgw4-fe51df00-27.dhcp.inet.fi.\r
+ [80.223.81.27])\r
+ by mx.google.com with ESMTPS id fb1sm2485820lbb.15.2012.12.05.09.24.55\r
+ (version=SSLv3 cipher=OTHER); Wed, 05 Dec 2012 09:24:56 -0800 (PST)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/3] Use invisibility to toggle display of all parts\r
+ including multipart\r
+In-Reply-To: <1354663662-20524-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1354663662-20524-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.14+140~gbe5119e (http://notmuchmail.org) Emacs/23.4.1\r
+ (i686-pc-linux-gnu)\r
+Date: Wed, 05 Dec 2012 19:24:54 +0200\r
+Message-ID: <87r4n4jtsp.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Gm-Message-State:\r
+ ALoCoQljsWS/TpT3iqPFxaLMg2X1HQ8V+jN1XAiCFVEocr9xQQFrE1yowZaafYQDH9f43rStodmj\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 05 Dec 2012 17:25:03 -0000\r
+\r
+\r
+Hi Mark -\r
+\r
+On Wed, 05 Dec 2012, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> This patch aims to do the same as\r
+> id:1354496317-24564-1-git-send-email-markwalters1009@gmail.com but\r
+> rather than reloading the buffer it uses invisibility. \r
+>\r
+> Most of the invisibility stuff was taken from notmuch-wash and adapted\r
+> to this situation.\r
+>\r
+> The general interface is that any part can have its visibility\r
+> toggled: in this version by "t" on the part button. In addition "RET"\r
+> on the part button of any "not shown" part will show it.\r
+\r
+I tested the patches (did not look at the code), and with the addition\r
+of your RET patch on top, I think the series is perfect! I very much\r
+like the functionality. Must have.\r
+\r
+> Whilst a main driver was being able to view different parts of a\r
+> multipart/alternative message, this also allows the user to toggle\r
+> images or large inline text attachments (eg text/x-tex) for\r
+> example. Indeed, even multipart part buttons can be toggled which\r
+> remove the whole tree beneath: it is unclear whether this last is useful.\r
+\r
+It's very nice that this is a general solution showing/hiding parts, and\r
+the original multipart/alternative problem is just a special case this\r
+handles. And if there's any more tweaking the special case needs, it\r
+should be done on top of this series, afterwards.\r
+\r
+> The invisibility approach has some advantages over the reloading\r
+> approach. It does not disrupt the rest of the buffer (eg\r
+> collapsed/expanded citations remain), it does not require an extra\r
+> call to the database with the possible addition of messages to the\r
+> buffer, and it fits more naturally with the other hidden/not-hidden\r
+> items.\r
+\r
+Yes, much better than the original (which already was good).\r
+\r
+Thanks for doing this.\r
+\r
+BR,\r
+Jani.\r
+\r
+\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+>\r
+>\r
+> Mark Walters (3):\r
+> emacs: show: modify insert-part-header to save the button text\r
+> emacs: show: add overlays for each part\r
+> emacs: show: add invisibility button action\r
+>\r
+> emacs/notmuch-show.el | 117 +++++++++++++++++++++++++++++++++++++++----------\r
+> 1 files changed, 93 insertions(+), 24 deletions(-)\r
+>\r
+> -- \r
+> 1.7.9.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff