Re: [PATCH 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t

diff --git a/a2/821d12d247426c9c1922eb0e849ac8f4cd7630 b/a2/821d12d247426c9c1922eb0e849ac8f4cd7630
new file mode 100644 (file)
index 0000000..098e6d7
--- /dev/null
+++ b/a2/821d12d247426c9c1922eb0e849ac8f4cd7630
@@ -0,0 +1,88 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D3BF3431FB6\r
+       for <notmuch@notmuchmail.org>; Sat, 20 Oct 2012 03:04:20 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id dHTXeMhI9sBk for <notmuch@notmuchmail.org>;\r
+       Sat, 20 Oct 2012 03:04:20 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 6372B431FAE\r
+       for <notmuch@notmuchmail.org>; Sat, 20 Oct 2012 03:04:20 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 1CB5E1000E5;\r
+       Sat, 20 Oct 2012 13:04:23 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t\r
+In-Reply-To: <87mwzi6tr6.fsf@betacantrips.com>\r
+References: <1340198947-29370-1-git-send-email-novalazy@gmail.com>\r
+       <1340198947-29370-8-git-send-email-novalazy@gmail.com>\r
+       <87txtr6o0c.fsf@betacantrips.com> <87mwzi6tr6.fsf@betacantrips.com>\r
+User-Agent: Notmuch/0.14+51~g62cd13b (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sat, 20 Oct 2012 13:04:23 +0300\r
+Message-ID: <m28vb1a28o.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 20 Oct 2012 10:04:21 -0000\r
+\r
+On Sat, Oct 20 2012, Ethan Glasser-Camp wrote:\r
+\r
+> Ethan Glasser-Camp <ethan.glasser.camp@gmail.com> writes:\r
+>\r
+>> It looks like you have better wording for patch 4/8 so I'd like to see\r
+>> you resend it.\r
+>>\r
+>> I'm marking patches 3, 4, and 7 as moreinfo. Please resubmit!\r
+>\r
+> It turns out that patch 4 already has a v2 in the thread, but I didn't\r
+> see it due to some kind of selective blindness. It would be nice if\r
+> nmbug had grouped it as part of the same patch series. \r
+\r
+I noticed the same today when I tagged your NEWS patch.\r
+\r
+By looking contrib/nmbug/nmbug-status the reason seems obvious:\r
+it iterates over messages and resets thread when thread id changes\r
+(and message ordering is not based on threads).\r
+\r
+There is 2 ways to "fix" this: \r
+\r
+1) Iterate over threads and then messges over these threads. I looked\r
+the bindings and this didn't seem so easy as one could imagine..\r
+\r
+2) Iterate over messages like now, but cache the content to an objects\r
+in hash where thread-id is the key.\r
+ \r
+If no-one points me an easy way to do (1), I'll attempt (2) (in a distant\r
+future ;)\r
+\r
+>\r
+> I'm marking the old patch 4/8 obsolete. Only patch 3 and 7 remain.\r
+>\r
+> Ethan\r
+\r
+Tomi\r