Re: [PATCH 1/2] config: Add 'config list' command

diff --git a/23/0ff48eac32c92d31d06718d21c73955d0bb10f b/23/0ff48eac32c92d31d06718d21c73955d0bb10f
new file mode 100644 (file)
index 0000000..64133b3
--- /dev/null
+++ b/23/0ff48eac32c92d31d06718d21c73955d0bb10f
@@ -0,0 +1,91 @@
+Return-Path: <novalazy@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C3641431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 21 Mar 2012 15:55:32 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id lzVT2m6m0nca for <notmuch@notmuchmail.org>;\r
+       Wed, 21 Mar 2012 15:55:31 -0700 (PDT)\r
+Received: from mail-pb0-f53.google.com (mail-pb0-f53.google.com\r
+       [209.85.160.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 785DA431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 21 Mar 2012 15:55:31 -0700 (PDT)\r
+Received: by pbcuo1 with SMTP id uo1so1413054pbc.26\r
+       for <notmuch@notmuchmail.org>; Wed, 21 Mar 2012 15:55:29 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=date:message-id:from:to:cc:subject:in-reply-to:references\r
+       :mime-version:content-type:content-disposition\r
+       :content-transfer-encoding;\r
+       bh=3WhJ1BbHsMf5UozH/0IjwMfH8TXomI8n4sLyXBHCRzw=;\r
+       b=sNd2RkgDxStYLg6c5jmE78/JvSYvWO0yl6dotl1/LpBNk0+B2i0owXhsfBEhbVYX6t\r
+       Vwe22rJnFjeCujcVoMkftW0OkzhE761jsZFWFzH/9FTIFPlxIFDiQoVw/m7rpAazMBIf\r
+       EUIYEMrUqnFXr9SONr9denmS2STN1R62UAyvsuBgIpiB/ldwDB3lhAhJ+t9te9cjFn5f\r
+       ++VvXSV6H2FBXWFEW8MVFurKUXKfcgcbbuhc7vsbkk9kVNsuiGhSr6uH+xddDsqAtJk9\r
+       ThJ/U24CRBqFSUl4JdrYhhzX8knh7llLRN0zS9FW4Atkan57MjPDdNjOxeYU7KMsN0kJ\r
+       3Vmg==\r
+Received: by 10.68.232.229 with SMTP id tr5mr4734437pbc.86.1332370529485;\r
+       Wed, 21 Mar 2012 15:55:29 -0700 (PDT)\r
+Received: from localhost (215.42.233.220.static.exetel.com.au.\r
+       [220.233.42.215])\r
+       by mx.google.com with ESMTPS id r6sm2292873pbq.56.2012.03.21.15.55.24\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Wed, 21 Mar 2012 15:55:26 -0700 (PDT)\r
+Date: Thu, 22 Mar 2012 09:52:03 +1100\r
+Message-ID: <20120322095203.GA2632@hili.localdomain>\r
+From: Peter Wang <novalazy@gmail.com>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>\r
+Subject: Re: [PATCH 1/2] config: Add 'config list' command\r
+In-Reply-To: <m2d385dcx8.fsf@guru.guru-group.fi>\r
+References: <1332282698-7951-1-git-send-email-novalazy@gmail.com>\r
+       <m2d385dcx8.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Disposition: inline\r
+Content-Transfer-Encoding: 8bit\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 21 Mar 2012 22:55:32 -0000\r
+\r
+On Wed, 21 Mar 2012 20:30:43 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+> On Wed, 21 Mar 2012 09:31:37 +1100, Peter Wang <novalazy@gmail.com> wrote:\r
+> > Add a command to list all keys in a given configuration section.\r
+> > \r
+> > One use is as follows: a MUA may prefer to store data in a central\r
+> > notmuch configuration file so that the data is accessible across\r
+> > different machines, e.g. an addressbook.  The list command helps\r
+> > to implement features such as tab completion on the keys.\r
+> \r
+> Before getting deeper into implementation it is good to remember\r
+> that 'notmuch config' is loosely modeled after 'git config'.\r
+> \r
+> git config --list outputs somewhat different output.\r
+> \r
+> Maybe this command should be like 'notmuch config list-section-keys'\r
+\r
+That would be fine.  The documentation never mentions keys, only\r
+sections and items.  The implementation seems to think item == group.key.\r
+\r
+Peter\r
+\r
+P.S. In the first patch free() should be g_strfreev().\r