Re: [PATCH 0/4 v4] lib: Maildir flags synchronization fixes

diff --git a/36/fdd8db667bc9c7a75449b5458a3cfeefab5544 b/36/fdd8db667bc9c7a75449b5458a3cfeefab5544
new file mode 100644 (file)
index 0000000..12bac23
--- /dev/null
+++ b/36/fdd8db667bc9c7a75449b5458a3cfeefab5544
@@ -0,0 +1,86 @@
+Return-Path: <quite@hack.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 266B5431FB6\r
+       for <notmuch@notmuchmail.org>; Tue,  6 Nov 2012 05:35:26 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ve3qoXEg+lZt for <notmuch@notmuchmail.org>;\r
+       Tue,  6 Nov 2012 05:35:25 -0800 (PST)\r
+Received: from ecki.hack.org (ecki.hack.org [194.109.217.58])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 5633D431FAE\r
+       for <notmuch@notmuchmail.org>; Tue,  6 Nov 2012 05:35:25 -0800 (PST)\r
+Received: from 84-217-31-28.tn.glocalnet.net ([84.217.31.28]\r
+       helo=kelebek.lublin.se)\r
+       by ecki.hack.org with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256)\r
+       id 1TVjJL-000G1m-IN\r
+       for notmuch@notmuchmail.org; Tue, 06 Nov 2012 14:35:23 +0100\r
+Received: from quite by kelebek.lublin.se with local (Exim 4.80.1)\r
+       (envelope-from <quite@hack.org>) id 1TVjJK-0002jB-Ql\r
+       for notmuch@notmuchmail.org; Tue, 06 Nov 2012 14:35:22 +0100\r
+Date: Tue, 6 Nov 2012 14:35:22 +0100\r
+From: Daniel <quite@hack.org>\r
+To: notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/4 v4] lib: Maildir flags synchronization fixes\r
+Message-ID: <20121106133522.GA2029@kelebek.lublin.se>\r
+References: <20121106001633.GA14918@kelebek.lublin.se>\r
+       <87d2zro4qj.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <87d2zro4qj.fsf@zancas.localnet>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 06 Nov 2012 13:35:26 -0000\r
+\r
+> > I came across it, having been annoyed by the fact that notmuch broke my reading\r
+> > habits by marking messages (in the mutt sense) as seen, which I hadn't really\r
+> > seen yet in mutt. I tried out the patch; it applied and seems to work. What can\r
+> > I do to make it be applied? Other than giving it some attention. I must say\r
+> > that I have zero insight in the test framework, but if that's what's needed\r
+> > from me...\r
+> \r
+> The patches need to be reviewed for correctness and style. Typically any\r
+> non-trivial patch (or series) needs two reviews. You can see examples in\r
+> the archives of how this works.  They are currently marked stale, which\r
+> is supposed to mean they no long apply. On the other hand, if they apply\r
+> for you, maybe that tagging is wrong (see http://notmuchmail.org/nmbug/\r
+> for more information about patch tagging).\r
+\r
+I'm completely new to the notmuch core (but have been a user of the alot and\r
+emacs client for a while), and couldn't really say that they are completely\r
+fine.\r
+\r
+But they do apply (with some offset) to current master. They work, seem to do\r
+what they say--and the test runs OK.\r
+\r
+Thus I have now (after having been given access by David) removed\r
+notmuch::stale and added notmuch::needs-review on the following:\r
+\r
+2011-09-15 Louis Rilling\r
+id:"1316039001-32602-4-git-send-email-l.rilling@av7.net"\r
+  [PATCH 3/4] test: Adding non-maildir tags does not move message\r
+id:"1316039001-32602-5-git-send-email-l.rilling@av7.net"\r
+  [PATCH 4/4] tags_to_maildir_flags: Don't rename if no flags change\r
+\r
+And reviewers?\r