Re: [PATCH] test: make test_expect_equal_file() arguments flexible

diff --git a/17/3af4e98a41bd3a91d027cbf272b19878d9e256 b/17/3af4e98a41bd3a91d027cbf272b19878d9e256
new file mode 100644 (file)
index 0000000..5af2988
--- /dev/null
+++ b/17/3af4e98a41bd3a91d027cbf272b19878d9e256
@@ -0,0 +1,69 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D6DCA431FB6\r
+       for <notmuch@notmuchmail.org>; Sat,  1 Sep 2012 19:38:15 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id yCFyi2Poomlf for <notmuch@notmuchmail.org>;\r
+       Sat,  1 Sep 2012 19:38:15 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 7BC7E431FAF\r
+       for <notmuch@notmuchmail.org>; Sat,  1 Sep 2012 19:38:15 -0700 (PDT)\r
+Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.89.108] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1T804k-0007XT-Pz; Sat, 01 Sep 2012 23:38:14 -0300\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1T804f-0003ke-AS; Sat, 01 Sep 2012 23:38:09 -0300\r
+From: David Bremner <david@tethera.net>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible\r
+In-Reply-To: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+References: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+User-Agent: Notmuch/0.14 (http://notmuchmail.org) Emacs/24.1.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 01 Sep 2012 23:38:09 -0300\r
+Message-ID: <87sjb1b14e.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 02 Sep 2012 02:38:16 -0000\r
+\r
+Dmitry Kurochkin <dmitry.kurochkin@gmail.com> writes:\r
+\r
+> Before the change, test_expect_equal_file() function treated the first\r
+> argument as "actual output file" and the second argument as "expected\r
+> output file".  When the test fails, the files are copied for later\r
+> inspection.  The first files was copied to "$testname.output" and the\r
+> second file to "$testname.expected".  The argument order for\r
+> test_expect_equal_file() is often wrong which results in confusing\r
+> diff output and incorrectly named files.\r
+\r
+pushed, \r
+\r
+d\r