Re: [Patch v2 0/3] emacs: allow show to colour based on tags and flags

diff --git a/68/b70bcf3a5304ed03a25e3b8cebe0f6b17f5fdd b/68/b70bcf3a5304ed03a25e3b8cebe0f6b17f5fdd
new file mode 100644 (file)
index 0000000..5db1427
--- /dev/null
+++ b/68/b70bcf3a5304ed03a25e3b8cebe0f6b17f5fdd
@@ -0,0 +1,142 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1F334431FB6\r
+       for <notmuch@notmuchmail.org>; Sat,  5 May 2012 04:57:43 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.321\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.321 tagged_above=-999 required=5\r
+       tests=[NO_DNS_FOR_FROM=0.379, RCVD_IN_DNSWL_LOW=-0.7]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 3O9tiB1dPfbH for <notmuch@notmuchmail.org>;\r
+       Sat,  5 May 2012 04:57:36 -0700 (PDT)\r
+Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com\r
+       [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 424F3431FAE\r
+       for <notmuch@notmuchmail.org>; Sat,  5 May 2012 04:57:36 -0700 (PDT)\r
+Received: by lahc1 with SMTP id c1so2834909lah.26\r
+       for <notmuch@notmuchmail.org>; Sat, 05 May 2012 04:57:34 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=from:to:cc:subject:in-reply-to:references:user-agent:date\r
+       :message-id:mime-version:content-type:x-gm-message-state;\r
+       bh=LGFyqXiZbVQ094o5PZVrwNi4GejyuF9VCfi0AIZO690=;\r
+       b=ck6iu1lxSL/W7SYRpz1/ezBJ1hGmzeM1S1JpCA4lIj+A20EfKbtUhrc2x9OD8FckMu\r
+       ttMlm1MabXBuomRUvC4r+ypXsSmfrE/Zw4zhy5qTRxdh5vQM18guWYURO63xKmMNesxV\r
+       a1fySgaGypEzzhCcq1Bf3ZLMpQTdN9PYBOe2ebnIa8wW/uEoonp8oUNZtpE7/DZ6h+T4\r
+       0hQ3VPDYGIspKVFt/5+Fa3yTeAff7x1XyVDNPBwdOUl8jodoh+o4PcSu1j3334IRZ6fb\r
+       ToBEYEqGoWeA6NjRfNRN3DsO6sFkR99d9n8MTag9Lv2sOoF1Ea40gRork8IxI4tlPAfT\r
+       PEmQ==\r
+Received: by 10.112.102.136 with SMTP id fo8mr4406388lbb.106.1336219054645;\r
+       Sat, 05 May 2012 04:57:34 -0700 (PDT)\r
+Received: from localhost (dsl-hkibrasgw4-fe50dc00-68.dhcp.inet.fi.\r
+       [80.220.80.68])\r
+       by mx.google.com with ESMTPS id fx5sm14881446lbb.5.2012.05.05.04.57.31\r
+       (version=SSLv3 cipher=OTHER); Sat, 05 May 2012 04:57:33 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Mark Walters <markwalters1009@gmail.com>,\r
+       Jameson Graef Rollins <jrollins@finestructure.net>,\r
+       Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [Patch v2 0/3] emacs: allow show to colour based on tags and\r
+ flags\r
+In-Reply-To: <87txzw1otb.fsf@qmul.ac.uk>\r
+References: <1335739697-8501-1-git-send-email-markwalters1009@gmail.com>\r
+       <20120429230220.GO2704@mit.edu>\r
+       <87397jwhjp.fsf@servo.finestructure.net>\r
+       <87txzw1otb.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.12+169~g45438b0 (http://notmuchmail.org) Emacs/23.3.1\r
+       (i686-pc-linux-gnu)\r
+Date: Sat, 05 May 2012 14:57:29 +0300\r
+Message-ID: <878vh6j0wm.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Gm-Message-State:\r
+ ALoCoQl7dPlJ5VrphF+KYZONHGQ55lsUFg+e6RnoaXG528amo+WTxbaPUgTuoaZ7hHklFt4jVLgu\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 05 May 2012 11:57:43 -0000\r
+\r
+On Fri, 04 May 2012, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> On Wed, 02 May 2012, Jameson Graef Rollins <jrollins@finestructure.net> wrote:\r
+>> On Sun, Apr 29 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+>>> I haven't really looked at this series yet, but I do have a quick\r
+>>> high-level question.  Why use separate customization variables for the\r
+>>> colors in search and show mode?  Wouldn't it make more sense to set\r
+>>> the colors just once and use them in both modes?\r
+>>\r
+>> I thought about this myself as soon as I read the patch.  I think I\r
+>> would always want the colors to match, so it would make sense to me to\r
+>> set them in one place.\r
+>\r
+> Hi\r
+>\r
+> I think both are useful (see my reply to Austin) but having show apply\r
+> the faces from notmuch-search first seems a good idea.\r
+>\r
+> There are a couple of extra reasons why I like the show ones\r
+> separate. One is that I like to colour headerlines of matching messages to\r
+> highlight them, but in search mode that would highlight every\r
+> line. Secondly, I colour some things "negatively" in show mode: for\r
+> example I show excluded messages in grey. This negative colouring does\r
+> not make sense for search mode because I would only want to grey out\r
+> results where all messages were excluded not results where at least one\r
+> message is excluded. Of course we don't show entirely excluded threads\r
+> in search, but similar comments apply to say the "replied" tag: I could\r
+> show those in green (on the basis they are "dealt with") but I would not\r
+> want a thread coloured green just because I have replied to one message\r
+> in it.\r
+\r
+I completely agree with having separate faces for search and show.\r
+\r
+>>> BTW, I like how this clearly distinguishes tags and flags.  I wonder\r
+>>> if we could transition to flags for some information that's current\r
+>>> shoe-horned into tags but actually represents immutable information\r
+>>> about a message (attachment, signed, and encrypted or so).\r
+>>\r
+>> Yes!  As Austin probably remembers, we've discussed this before.  I\r
+>> definitely agree that it makes sense to somehow distinguish "immutable"\r
+>> information that is a fundamental, unchanging/able property of the\r
+>> message, and it might be nice to look ahead to that here.\r
+>\r
+> In essence I agree: my only concern is can the user search for these\r
+> immutable things, and what syntax is used there. \r
+\r
+Making a separation between immutable properties (like "attachment" or\r
+"signed") and tags is a good goal, but AFAICS doing that right requires\r
+changes all the way down to the library. I wouldn't worry about it at\r
+all here. From emacs UI perspective they're all just tags. This is here\r
+now, and works; there's no need to complicate matters when there's\r
+nobody doing anything about the plumbing. Fixing this later is a trivial\r
+matter compared to the plumbing work in cli and lib.\r
+\r
+\r
+BR,\r
+Jani.\r
+\r
+\r
+\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r