Re: [PATCH] lib: Fix name reordering to handle commas without spaces

diff --git a/85/f66a9585290b1c67a44c2fc29814e20704c706 b/85/f66a9585290b1c67a44c2fc29814e20704c706
new file mode 100644 (file)
index 0000000..f46e26c
--- /dev/null
+++ b/85/f66a9585290b1c67a44c2fc29814e20704c706
@@ -0,0 +1,93 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9B9C4431FB6\r
+       for <notmuch@notmuchmail.org>; Tue,  5 Feb 2013 10:08:15 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id tK43rzV-Srlq for <notmuch@notmuchmail.org>;\r
+       Tue,  5 Feb 2013 10:08:14 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id C18AB431FAF\r
+       for <notmuch@notmuchmail.org>; Tue,  5 Feb 2013 10:08:14 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 9E8641000CA;\r
+       Tue,  5 Feb 2013 20:08:02 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Adam Wolfe Gordon <awg+notmuch@xvx.ca>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] lib: Fix name reordering to handle commas without spaces\r
+In-Reply-To: <1359588510-20106-1-git-send-email-awg+notmuch@xvx.ca>\r
+References: <1359588510-20106-1-git-send-email-awg+notmuch@xvx.ca>\r
+User-Agent: Notmuch/0.15+20~g7e29ae9 (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 05 Feb 2013 20:08:02 +0200\r
+Message-ID: <m238xavdkt.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 05 Feb 2013 18:08:15 -0000\r
+\r
+On Thu, Jan 31 2013, Adam Wolfe Gordon <awg+notmuch@xvx.ca> wrote:\r
+\r
+> Notmuch automatically re-orders names of the format "Last, First" to\r
+> "First Last" when the associated email address is\r
+> First.Last@example.com. But, if a name is of the format "Last,First"\r
+> then notmuch will format the name as "irst Last". Fix this by checking\r
+> for a space when doing the reordering.\r
+\r
+Looks good to me, but should this check any (1-n) amount of whitespace ?\r
+\r
+Tomi\r
+\r
+> ---\r
+>  lib/thread.cc |    9 +++++++--\r
+>  1 file changed, 7 insertions(+), 2 deletions(-)\r
+>\r
+> diff --git a/lib/thread.cc b/lib/thread.cc\r
+> index e976d64..005b355 100644\r
+> --- a/lib/thread.cc\r
+> +++ b/lib/thread.cc\r
+> @@ -186,8 +186,13 @@ _thread_cleanup_author (notmuch_thread_t *thread,\r
+>      if (comma && strlen(comma) > 1) {\r
+>      /* let's assemble what we think is the correct name */\r
+>      lname = comma - author;\r
+> -    fname = strlen(author) - lname - 2;\r
+> -    strncpy(clean_author, comma + 2, fname);\r
+> +    if (*(comma + 1) == ' ') {\r
+> +        fname = strlen(author) - lname - 2;\r
+> +        strncpy(clean_author, comma + 2, fname);\r
+> +    } else {\r
+> +        fname = strlen(author) - lname - 1;\r
+> +        strncpy(clean_author, comma + 1, fname);\r
+> +    }\r
+>      *(clean_author+fname) = ' ';\r
+>      strncpy(clean_author + fname + 1, author, lname);\r
+>      *(clean_author+fname+1+lname) = '\0';\r
+> -- \r
+> 1.7.9.5\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r