Re: [PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal

diff --git a/6d/7fe91069e9051f3ad5a66f11e558f54f4cd983 b/6d/7fe91069e9051f3ad5a66f11e558f54f4cd983
new file mode 100644 (file)
index 0000000..64c9b77
--- /dev/null
+++ b/6d/7fe91069e9051f3ad5a66f11e558f54f4cd983
@@ -0,0 +1,93 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 3357F431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 28 Mar 2012 18:46:11 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id wgw9NnA5MFdh for <notmuch@notmuchmail.org>;\r
+       Wed, 28 Mar 2012 18:46:10 -0700 (PDT)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id C80BD431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 28 Mar 2012 18:46:10 -0700 (PDT)\r
+Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by earth-doxen-postvirus (Postfix) with ESMTP id 18B8F66E0186;\r
+       Wed, 28 Mar 2012 18:46:10 -0700 (PDT)\r
+X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new\r
+Received: from finestructure.net (m17.ligo.caltech.edu [131.215.115.117])\r
+       (Authenticated sender: jrollins)\r
+       by earth-doxen-submit (Postfix) with ESMTP id 22C9A66E00F3;\r
+       Wed, 28 Mar 2012 18:46:05 -0700 (PDT)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id F3D22E0; Wed, 28 Mar 2012 18:46:04 -0700 (PDT)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: Fix mis-named argument to\r
+       notmuch-get-bodypart-internal\r
+In-Reply-To: <1332812426-26684-1-git-send-email-amdragon@mit.edu>\r
+References: <1332812426-26684-1-git-send-email-amdragon@mit.edu>User-Agent:\r
+ Notmuch/0.12+77~g8e9161b      (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Wed, 28 Mar 2012 18:46:02 -0700\r
+Message-ID: <87ty18kwmd.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 29 Mar 2012 01:46:11 -0000\r
+\r
+--=-=-=\r
+\r
+On Mon, Mar 26 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> Previously, this function took an argument called "message-id", even\r
+> though it was a general query, rather than a message ID.  This changes\r
+> it to "query".\r
+\r
+I'm sure the argument was named such because: the function is retrieving\r
+a message part so the query has to match just a single message, and it's\r
+only ever given a message id by anything that calls it.  And it's an\r
+unexposed internal function.  All of this to say that I think it doesn't\r
+really matter that the argument was named as it was.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.12 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJPc77aAAoJEO00zqvie6q8lwcP/0qN6VLJ0hyTs/dEvKxz8kBQ\r
+BieOr7pAn8h6xAMb/6oLjXyHw0ufNF9XLfrcON7vtgR6UkkEyGQ4S3FmrhpXnyyz\r
+oRLBfJACW7g5ZiSCN4jnJSZRrXnwgTwjz5aHi9NUoYWN4U+aTfnYemqV84drIutQ\r
+ukuRmlsbzJJnVUwVh88GW4u2+b4T7Kul4YJO5Wq1TAgKyS89a3/giAmxTVXFlQgB\r
+RspGstzgE8QUXFjJR5XhQS4CG6D5CnSNVP7DTtkidB8BOkOXcppFN60XmCeGXHsf\r
+ol6LiQTdnp7Mt8i7w0P7k4A/bJND5+G/xoh+LcoNzHg0Mt4livMHM23A1bs8/azT\r
+g7UBkh/H4qtPto6+TYgAxLsF9+pTDK/qsJObz5UG7Xn6NiWpRjJTfkY3NksKnrgF\r
+jMEpwr2UlTuZSoP3X7G+8fJrYiVRC62mZWFeqXRomYNttySuSSVSTZrggIFjYdu+\r
+Mzx33nENWFxuCl1Q79ccqg0bVZk4VdaWBjoXz4Eqpsw5nTRspcHUieHNls2leeER\r
+vZlfV1Vk5wnQOHmiZR/8LSThLn3Oo8XFI8sRCRsYugfe4Q3BHdwHuLo0AEw+dsYi\r
+I2URhTnspqRTwlaIJdZTMQrY1xfy18eK9lEkesX10K6vAdWKObuuPBt7Cc3o+GAY\r
+J2YDBbhG5Pthm1B75Q6M\r
+=mWFS\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r