--- /dev/null
+Return-Path: <sojkam1@fel.cvut.cz>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 6BC67431FAF\r
+ for <notmuch@notmuchmail.org>; Thu, 6 Sep 2012 07:12:22 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 8QSKd15xun-4 for <notmuch@notmuchmail.org>;\r
+ Thu, 6 Sep 2012 07:12:21 -0700 (PDT)\r
+Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])\r
+ by olra.theworths.org (Postfix) with ESMTP id 5A17F431FAE\r
+ for <notmuch@notmuchmail.org>; Thu, 6 Sep 2012 07:12:21 -0700 (PDT)\r
+Received: from localhost (unknown [192.168.200.4])\r
+ by max.feld.cvut.cz (Postfix) with ESMTP id F0CBF19F30DD;\r
+ Thu, 6 Sep 2012 16:12:16 +0200 (CEST)\r
+X-Virus-Scanned: IMAP AMAVIS\r
+Received: from max.feld.cvut.cz ([192.168.200.1])\r
+ by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new,\r
+ port 10044)\r
+ with ESMTP id 3JucGTLQ4i9b; Thu, 6 Sep 2012 16:12:07 +0200 (CEST)\r
+Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])\r
+ by max.feld.cvut.cz (Postfix) with ESMTP id 77EA219F32DD;\r
+ Thu, 6 Sep 2012 16:12:07 +0200 (CEST)\r
+Received: from steelpick.2x.cz (note-sojka.felk.cvut.cz [147.32.86.30])\r
+ (Authenticated sender: sojkam1)\r
+ by imap.feld.cvut.cz (Postfix) with ESMTPSA id 746EE660904;\r
+ Thu, 6 Sep 2012 16:12:07 +0200 (CEST)\r
+Received: from wsh by steelpick.2x.cz with local (Exim 4.80)\r
+ (envelope-from <sojkam1@fel.cvut.cz>)\r
+ id 1T9coR-0002Nc-Ac; Thu, 06 Sep 2012 16:12:07 +0200\r
+From: Michal Sojka <sojkam1@fel.cvut.cz>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2] emacs: Add customization group for replying\r
+In-Reply-To: <m2sjavxnc8.fsf@guru.guru-group.fi>\r
+References: <1346919815-20397-1-git-send-email-sojkam1@fel.cvut.cz>\r
+ <m2wr07fs0y.fsf@guru.guru-group.fi>\r
+ <87y5kntjf1.fsf@steelpick.2x.cz>\r
+ <m2sjavxnc8.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.14+23~g9d68aca (http://notmuchmail.org) Emacs/24.1.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Thu, 06 Sep 2012 16:12:07 +0200\r
+Message-ID: <87k3w7jl54.fsf@steelpick.2x.cz>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 06 Sep 2012 14:12:22 -0000\r
+\r
+On Thu, Sep 06 2012, Tomi Ollila wrote:\r
+> On Thu, Sep 06 2012, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+>\r
+>>> So far good, but...\r
+>>>\r
+>>> You forgot to handle the current group setting for \r
+>>> notmuch-message-replied-tags -- currently notmuch-message.el has this:\r
+>>>\r
+>>> (defcustom notmuch-message-replied-tags '("replied")\r
+>>> "Tags to be automatically added to or removed from a message when it is\r
+>>> replied to.\r
+>>> Any tag in the list will be added to a replied message or,\r
+>>> if it is prefaced with a \"-\", removed.\r
+>>>\r
+>>> For example, if you wanted to add a \"replied\" tag and remove\r
+>>> the \"inbox\" and \"todo\", you would set\r
+>>> (\"replied\" \"-inbox\" \"-todo\"\)"\r
+>>> :type 'list\r
+>>> :group 'notmuch-send)\r
+>>>\r
+>>> If the above was changed to 'normuch-send, (require 'notmuch-lib)\r
+>>> was added to the beginning of notmuch-message.el and the defgroup\r
+>>> below was written as\r
+>>>\r
+>>> (defgroup notmuch-reply\r
+>>> '((message-insertion custom-group)))\r
+>>> "Replying to messages.\r
+>>> ...\r
+>>>\r
+>>> would that work as expected ?\r
+>>\r
+>> Hi Tomi,\r
+>>\r
+>> I don't really get what are you trying to say. Do you mean that\r
+>> notmuch-message-replied-tags is referenced from notmuch-lib.el without\r
+>> (require 'notmuch-message)? I'm not sure whether it is required, but it\r
+>> works here without problems.\r
+>\r
+> Ok, some sillines in my part and something I did not check well\r
+> enough before replying...\r
+>\r
+> First, notmuch-lib.el defines notmuch-send group, yet \r
+> (defcustom notmuch-message-replied-tags ...) is defined \r
+> in notmuch-message.el which is not requiring notmuch-lib...\r
+> and all of this works now...\r
+>\r
+> Actually, notmuch-lib.el defines all defgroups (except coolj).\r
+>\r
+> Then, I found the following: notmuch-mua-send-hook is defined \r
+> both in notmuch-hooks and notmuch-send groups (having a precedent\r
+> helps a bit there when choosing alternatives below)\r
+>\r
+>\r
+> All the defgroups are defined using pattern:\r
+>\r
+> (defgroup notmuch-<group> nil ...)\r
+>\r
+> We should follow this pattern unless there is good reason not to \r
+> do so here: notmuch-send is written as:\r
+>\r
+> (defgroup notmuch-send nil\r
+> "Sending messages from Notmuch."\r
+> :group 'notmuch)\r
+>\r
+> (custom-add-to-group 'notmuch-send 'message 'custom-group)\r
+>\r
+> But, as the documentation in this notmuch-reply definition references\r
+> 'Message insertion' group, doing\r
+>\r
+> (defgroup notmuch-reply \r
+> '((message-insertion custom-group))'\r
+> "Replying to messages.\r
+>\r
+> Most of the reply customization settings can be found in `Message\r
+> insertion' group. Notmuch specific settings are included directly\r
+> here."\r
+> :group 'notmuch)\r
+>\r
+> could be good thing to do here; definition matches doc from the beginning\r
+> (just not adding any of the custom variables, yet).\r
+>\r
+>\r
+> Now, currently notmuch-message.el defines notmuch-message-replied-tags\r
+> and puts that to :group 'notmuch-send\r
+>\r
+> There are 2 alternatives:\r
+>\r
+> 1) change that to :group 'notmuch-reply\r
+\r
+Now I understand. I think that 1) would be a good solution. I'll wait a\r
+bit for other comments and than I'll send a new patch.\r
+\r
+-Michal\r
+\r
+>\r
+> 2) add (custom-add-to-group 'notmuch-reply 'notmuch-message-replied-tags 'custom-variable)\r
+> to notmuch-message.el (or notmuch-lib.el)\r
+>\r
+> 2b) change :group 'notmuch-send -> :group 'notmuch-reply and\r
+> add (custom-add-to-group 'notmuch-send 'notmuch-message-replied-tags 'custom-variable)\r
+> to notmuch-message.el (or notmuch-lib.el)\r
+>\r
+>\r
+> I personally would slightly lean to option 1 but if 2 gets more \r
+> supporters then 2b (so that the spesific group is in the group definition).\r
+>\r
+> On other words; 1 or 2b gets LGTM from me :)\r
projects / notmuch-archives.git / commitdiff