--- /dev/null
+Return-Path: <mpn@google.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 1C760431FB6\r
+ for <notmuch@notmuchmail.org>; Tue, 4 Dec 2012 15:04:29 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id hUfUVEivfuzQ for <notmuch@notmuchmail.org>;\r
+ Tue, 4 Dec 2012 15:04:28 -0800 (PST)\r
+Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com\r
+ [74.125.83.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client\r
+ certificate requested) by olra.theworths.org (Postfix) with ESMTPS id\r
+ D171B431FAE for <notmuch@notmuchmail.org>; Tue, 4 Dec 2012 15:04:27 -0800\r
+ (PST)\r
+Received: by mail-ee0-f53.google.com with SMTP id c50so2976152eek.26\r
+ for <notmuch@notmuchmail.org>; Tue, 04 Dec 2012 15:04:26 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\r
+ s=20120113; h=sender:from:to:subject:in-reply-to:organization:references\r
+ :user-agent:x-face:face:x-pgp:x-pgp-fp:date:message-id:mime-version\r
+ :content-type; bh=u0LD3WivIfOhPL3atoskyCoPNIG1E+pLO96zYm/YYXk=;\r
+ b=p3hp9Btm/BX5qBtwHDZ7hXn2JMIxSL7DAbNhGZSrNJfCjrilSkHRwPmgJd5cocOJrd\r
+ dQ9m0hSd1hfwT2qCiF2CJcA5ogfSiJMb9bkbDYAgpHQiN6maQzDoRWg851fp11q7m2t3\r
+ 6mNZv4yGGqoF6xmmUhj0J009Mk3D84Rlr2FuB2MrI+XqGM+9oZPcYV87BPSSIsX53kXt\r
+ CNDV7yF6KTB/VJ/BuCAewwKol9yDAp0TnYVoulmdJT5g85WLzXorAGjVmgVHDqUvSPxs\r
+ o6dtYUsPd9WGHqqfOHQYqN49yksK27Js3XDrxg/MAsiU4IWaJbMsxu7kA9ptYAAEj5m/ SbRQ==\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=google.com; s=20120113;\r
+ h=sender:from:to:subject:in-reply-to:organization:references\r
+ :user-agent:x-face:face:x-pgp:x-pgp-fp:date:message-id:mime-version\r
+ :content-type:x-gm-message-state;\r
+ bh=u0LD3WivIfOhPL3atoskyCoPNIG1E+pLO96zYm/YYXk=;\r
+ b=R+QlhdkkQoPnfIofvgk3fkQAPdDbBcDqUhLwnD5RCa7v14CdakveUl/BCcrST5EYYC\r
+ xTwJzN6vWDRRbWuW6xWFOJQP83UlF5P398B+h9bHueNce2kv5PzBuuzFi568OpNyUmDh\r
+ UrzsQy9kLZLtizLNQkN+ErT/eeRfP1d8tDp+S9JEycXJ1/t8LVfz0XzSW9HfJnfbUum7\r
+ /JYptdR18BfbUIptQd1t0iVr5iHuJmd4mwBTI74um4C5samxMRUqMe9dOGIFf9WdPgZ7\r
+ q4uHIemhyOsSnqAL5R1VMchiBN9vSaMHa+xevCHjvoVoR5ETqOg0YmBkSXeFn9wqGYtv\r
+ 8XHA==\r
+Received: by 10.14.208.137 with SMTP id q9mr53317980eeo.28.1354662266603;\r
+ Tue, 04 Dec 2012 15:04:26 -0800 (PST)\r
+Received: from mpn-glaptop ([2620:0:105f:5:8c95:2fd8:feb2:1f3c])\r
+ by mx.google.com with ESMTPS id k2sm5413621eep.15.2012.12.04.15.04.25\r
+ (version=TLSv1/SSLv3 cipher=OTHER);\r
+ Tue, 04 Dec 2012 15:04:25 -0800 (PST)\r
+Sender: Michal Nazarewicz <mpn@google.com>\r
+From: Michal Nazarewicz <mina86@mina86.com>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/3] test: fix count test\r
+In-Reply-To:\r
+ <0ca075ab5fb0d886d0235c1f0549db8b0b14c9b5.1354656085.git.jani@nikula.org>\r
+Organization: http://mina86.com/\r
+References: <cover.1354656085.git.jani@nikula.org>\r
+ <0ca075ab5fb0d886d0235c1f0549db8b0b14c9b5.1354656085.git.jani@nikula.org>\r
+User-Agent: Notmuch/ (http://notmuchmail.org) Emacs/24.2.50.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: PbkBB1w#)bOqd`iCe"Ds{e+!C7`pkC9a|f)Qo^BMQvy\q5x3?vDQJeN(DS?|-^$uMti[3D*#^_Ts"pU$jBQLq~Ud6iNwAw_r_o_4]|JO?]}P_}Nc&"p#D(ZgUb4uCNPe7~a[DbPG0T~!&c.y$Ur,=N4RT>]dNpd; KFrfMCylc}gc??'U2j,!8%xdD\r
+Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC\r
+X-PGP: 50751FF4\r
+X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4\r
+Date: Wed, 05 Dec 2012 00:04:20 +0100\r
+Message-ID: <xa1tfw3l2zd7.fsf@mina86.com>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/mixed; boundary="=-=-="\r
+X-Gm-Message-State: ALoCoQll6laYoKpAh56sLieFOYOMyjMUl9OuRwAloxmoHD0nbXnWhgJbckWZhDLMP/O+uGETszkIcTSTX2dZs2NJaBYYcx+RaL9I/Hrx6MW74rScawbPe0GI507AkU4OGL+/iYzIjgWdaS1PGGx5g6mOil8psRqHsUvESZTFW84FmcevVAlCSPIJiiMH6x6IMvYrYHE0uWymTTMbpNbATNuhEoAQl/l2/Q==\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 04 Dec 2012 23:04:29 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Tue, Dec 04 2012, Jani Nikula wrote:\r
+> The quoting for ${SEARCH} is broken when it's supposed to be '*', and\r
+\r
+Why is it broken? It does not appear to be broken to me and in fact the\r
+test passes.\r
+\r
+> it seems tricky to get it right. Just drop the variable and use '*'\r
+> directly. Before this, none of the messages ever matched, and the test\r
+> was comparing zeros.\r
+> ---\r
+> test/count | 23 ++++++++++-------------\r
+> 1 file changed, 10 insertions(+), 13 deletions(-)\r
+>\r
+> diff --git a/test/count b/test/count\r
+> index 300b171..8e587ff 100755\r
+> --- a/test/count\r
+> +++ b/test/count\r
+> @@ -4,37 +4,34 @@ test_description=3D'"notmuch count" for messages and th=\r
+reads'\r
+>=20=20\r
+> add_email_corpus\r
+>=20=20\r
+> -SEARCH=3D"\"*\""\r
+> -\r
+> test_begin_subtest "message count is the default for notmuch count"\r
+> test_expect_equal \\r
+> - "`notmuch search --output=3Dmessages ${SEARCH} | wc -l`" \\r
+> - "`notmuch count ${SEARCH}`"\r
+> + "`notmuch search --output=3Dmessages '*' | wc -l`" \\r
+> + "`notmuch count '*'`"\r
+>=20=20\r
+> test_begin_subtest "message count with --output=3Dmessages"\r
+> test_expect_equal \\r
+> - "`notmuch search --output=3Dmessages ${SEARCH} | wc -l`" \\r
+> - "`notmuch count --output=3Dmessages ${SEARCH}`"\r
+> + "`notmuch search --output=3Dmessages '*' | wc -l`" \\r
+> + "`notmuch count --output=3Dmessages '*'`"\r
+>=20=20\r
+> test_begin_subtest "thread count with --output=3Dthreads"\r
+> test_expect_equal \\r
+> - "`notmuch search --output=3Dthreads ${SEARCH} | wc -l`" \\r
+> - "`notmuch count --output=3Dthreads ${SEARCH}`"\r
+> + "`notmuch search --output=3Dthreads '*' | wc -l`" \\r
+> + "`notmuch count --output=3Dthreads '*'`"\r
+>=20=20\r
+> test_begin_subtest "thread count is the default for notmuch search"\r
+> test_expect_equal \\r
+> - "`notmuch search ${SEARCH} | wc -l`" \\r
+> - "`notmuch count --output=3Dthreads ${SEARCH}`"\r
+> + "`notmuch search '*' | wc -l`" \\r
+> + "`notmuch count --output=3Dthreads '*'`"\r
+>=20=20\r
+> -SEARCH=3D"from:cworth and not from:cworth"\r
+> test_begin_subtest "count with no matching messages"\r
+> test_expect_equal \\r
+> "0" \\r
+> - "`notmuch count --output=3Dmessages ${SEARCH}`"\r
+> + "`notmuch count --output=3Dmessages from:cworth and not from:cworth`"\r
+>=20=20\r
+> test_begin_subtest "count with no matching threads"\r
+> test_expect_equal \\r
+> "0" \\r
+> - "`notmuch count --output=3Dthreads ${SEARCH}`"\r
+> + "`notmuch count --output=3Dthreads from:cworth and not from:cworth`"\r
+>=20=20\r
+> test_done\r
+\r
+--=20\r
+Best regards, _ _\r
+.o. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o\r
+..o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz =\r
+ (o o)\r
+ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--\r
+--=-=-=\r
+Content-Type: multipart/signed; boundary="==-=-=";\r
+ micalg=pgp-sha1; protocol="application/pgp-signature"\r
+\r
+--==-=-=\r
+Content-Type: text/plain\r
+\r
+\r
+--==-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iQIcBAEBAgAGBQJQvoF0AAoJECBgQBJQdR/09hQP/R0VhofnHUmYXItJWr2bOBZB\r
+3ExhvQLH3/vOeKSf0kwU/rBwUod2yEVBC9nSJyztPmi2vDUI7QBwxi2IEOG7ophW\r
+8ko4lBk6ibc6f48eqBHExP1eB6MIUn2L/oQA+uED/WmTac9nVXP566+0t+SKpYBJ\r
+z26peegUP20JNHk4RK3EPBw/xP54MVwBmjD8I4TQFUv5nXUMoftrQ7Ax4g4QmFdq\r
+a2IFhCGf6w5owWEpqMV/gr1DBGOQGFtGZicHascA/SIIZ/5eqnqdC9c25TS5bU84\r
+fOn0N8L9uKYn04Gw6vcmKcTqdNwRM2e3jDCKS0AAdIuw7zuAsG3yxHaqGF7MxwzD\r
+sJzJg+ml49ZKuQIVCtz5jkTFgeIrLjokwbQuREivDpQkW3Uc8Em6KfzB+Cibq3Bw\r
+65mfSCWlacWfaPWNYY/2Lb+y5e6NMN0JTwZfLSuJRcBjM+FfEuazsQXs1QDd0uJS\r
+Q2NzRsa1gm3dcodqV4pHVWtAOgIRwuVOKKFa5m7aqPQPPxO8WcQb2Mp1u0CfKWnV\r
+sOTYEQ6mgKLTmFKjOpvsaANgsNhGLktQViYmeR7B7jrhiQKGIExNYgfH9DIIJeMh\r
+sH3zfoW5uJn6w+Z1h79O7E55XiQM/xKF5c1BHJ3KbIC9Emz+DhlkVaqNR2xkqe8/\r
+sn3kud6sKU/ZnCi0CZ0S\r
+=ZF8K\r
+-----END PGP SIGNATURE-----\r
+--==-=-=--\r
+\r
+--=-=-=--\r