Re: [PATCH 3/8] hex-escape: add function to decode escaped string in-place

diff --git a/1e/549f92b2f11955e59955f9a98e929d3278348c b/1e/549f92b2f11955e59955f9a98e929d3278348c
new file mode 100644 (file)
index 0000000..89b1d52
--- /dev/null
+++ b/1e/549f92b2f11955e59955f9a98e929d3278348c
@@ -0,0 +1,104 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id E64EE431FB6\r
+       for <notmuch@notmuchmail.org>; Thu,  5 Apr 2012 04:56:31 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id yNhlAexuinJ2 for <notmuch@notmuchmail.org>;\r
+       Thu,  5 Apr 2012 04:56:31 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 3121E431FAE\r
+       for <notmuch@notmuchmail.org>; Thu,  5 Apr 2012 04:56:31 -0700 (PDT)\r
+Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.89.108] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32)\r
+       (Exim 4.72) (envelope-from <bremner@unb.ca>)\r
+       id 1SFlIj-0000js-Iz; Thu, 05 Apr 2012 08:56:29 -0300\r
+Received: from bremner by zancas.localnet with local (Exim 4.77)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1SFlIe-0000yj-8y; Thu, 05 Apr 2012 08:56:24 -0300\r
+From: David Bremner <bremner@unb.ca>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 3/8] hex-escape: add function to decode escaped string\r
+       in-place\r
+In-Reply-To:\r
+ <026815054d3e01e6f29c0834d43ccabdf6eda481.1333231401.git.jani@nikula.org>\r
+References: <cover.1333231401.git.jani@nikula.org>\r
+       <026815054d3e01e6f29c0834d43ccabdf6eda481.1333231401.git.jani@nikula.org>User-Agent:    Notmuch/0.12+70~g46e73fe (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 05 Apr 2012 08:56:24 -0300\r
+Message-ID: <87d37mtms7.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 05 Apr 2012 11:56:32 -0000\r
+\r
+Jani Nikula <jani@nikula.org> writes:\r
+\r
+> Add function hex_decode_inplace() to decode the input string onto\r
+> itself.\r
+>\r
+> Signed-off-by: Jani Nikula <jani@nikula.org>\r
+>\r
+> ---\r
+>\r
+> This could be folded to "hex-escape: (en|de)code strings to/from\r
+> restricted character set".\r
+\r
+Probably. It's a bit hard to follow as is; somehow the code movement is\r
+a bit noisy.\r
+\r
+>      while (*p) {\r
+> -\r
+>      if (*p == escape_char) {\r
+> -\r
+unrelated whitespace changes, naughty naughty.\r
+\r
+> +hex_status_t\r
+> +hex_decode_inplace (char *p)\r
+> +{\r
+> +    return hex_decode_internal (p, (unsigned char *) p);\r
+this could probably use a comment to the effect that there _will_ be\r
+enough space.\r
+\r
+> +\r
+> +    p = in;\r
+> +    q = (unsigned char *) *out;\r
+\r
+I understand trying to minimize changes, but do p and q serve any\r
+purpose here?\r
+\r
+> +\r
+> +    return hex_decode_internal (p, q);\r
+> +}\r
+\r
+\r
+> +/*\r
+> + * Decode 'in' onto itself.\r
+> + */\r
+\r
+This is just a bit terse for my taste.\r
+\r
+d\r