Re: [PATCH v2 5/6] emacs: simplify `notmuch-show-get-messages-ids{, -search}'

diff --git a/65/07bb5f0de58c24a739c9c94d3d7bbec7b08dac b/65/07bb5f0de58c24a739c9c94d3d7bbec7b08dac
new file mode 100644 (file)
index 0000000..ca07309
--- /dev/null
+++ b/65/07bb5f0de58c24a739c9c94d3d7bbec7b08dac
@@ -0,0 +1,141 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 21ECD431FC0\r
+       for <notmuch@notmuchmail.org>; Tue, 20 Mar 2012 18:39:59 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id HEA9LtkB++t0 for <notmuch@notmuchmail.org>;\r
+       Tue, 20 Mar 2012 18:39:58 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 24C07431FAF\r
+       for <notmuch@notmuchmail.org>; Tue, 20 Mar 2012 18:39:58 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1SAAWq-0000jJ-3w; Wed, 21 Mar 2012 01:39:56 +0000\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+       helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1SAAWp-0001mI-Pp; Wed, 21 Mar 2012 01:39:55 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Pieter Praet <pieter@praet.org>, David Bremner <david@tethera.net>,\r
+       Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+Subject: Re: [PATCH v2 5/6] emacs: simplify `notmuch-show-get-messages-ids{,\r
+       -search}'\r
+In-Reply-To: <1330122640-18895-6-git-send-email-pieter@praet.org>\r
+References: <87wr7xqpuf.fsf@rocinante.cs.unb.ca>\r
+       <1330122640-18895-1-git-send-email-pieter@praet.org>\r
+       <1330122640-18895-6-git-send-email-pieter@praet.org>\r
+User-Agent: Notmuch/0.12+67~g3bd579a (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 21 Mar 2012 01:40:08 +0000\r
+Message-ID: <87pqc6wx3b.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: 36f7c22242a3cc96081baed0ad393f18 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -1.8 points.\r
+       Summary of the scoring: \r
+       * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+       *      medium trust\r
+       *      [138.37.6.40 listed in list.dnswl.org]\r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+       *      domain\r
+       *  0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 21 Mar 2012 01:39:59 -0000\r
+\r
+On Fri, 24 Feb 2012 23:30:39 +0100, Pieter Praet <pieter@praet.org> wrote:\r
+> * emacs/notmuch-show.el\r
+> \r
+>   (notmuch-show-get-messages-ids):\r
+>     If provided with optional arg SEPARATOR, return a string consisting\r
+>     of all Message-Id's, separated by SEPARATOR.  Also improve original\r
+>     docstring wrt default return value.\r
+> \r
+>   (notmuch-show-get-messages-ids-search):\r
+>     Removed, as its functionality is now in `notmuch-show-get-messages-ids'.\r
+> \r
+>   (notmuch-show-tag-all):\r
+>     Call `notmuch-show-get-messages-ids' with SEPARATOR arg instead of\r
+>     `notmuch-show-get-messages-ids-search'.\r
+> ---\r
+>  emacs/notmuch-show.el |   18 +++++++++---------\r
+>  1 files changed, 9 insertions(+), 9 deletions(-)\r
+> \r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 6adbdc0..05606fc 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -1339,17 +1339,17 @@ (defun notmuch-show-get-message-id ()\r
+>    "Return the message id of the current message."\r
+>    (concat "id:\"" (notmuch-show-get-prop :id) "\""))\r
+>  \r
+> -(defun notmuch-show-get-messages-ids ()\r
+> -  "Return all message ids of messages in the current thread."\r
+> +(defun notmuch-show-get-messages-ids (&optional separator)\r
+> +  "Return a list of Message-Id's of all messages in the current buffer.\r
+> +\r
+> +If provided with optional argument SEPARATOR, return a string\r
+> +instead, consisting of all Message-Id's separated by SEPARATOR."\r
+>    (let ((message-ids))\r
+>      (notmuch-show-mapc\r
+>       (lambda () (push (notmuch-show-get-message-id) message-ids)))\r
+> -    message-ids))\r
+> -\r
+> -(defun notmuch-show-get-messages-ids-search ()\r
+> -  "Return a search string for all message ids of messages in the\r
+> -current thread."\r
+> -  (mapconcat 'identity (notmuch-show-get-messages-ids) " or "))\r
+> +    (if separator\r
+> +    (mapconcat 'identity message-ids separator)\r
+> +      message-ids)))\r
+>  \r
+>  ;; dme: Would it make sense to use a macro for many of these?\r
+>  \r
+> @@ -1638,7 +1638,7 @@ (defun notmuch-show-tag-all (&rest tag-changes)\r
+>  \r
+>  TAG-CHANGES is a list of tag operations for `notmuch-tag'."\r
+>    (interactive (notmuch-read-tag-changes nil notmuch-show-thread-id))\r
+> -  (apply 'notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes)\r
+> +  (apply 'notmuch-tag (notmuch-show-get-messages-ids " or ") tag-changes)\r
+>    (notmuch-show-mapc\r
+>     (lambda ()\r
+>       (let* ((current-tags (notmuch-show-get-tags))\r
+\r
+Oh and I forgot to add that this patch doesn't seem to apply anymore.\r
+\r
+MW\r