--- /dev/null
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 0EA76431FBC\r
+ for <notmuch@notmuchmail.org>; Sun, 28 Oct 2012 15:34:59 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id bR1QhupAFDpB for <notmuch@notmuchmail.org>;\r
+ Sun, 28 Oct 2012 15:34:57 -0700 (PDT)\r
+Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com\r
+ [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 1E19C431FAF\r
+ for <notmuch@notmuchmail.org>; Sun, 28 Oct 2012 15:34:56 -0700 (PDT)\r
+Received: by mail-lb0-f181.google.com with SMTP id gg6so3131151lbb.26\r
+ for <notmuch@notmuchmail.org>; Sun, 28 Oct 2012 15:34:55 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=google.com; s=20120113;\r
+ h=from:to:cc:subject:in-reply-to:references:user-agent:date\r
+ :message-id:mime-version:content-type:x-gm-message-state;\r
+ bh=BVgN90h2ni5HkjZWbOm1nxgUx+V/A16IJ4bDY97knYk=;\r
+ b=pvGfpC35iSU2xWrw0hGlYmEJTpxCgyGnXpGB+V/av83xTzm7m0VJmV4yoZt7nOHvtY\r
+ 1OI8rsD6Q+U6/xYOOV+Tx91wUhf8EhMjUtBWJ4CmCDY5s6ta5sG3bvH3N2z22IdLzKkD\r
+ 81TUWelWwvHa58U9H/RB/2o6d3KkiooupBGOv0QBkBQAI87r31n8MTp9XAuzAjTz6VGJ\r
+ Zu3RJsa3zthwBz/uUc3d7jQdJZkW8eDbpVp9LUzv3Vc1hV/OhmJmkGMgeyYk92W5HlJ3\r
+ Qf6xPVPbpQ8GEQKnQz9d1aZkX1YZte0hp6gZYIcKvB6NY4WQcHmjNkdzKK3B2rCJqXTo\r
+ qvAA==\r
+Received: by 10.112.36.42 with SMTP id n10mr11261456lbj.42.1351463695575;\r
+ Sun, 28 Oct 2012 15:34:55 -0700 (PDT)\r
+Received: from localhost (dsl-hkibrasgw4-fe51df00-27.dhcp.inet.fi.\r
+ [80.223.81.27])\r
+ by mx.google.com with ESMTPS id g5sm2558418lbk.7.2012.10.28.15.34.52\r
+ (version=SSLv3 cipher=OTHER); Sun, 28 Oct 2012 15:34:53 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [PATCH v5 4/9] test: add smoke tests for the date/time parser\r
+ module\r
+In-Reply-To: <20121023042326.GP14861@mit.edu>\r
+References: <cover.1350854171.git.jani@nikula.org>\r
+ <606a94d565e6b21abfc59d6ba9676a807d669127.1350854171.git.jani@nikula.org>\r
+ <20121023042326.GP14861@mit.edu>\r
+User-Agent: Notmuch/0.14+46~g272a1f1 (http://notmuchmail.org) Emacs/23.4.1\r
+ (i686-pc-linux-gnu)\r
+Date: Mon, 29 Oct 2012 00:34:51 +0200\r
+Message-ID: <87ip9ukyyc.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Gm-Message-State:\r
+ ALoCoQn6DL5ZexPSiH/LuUEYcbvgJD3ct3SI88UPEoaIBtqCPEzPzfbMZXWQq9PRHJzUBYNO3Rk7\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 28 Oct 2012 22:34:59 -0000\r
+\r
+On Tue, 23 Oct 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> Quoth Jani Nikula on Oct 22 at 12:22 am:\r
+>> Test the date/time parser module directly, independent of notmuch,\r
+>> using the parse-time test tool.\r
+>> \r
+>> Credits to Michal Sojka <sojkam1@fel.cvut.cz> for writing most of the\r
+>> tests.\r
+>> ---\r
+>> test/notmuch-test | 1 +\r
+>> test/parse-time-string | 71 ++++++++++++++++++++++++++++++++++++++++++++++++\r
+>> 2 files changed, 72 insertions(+)\r
+>> create mode 100755 test/parse-time-string\r
+>> \r
+>> diff --git a/test/notmuch-test b/test/notmuch-test\r
+>> index cc732c3..7eadfdf 100755\r
+>> --- a/test/notmuch-test\r
+>> +++ b/test/notmuch-test\r
+>> @@ -60,6 +60,7 @@ TESTS="\r
+>> emacs-hello\r
+>> emacs-show\r
+>> missing-headers\r
+>> + parse-time-string\r
+>> "\r
+>> TESTS=${NOTMUCH_TESTS:=$TESTS}\r
+>> \r
+>> diff --git a/test/parse-time-string b/test/parse-time-string\r
+>> new file mode 100755\r
+>> index 0000000..862e701\r
+>> --- /dev/null\r
+>> +++ b/test/parse-time-string\r
+>> @@ -0,0 +1,71 @@\r
+>> +#!/usr/bin/env bash\r
+>> +test_description="date/time parser module"\r
+>> +. ./test-lib.sh\r
+>> +\r
+>> +# Sanity/smoke tests for the date/time parser independent of notmuch\r
+>> +\r
+>> +_date ()\r
+>> +{\r
+>> + date -d "$*" +%s\r
+>> +}\r
+>> +\r
+>> +_parse_time ()\r
+>> +{\r
+>> + ${TEST_DIRECTORY}/parse-time --format=%s "$*"\r
+>> +}\r
+>> +\r
+>> +test_begin_subtest "date(1) default format without TZ code"\r
+>> +test_expect_equal "$(_parse_time Fri Aug 3 23:06:06 2012)" "$(_date Fri Aug 3 23:06:06 2012)"\r
+>> +\r
+>> +test_begin_subtest "date(1) --rfc-2822 format"\r
+>> +test_expect_equal "$(_parse_time Fri, 03 Aug 2012 23:07:46 +0100)" "$(_date Fri, 03 Aug 2012 23:07:46 +0100)"\r
+>> +\r
+>> +test_begin_subtest "date(1) --rfc=3339=seconds format"\r
+>> +test_expect_equal "$(_parse_time 2012-08-03 23:09:37+03:00)" "$(_date 2012-08-03 23:09:37+03:00)"\r
+>> +\r
+>> +test_begin_subtest "Date parser tests"\r
+>> +REFERENCE=$(_date Tue Jan 11 11:11:00 +0000 2011)\r
+>> +cat <<EOF > INPUT\r
+>> +now ==> Tue Jan 11 11:11:00 +0000 2011\r
+>> +2010-1-1 ==> ERROR: 5\r
+>\r
+> It would be nice if these errors were strings. I have no idea if "5"\r
+> is the right error for this.\r
+\r
+Good idea. Will fix.\r
+\r
+>> +Jan 2 ==> Sun Jan 02 11:11:00 +0000 2011\r
+>> +Mon ==> Mon Jan 10 11:11:00 +0000 2011\r
+>> +last Friday ==> ERROR: 4\r
+>> +2 hours ago ==> ERROR: 1\r
+\r
+I'll silently eat away "ago" too.\r
+\r
+>> +last month ==> Sat Dec 11 11:11:00 +0000 2010\r
+>> +month ago ==> ERROR: 1\r
+>> +8am ==> Tue Jan 11 08:00:00 +0000 2011\r
+>> +9:15 ==> Tue Jan 11 09:15:00 +0000 2011\r
+>> +12:34 ==> Tue Jan 11 12:34:00 +0000 2011\r
+>> +monday ==> Mon Jan 10 11:11:00 +0000 2011\r
+>> +yesterday ==> Mon Jan 10 11:11:00 +0000 2011\r
+>> +tomorrow ==> ERROR: 1\r
+>> + ==> Tue Jan 11 11:11:00 +0000 2011 # empty string is reference time\r
+>> +\r
+>> +Aug 3 23:06:06 2012 ==> Fri Aug 03 23:06:06 +0000 2012 # date(1) default format without TZ code\r
+>> +Fri, 03 Aug 2012 23:07:46 +0100 ==> Fri Aug 03 22:07:46 +0000 2012 # rfc-2822\r
+>> +2012-08-03 23:09:37+03:00 ==> Fri Aug 03 20:09:37 +0000 2012 # rfc-3339 seconds\r
+>> +\r
+>> +10s ==> Tue Jan 11 11:10:50 +0000 2011\r
+>> +19701223s ==> Fri May 28 10:37:17 +0000 2010\r
+>> +19701223 ==> Wed Dec 23 11:11:00 +0000 1970\r
+>> +\r
+>> +19701223 +0100 ==> Wed Dec 23 11:11:00 +0000 1970 # Timezone is ignored without an error\r
+>> +\r
+>> +today ==^> Tue Jan 11 23:59:59 +0000 2011\r
+>> +today ==_> Tue Jan 11 00:00:00 +0000 2011\r
+>> +\r
+>> +thisweek ==^> Sat Jan 15 23:59:59 +0000 2011\r
+>> +thisweek ==_> Sun Jan 09 00:00:00 +0000 2011\r
+>> +\r
+>> +two months ago==> ERROR: 1 # "ago" is not supported\r
+>> +two months ==> Thu Nov 11 11:11:00 +0000 2010\r
+>> +\r
+>> +@1348569850 ==> Tue Sep 25 10:44:10 +0000 2012\r
+>> +@10 ==> Thu Jan 01 00:00:10 +0000 1970\r
+>\r
+> Very nice. The only thing that jumps out at me is that there are no\r
+> ==^^> tests, though it would be interesting to run a code coverage\r
+> tool to see how thorough these tests are.\r
+\r
+Again, most of the credit here goes to Michal Sojka.\r
+\r
+Will add some ==^^> tests too.\r
+\r
+\r
+BR,\r
+Jani.\r
+\r
+\r
+>\r
+>> +EOF\r
+>> +\r
+>> +${TEST_DIRECTORY}/parse-time --ref=${REFERENCE} < INPUT > OUTPUT\r
+>> +test_expect_equal_file INPUT OUTPUT\r
+>> +\r
+>> +test_done\r
projects / notmuch-archives.git / commitdiff