Re: [PATCH v2 0/4] Add a --body option to notmuch show
authorJameson Graef Rollins <jrollins@finestructure.net>
Mon, 23 Jul 2012 19:16:32 +0000 (12:16 +1700)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:48:30 +0000 (09:48 -0800)
bf/3a3c17123d17bf26a286170a67569968c14dc8 [new file with mode: 0644]

diff --git a/bf/3a3c17123d17bf26a286170a67569968c14dc8 b/bf/3a3c17123d17bf26a286170a67569968c14dc8
new file mode 100644 (file)
index 0000000..952e512
--- /dev/null
@@ -0,0 +1,104 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 4FEA3431FB6\r
+       for <notmuch@notmuchmail.org>; Mon, 23 Jul 2012 12:16:40 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id v2GUH8xqlwoj for <notmuch@notmuchmail.org>;\r
+       Mon, 23 Jul 2012 12:16:39 -0700 (PDT)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id A63AA431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 23 Jul 2012 12:16:39 -0700 (PDT)\r
+Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by fire-doxen-postvirus (Postfix) with ESMTP id 272302E50C64;\r
+       Mon, 23 Jul 2012 12:16:37 -0700 (PDT)\r
+X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new\r
+Received: from finestructure.net (gwave-65.ligo.caltech.edu [131.215.114.65])\r
+       (Authenticated sender: jrollins)\r
+       by fire-doxen-submit (Postfix) with ESMTP id 6BD532E507F2;\r
+       Mon, 23 Jul 2012 12:16:34 -0700 (PDT)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id 506599A0; Mon, 23 Jul 2012 12:16:34 -0700 (PDT)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 0/4] Add a --body option to notmuch show\r
+In-Reply-To: <1343066259-22523-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1343066259-22523-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.13.2+90~gb97ff6a (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 23 Jul 2012 12:16:32 -0700\r
+Message-ID: <87eho270fj.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 23 Jul 2012 19:16:40 -0000\r
+\r
+--=-=-=\r
+\r
+On Mon, Jul 23 2012, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> Version 2 of this patch set (version 1 at\r
+> id:"1343060241-18283-1-git-send-email-markwalters1009@gmail.com"). This\r
+> corrects the errors Austin spotted in v1, and makes it explicit that\r
+> --body=false and --part>0 are incompatible.\r
+>\r
+>\r
+> Mark Walters (4):\r
+>   cli: add --body=true|false option to notmuch-show.c\r
+>   test: add tests for the new --body=true|false option\r
+>   man: update man page for the new --body=true|false option\r
+>   schemata: update for --body=true|false option\r
+>\r
+>  devel/schemata          |    2 +-\r
+>  man/man1/notmuch-show.1 |   16 ++++++++++++++++\r
+>  notmuch-client.h        |    3 ++-\r
+>  notmuch-reply.c         |    2 +-\r
+>  notmuch-show.c          |   30 ++++++++++++++++++++++--------\r
+>  test/json               |    9 +++++++++\r
+>  6 files changed, 51 insertions(+), 11 deletions(-)\r
+\r
+Untested, but LGTM.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.12 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJQDaMQAAoJEO00zqvie6q8MyoQAJ2cm7+wyBzF0Ks/z+sqf++B\r
+fIp+Z52AF2+FuMtXov4XmHCW5817AanmEuCoDdYSacg+Au5E88xuUjLR5En/d8J8\r
+wG+1q1ktnrlpsP7lTZISRN9u4OeK00y+TvBt6wbqEZIZygBRX34ueBlnNiuq1jMK\r
+jxacJSmuKsr1l0V1G88wBgO5bnqCKggitdkfbjcQYb+wm3rIpWgya1yN3fU4RGxW\r
+l5Wsdq+FJZvvYZot9hHd/3P7GMJVOcYFyy2sh3i0lPyOs2JbBIK4piJmZHx7SP/A\r
+nBEGcRdNXW7E1sB5tP+IGuXvVexxJ+N1m/HiSNbo9OnMjGdgyz7mMSicC6KRuAZ3\r
+Q/Y3MHsKKu97uNSC25Hd+HbqEusyINYEug8wL0CZ9eirfK22UkVG6xKGTztI9NRn\r
+TleTd1g2XOchUUJr62m9EvgsCXKD8aY7f9VikBg2Ct5s9iEZe3GFZ4Ls3zEj31hH\r
+11JB0oIEPnPohqg3Bf1OiiWrDD04OzrNeONJZHWawUYd2PK/aOGD+9XdkppxHfgW\r
+Wq0t3Karb0guMKYk4Ib65xFm1tr62/Ww7sCrv/uS3SDHXoRCHQOoVgbqqYTa0RM4\r
+ma6OVAUPIBxRsIGFOzeKhfq3p7xe09yVLESytQ7xH/zUna/HmieETrkk167pKYIX\r
+eoXSaShdBRXklcCbyd4T\r
+=DhcT\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r